Skip to content

Conversation

SkafteNicki
Copy link
Collaborator

@SkafteNicki SkafteNicki commented Sep 2, 2025

What does this PR do?

Fixes #20695

Solves the case where multiple dataloaders are used, with the first being finite and the second being iterable (unknown total length). Due to these lines in tqdm:
https://github.com/tqdm/tqdm/blob/0ed5d7f18fa3153834cbac0aa57e8092b217cc16/tqdm/std.py#L1371-L1372
calling self.val_progress_bar.reset(total=None) after the first validation dataloader does not actually change the total value to None, thus resulting in the same total showing for the second dataloader. PR fixes this by explicitly setting the total attribute.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21147.org.readthedocs.build/en/21147/

@SkafteNicki SkafteNicki self-assigned this Sep 2, 2025
@SkafteNicki SkafteNicki added the bug Something isn't working label Sep 2, 2025
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 2, 2025
@SkafteNicki SkafteNicki changed the title Tqdm progbar reset Fix TQDM progress bar showing the wrong total when using a finite and iterable dataloader Sep 2, 2025
@Borda Borda merged commit 14a57c7 into Lightning-AI:master Sep 2, 2025
90 checks passed
Borda pushed a commit that referenced this pull request Sep 3, 2025
… iterable dataloader (#21147)

* fix implementation reset
* add testing
* changelog

(cherry picked from commit 14a57c7)
lantiga pushed a commit that referenced this pull request Sep 5, 2025
… iterable dataloader (#21147)

* fix implementation reset
* add testing
* changelog

(cherry picked from commit 14a57c7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The progress bar shows wrong length when using multiple dataloaders mixing dataset and iterable dataset
2 participants