Fix TQDM progress bar showing the wrong total when using a finite and iterable dataloader #21147
+61
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #20695
Solves the case where multiple dataloaders are used, with the first being finite and the second being iterable (unknown total length). Due to these lines in tqdm:
https://github.com/tqdm/tqdm/blob/0ed5d7f18fa3153834cbac0aa57e8092b217cc16/tqdm/std.py#L1371-L1372
calling
self.val_progress_bar.reset(total=None)
after the first validation dataloader does not actually change thetotal
value toNone
, thus resulting in the sametotal
showing for the second dataloader. PR fixes this by explicitly setting thetotal
attribute.Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21147.org.readthedocs.build/en/21147/