Skip to content

Conversation

Borda
Copy link
Member

@Borda Borda commented Aug 5, 2019

Cutting out the examples from the main package
Also, apply relative imports inside the package
Related to #36

@williamFalcon
Copy link
Contributor

Ran checks on GPU. All looks good.

collected 16 items

tests/test_models.py::test_amp_gpu_ddp PASSED                                                                    [  6%]
tests/test_models.py::test_cpu_slurm_save_load PASSED                                                            [ 12%]
tests/test_models.py::test_loading_meta_tags PASSED                                                              [ 18%]
tests/test_models.py::test_dp_output_reduce PASSED                                                               [ 25%]
tests/test_models.py::test_model_saving_loading PASSED                                                           [ 31%]
tests/test_models.py::test_model_freeze_unfreeze PASSED                                                          [ 37%]
tests/test_models.py::test_amp_gpu_ddp_slurm_managed PASSED                                                      [ 43%]
tests/test_models.py::test_early_stopping_cpu_model PASSED                                                       [ 50%]
tests/test_models.py::test_cpu_model_with_amp PASSED                                                             [ 56%]
tests/test_models.py::test_cpu_model PASSED                                                                      [ 62%]
tests/test_models.py::test_all_features_cpu_model PASSED                                                         [ 68%]
tests/test_models.py::test_single_gpu_model PASSED                                                               [ 75%]
tests/test_models.py::test_multi_gpu_model_dp PASSED                                                             [ 81%]
tests/test_models.py::test_amp_gpu_dp PASSED                                                                     [ 87%]
tests/test_models.py::test_multi_gpu_model_ddp PASSED                                                            [ 93%]
tests/test_models.py::test_ddp_sampler_error PASSED                                                              [100%]

=================================================== warnings summary ===================================================

@williamFalcon
Copy link
Contributor

Awesome commit! Thanks for contributing!

@williamFalcon williamFalcon merged commit c6a2544 into Lightning-AI:master Aug 5, 2019
@Borda Borda deleted the cutout-examples branch August 5, 2019 18:18
@davzha
Copy link

davzha commented Aug 6, 2019

Adding relative imports to the examples leads to the following error message for me:

Traceback (most recent call last):
File "single_cpu_template.py", line 16, in
from .lightning_module_template import LightningTemplateModel
ModuleNotFoundError: No module named 'main.lightning_module_template'; 'main' is not a package

@Borda
Copy link
Member Author

Borda commented Aug 6, 2019

good point @davzha, I will and the normal import for examples here #44

luiscape pushed a commit to luiscape/pytorch-lightning that referenced this pull request Jan 17, 2020
The buttons should extend the full width of the article container. Also updates the button text color and weight.
luiscape pushed a commit to luiscape/pytorch-lightning that referenced this pull request Jan 17, 2020
…m-from-headers

Remove text-transform capitalize value from h2 titles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants