[BUG] statusCheck in Items not being honored when set at appConfig level

[ridizy]

Environment

Self-Hosted (Docker)

Version

2.0.8

Describe the problem

I am setting statusCheck to true at the appConfig level. I then have some items where I don't want the status check to be enabled, and I am setting those to statusCheck: false. However, those items still have the status check enabled.

For example, I have:

appConfig:
  theme: default
  language: en
  layout: auto
  iconSize: medium
  statusCheck: true

And then I have:

items:
  - title: App1
    description: My App 1
    icon: favicon
    url: https://app1.example.com
    id: 0_393_app1
  - title: App2
    description: My App 2
    icon: favicon
    url: http://app2.example.com
    statusCheck: false
    id: 1_393_app2

I would expect App 1 to have the status check enabled and App 2 to not have it enabled. However, both items are showing up on the dashboard with the status check enabled.

Additional info

No errors are being thrown

Please tick the boxes

• You are using a supported version of Dashy (check the first two digits of the version number)
• You've checked that this issue hasn't already been raised
• You've checked the docs and troubleshooting guide
• You agree to the code of conduct

[Lissy93]

I'm afk at the moment, but what your doing sounds correct, the item-level status check should override whatevers set under appConfig. I can check this later to confirm if there's a bug.

But in your example, there's no statusCheck set in there. Did you just miss it out from the paste?

[ridizy]

Oops, thank you for taking a look and catching that. I've gone back and edited the item to include statusCheck. And yes, I just missed it when I pasted.

[Lissy93]

Can confirm, is indeed a bug 🐛

Looks like it can be fixed by updating this section in ItemMixin.js to:

/* Determines if user has enabled online status checks */
enableStatusCheck() {
  const globalPref = this.appConfig.statusCheck || false;
  const itemPref = this.item.statusCheck;
  return typeof itemPref === 'boolean' ? itemPref : globalPref;
},

I'll include it in the next PR :)

[liss-bot]

The fix for this issue has now been released in 2.0.9 ✨

If you haven't done so already, please update your instance to 2.0.9 or later. See 2.0.9 for full info.

Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project.