MDEV-37615: Clang based static analysis false postive reports on UNINIT_VAR #4290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IT_VAR Clang static analysis tools like Infer, are written around static analysis and not undefined behaviour detection at runtime. They have no -fsanitize=undefined implemented. We'd like them to follow the path #define UNINIT_VAR(x) x which is what our release binaries use. This is the only sane path for analysis that will detect uninitalization in various forms. Clang based compilers with error during compilation if any uninitialized behaviour is detected at compile time because of 0c80ddb. Corrects MDEV-36542 - 6fd57f4.
grooverdan
added
the
MariaDB Foundation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clang static analysis tools like Infer, are written around static analysis and not undefined behaviour detection at runtime.
They have no -fsanitize=undefined implemented.
We'd like them to follow the path #define UNINIT_VAR(x) x which
is what our release binaries use. This is the only sane path for analysis
that will detect uninitalization in various forms.
Clang based compilers with error during compilation if any
uninitialized behaviour is detected at compile time because of
0c80ddb.
Corrects MDEV-36542 - 6fd57f4.
Release Notes
nothing - clang not used as part of release.
How can this PR be tested?
Attempt to use infer to staticly analyse.
If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.
Basing the PR against the correct MariaDB version
mainbranch.PR quality check