Skip to content

Fix some source generator issues #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 6, 2024
Merged

Fix some source generator issues #1921

merged 2 commits into from
Aug 6, 2024

Conversation

AlanLiu90
Copy link
Contributor

Fix two issues:

  1. Source generator generates incorrect code for List<SubObject>[] in resolver:
    1 => new MsgPack::Formatters.ArrayFormatter<global::System.Collections.Generic.List<T>>(),
  2. Generated resolver can't be used in CompositeResolverAttribute in the same assembly

@AArnott AArnott added this to the v3.0 milestone Aug 6, 2024
@AArnott AArnott mentioned this pull request Aug 6, 2024
Closed
AArnott
AArnott approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@AArnott AArnott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic. Thank you very much!

@AArnott AArnott merged commit 3ea9234 into MessagePack-CSharp:develop Aug 6, 2024
@dependabot dependabot bot mentioned this pull request Jul 21, 2025
Closed
This was referenced Aug 4, 2025
Open
Open
Open
@dependabot dependabot bot mentioned this pull request Sep 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AArnott AArnott AArnott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AlanLiu90 @AArnott