Skip to content

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Sep 9, 2025

Explanation

The new metadata properties includeInStateLogs and usedInUi have been added to all controllers maintained by the core platform team.

References

Relates to #6443

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@Gudahtt Gudahtt force-pushed the add-new-metadata-to-core-controllers branch from bd0291d to a79b9fa Compare September 9, 2025 12:46
@Gudahtt Gudahtt marked this pull request as ready for review September 9, 2025 13:05
@Gudahtt Gudahtt requested review from a team as code owners September 9, 2025 13:05
@@ -487,12 +492,13 @@ type MergeCaveatResult<CaveatType extends CaveatConstraint | undefined> =
export type ExtractPermission<
ControllerPermissionSpecification extends PermissionSpecificationConstraint,
ControllerCaveatSpecification extends CaveatSpecificationConstraint,
> = ControllerPermissionSpecification extends ValidPermissionSpecification<ControllerPermissionSpecification>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were fixed by Prettier automatically. it seemed easiest to leave it in, despite it being unrelated to the other changes.

Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt force-pushed the add-new-metadata-to-core-controllers branch from 61b0fb4 to 70b340d Compare September 9, 2025 15:35
@Gudahtt Gudahtt enabled auto-merge (squash) September 9, 2025 15:35
The new metadata properties `includeInStateLogs` and `usedInUi` have
been added to all controllers maintained by the core platform  team.

Relates to #6443
@Gudahtt Gudahtt force-pushed the add-new-metadata-to-core-controllers branch from 70b340d to ed8e72c Compare September 10, 2025 14:36
@Gudahtt Gudahtt merged commit 367a6e3 into main Sep 10, 2025
239 checks passed
@Gudahtt Gudahtt deleted the add-new-metadata-to-core-controllers branch September 10, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants