refactor: migrate NetworkEnablementController to @metamask/messenger
#6540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 tasks
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
cryptodev-2s
force-pushed
the
cryptodev-2s/messenger/network-enablement-controller
branch
2 times, most recently
from
294d507 to
9130d1e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
cryptodev-2s
force-pushed
the
cryptodev-2s/messenger/network-enablement-controller
branch
from
9130d1e to
44f2265
Compare
mcmire
reviewed
Sep 10, 2025
| } | ||
| throw new Error(`Unexpected action type: ${actionType}`); | ||
| }); | ||
| const mockGetNetworkState = jest.fn().mockImplementation(() => ({ |
There was a problem hiding this comment.
I know we ought to migrate these tests so we aren't mocking the messenger, but could we leave these changes to another PR or do we have to do it here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR migrates
NetworkEnablementControllerto the new@metamask/messengermessage bus, as opposed to the one exported from@metamask/base-controller.References
Checklist