Skip to content

Conversation

PatrykLucka
Copy link
Contributor

@PatrykLucka PatrykLucka commented Sep 10, 2025

Explanation

This PR changes the account groupc uniqueness checks to validate uniqueness only within the same wallet, allowing duplicates between wallets.

References

Jira ticket: https://consensyssoftware.atlassian.net/browse/MUL-795

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@PatrykLucka PatrykLucka self-assigned this Sep 10, 2025
@PatrykLucka PatrykLucka requested a review from a team as a code owner September 10, 2025 13:28
@PatrykLucka PatrykLucka requested a review from a team as a code owner September 10, 2025 13:30
Copy link
Contributor

@ccharly ccharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 💪

@PatrykLucka PatrykLucka enabled auto-merge (squash) September 10, 2025 14:07
@PatrykLucka PatrykLucka merged commit 89ebe0d into main Sep 10, 2025
239 checks passed
@PatrykLucka PatrykLucka deleted the MUL-795-core-update-multichain-account-name-duplication-validation-to-work-per-wallet branch September 10, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants