feat: transaction and signature trust signal metrics #35772
+293
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (1 files, +3 -0)
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [0e8769d]
UI Startup Metrics (1223 ± 55 ms)
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 267 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 34 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 280 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 23 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 33 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 240 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 73 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 30 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 3 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 275 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 51 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 5 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 288ms | Sum of p95 exceeds: 544.8ms Sum of all benchmark exceeds: 832.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
❌ test-e2e-chrome-api-specs failed. View the html report here. |
imblue-dabadee
changed the title
📊 Page Load Benchmark ResultsCurrent Commit: 📄 https://metamask.github.io/test-dapp/Samples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [ffcdfd4]
UI Startup Metrics (1234 ± 63 ms)
Benchmark value 1064 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 250 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 261 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 35 exceeds gate value 33 for chrome browserify home p95 getState Benchmark value 16 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 20 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 31 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2495 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 266 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 22 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 265 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 30 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 217 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 25 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 8 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 105 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 43 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 281 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 8 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 289ms | Sum of p95 exceeds: 749.8ms Sum of all benchmark exceeds: 1038.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
whatever1341132
approved these changes
Sep 10, 2025
…ttps://github.com/MetaMask/metamask-extension into feat/metrics-on-address-trust-signals-transactions
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [547cd65]
UI Startup Metrics (1242 ± 69 ms)
Benchmark value 1078 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1071 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 252 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 16 exceeds gate value 15 for chrome browserify home mean getState Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1374 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1195 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1182 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 264 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 43 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 12 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2486 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 80 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 93 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 233 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 17 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 247 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 1555 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1340 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1339 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 116 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 41 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 30 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1309 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 15 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1878 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 1515 exceeds gate value 1495 for firefox browserify home p95 load Benchmark value 1515 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded Benchmark value 252 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 99 exceeds gate value 70 for firefox browserify home p95 backgroundConnect Benchmark value 17 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 73 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 105 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 44 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 271 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 51 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 9 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 764ms | Sum of p95 exceeds: 1087.8ms Sum of all benchmark exceeds: 1851.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
AugmentedMode
approved these changes
Sep 15, 2025
AugmentedMode
previously approved these changes
Sep 15, 2025
Comment on lines
+32
to
+40
| if (!isSignatureTransactionType(confirmation)) { | ||
| const txMeta = confirmation as TransactionMeta; | ||
| return txMeta.txParams?.to ?? null; | ||
| } | ||
| try { | ||
| const data = (confirmation as SignatureRequestType)?.msgParams?.data; | ||
| const parsedData = typeof data === 'string' ? JSON.parse(data) : data; | ||
| if (parsedData?.domain?.verifyingContract) { | ||
| return parsedData.domain.verifyingContract; |
There was a problem hiding this comment.
I feel like we use this logic in so many places throughout the extension, is there a helper function to extract this?
There was a problem hiding this comment.
matthewwalsh0
previously approved these changes
Sep 24, 2025
Comment on lines
+32
to
+40
| if (!isSignatureTransactionType(confirmation)) { | ||
| const txMeta = confirmation as TransactionMeta; | ||
| return txMeta.txParams?.to ?? null; | ||
| } | ||
| try { | ||
| const data = (confirmation as SignatureRequestType)?.msgParams?.data; | ||
| const parsedData = typeof data === 'string' ? JSON.parse(data) : data; | ||
| if (parsedData?.domain?.verifyingContract) { | ||
| return parsedData.domain.verifyingContract; |
There was a problem hiding this comment.
There was a problem hiding this comment.
Is it worth creating a ui/pages/product-safety or ui/pages/trust-signals so you can own these files?
There was a problem hiding this comment.
Done! Do we need to add something for CODEOWNERS as well?
There was a problem hiding this comment.
Approved as far as code, however not sure if you need to do something for CODEOWNERS here
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [c7f96cd]
UI Startup Metrics (1176 ± 64 ms)
Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 224 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 13 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1417 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 35 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 30 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 246 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 27 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 32 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 108 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 47 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 7 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 302 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 57 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 9 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 273ms | Sum of p95 exceeds: 466.8ms Sum of all benchmark exceeds: 739.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [ed7d81e]
UI Startup Metrics (1252 ± 58 ms)
Benchmark value 1082 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1075 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 257 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 25 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 267 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 10 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1435 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1243 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 33 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 239 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 12 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 31 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1622 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 102 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 35 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 39 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 285 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 63 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 375ms | Sum of p95 exceeds: 514.8ms Sum of all benchmark exceeds: 889.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
imblue-dabadee
dismissed stale reviews from matthewwalsh0 and AugmentedMode
via
05daa89
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Results generated automatically by MetaMask CI |
Builds ready [7f938b1]
UI Startup Metrics (1231 ± 55 ms)
Benchmark value 24 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 278 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 15 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 1435 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 34 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 227 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 31 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 10 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 36 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 187 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 50 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 7 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 315ms | Sum of p95 exceeds: 371.8ms Sum of all benchmark exceeds: 686.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
AugmentedMode
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds metrics that capture the address label and the address scan response when displayed in the UI. The metrics specifically are associated to when transactions or signatures are either approved, rejected, finalized, or submitted.
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
address_alert_responseandaddress_labelexist. The latter should only exist in anon events.Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist