Skip to content

fix: cp-7.55.0 deep link transfer request cause app to crash #19382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 9, 2025
Merged

fix: cp-7.55.0 deep link transfer request cause app to crash #19382

merged 9 commits into from
Sep 9, 2025
+157 −55

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Sep 8, 2025 •
edited
Loading

Description

Fix for the issue that app crashes when trying to send transfer from deeplink.

Changelog

CHANGELOG entry:

Related issues

Fixes: #19372

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

TODO

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Sep 8, 2025
@github-actions github-actions bot added the size-M label Sep 8, 2025
@jpuri jpuri changed the title fix: app crashing when submitting deeplink for transfer fix: align the use of maxValueMode in code Sep 8, 2025
@jpuri jpuri changed the title fix: align the use of maxValueMode in code fix: cp-7.55.0 depp link transfer request cause app to crash Sep 8, 2025
@jpuri jpuri added the No QA Needed Apply this label when your PR does not need any QA effort. label Sep 8, 2025
@jpuri jpuri marked this pull request as ready for review September 8, 2025 15:16
@jpuri jpuri requested a review from a team as a code owner September 8, 2025 15:16
@jpuri jpuri changed the title fix: cp-7.55.0 depp link transfer request cause app to crash fix: cp-7.55.0 deep link transfer request cause app to crash Sep 8, 2025
cursor[bot]

This comment was marked as outdated.

Sign in to view

@jpuri jpuri requested a review from a team as a code owner September 8, 2025 16:18
@jpuri jpuri added the Run Smoke E2E Requires smoke E2E testing label Sep 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 2983247
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/417696c0-7ce6-4401-8419-967386f52207

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@jpuri jpuri added No E2E Smoke Needed If the PR does not need E2E smoke test run and removed Run Smoke E2E Requires smoke E2E testing labels Sep 8, 2025
Matt561
Matt561 approved these changes Sep 8, 2025
View reviewed changes
Copy link
Contributor

@Matt561 Matt561 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of Earn 👍

app/components/Views/confirmations/hooks/useMaxValueMode.ts
import { selectTransactionState } from '../../../../reducers/transaction';
import { useParams } from '../../../../util/navigation/navUtils';

export function useMaxValueMode() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment above this hook to explain what "max value mode" is and why we use it would be helpful.

@jpuri jpuri enabled auto-merge September 8, 2025 17:41
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
94.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jpuri jpuri added this pull request to the merge queue Sep 9, 2025
Merged via the queue into main with commit 3deb0e3 Sep 9, 2025
99 of 101 checks passed
@jpuri jpuri deleted the max_mode_fix branch September 9, 2025 08:34
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2025
@metamaskbot metamaskbot added release-7.56.0 Issue or pull request that will be included in release 7.56.0 release-7.55.0 Issue or pull request that will be included in release 7.55.0 and removed release-7.56.0 Issue or pull request that will be included in release 7.56.0 labels Sep 9, 2025
@metamaskbot
Copy link
Collaborator

Missing release label release-7.55.0 on PR. Adding release label release-7.55.0 on PR and removing other release labels(release-7.56.0), as PR was cherry-picked in branch 7.55.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@OGPoyraz OGPoyraz OGPoyraz approved these changes

@Matt561 Matt561 Matt561 approved these changes

Assignees
No one assigned
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run No QA Needed Apply this label when your PR does not need any QA effort. release-7.55.0 Issue or pull request that will be included in release 7.55.0 size-M team-confirmations Push issues to confirmations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: ERC20 and ETH Payment deep link app crash - Cannot read property 'maxValueMode' of undefined
4 participants
@jpuri @metamaskbot @OGPoyraz @Matt561