Skip to content

Conversation

dotnet-bot
Copy link
Contributor

This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.

@dotnet-bot dotnet-bot requested a review from a team as a code owner September 2, 2025 23:18
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 8117: Build ID 12313767 Localized file check-in by OneLocBuild Task: Build definition ID 8117: Build ID 12314007 Sep 2, 2025
@@ -993,7 +993,7 @@ nuget sign MyPackage.nupkg -CertificateFingerprint certificate_fingerprint -Outp
</trans-unit>
<trans-unit id="SignCommandNoCertificateException">
<source>No certificate was provided. For a list of accepted ways to provide a certificate, please visit https://docs.nuget.org/docs/reference/command-line-reference</source>
<target state="new">No certificate was provided. For a list of accepted ways to provide a certificate, please visit https://docs.nuget.org/docs/reference/command-line-reference</target>
<target state="translated">No se encontró el archivo de certificado "{0}". Para obtener una lista de las formas aceptadas de proporcionar un certificado, visite https://docs.nuget.org/docs/reference/command-line-reference</target>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't correct...there's no "{0}" in the original source string, and so it'll cause an issue in the build, not to mention the localization itself. Any idea where this happens to be coming from?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was in the original translations...and was causing build issues then...I wonder where it's coming from.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm looking at the right spot, this string has not changed in 8 years and does not have {0}.
Is the loc tooling adding that placeholder somehow?
https://github.com/NuGet/NuGet.Client/blame/546b0dc025190ab9cf744ad4be544c23042688c1/src/NuGet.Clients/NuGet.CommandLine/NuGetCommand.resx#L750C51-L750C51

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing OneLoc documentation, it seems LocVer rules could be assuming intent or using references from similar strings to add the placeholder?
@mmitche do you have suggestions on what we should do to avoid this problem? Lock the strings, or similar?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may be coming from the old localization. It's incorrect here:

https://github.com/NuGet/NuGet.Build.Localization/blob/0856dcd9e3b6f2a90ccdeffc718c691e5660026f/localize/ESN/15/NuGet.exe.lcl#L1542-L1550

I am not sure about how to keep this from happening. Do we have a contact on the loc team?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 8117: Build ID 12314007 Localized file check-in by OneLocBuild Task: Build definition ID 8117: Build ID 12331211 Sep 5, 2025
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 8117: Build ID 12331211 Localized file check-in by OneLocBuild Task: Build definition ID 8117: Build ID 12336452 Sep 5, 2025
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 8117: Build ID 12336452 Localized file check-in by OneLocBuild Task: Build definition ID 8117: Build ID 12336801 Sep 5, 2025
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 8117: Build ID 12336801 Localized file check-in by OneLocBuild Task: Build definition ID 8117: Build ID 12336862 Sep 5, 2025
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 8117: Build ID 12336862 Localized file check-in by OneLocBuild Task: Build definition ID 8117: Build ID 12338157 Sep 5, 2025
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 8117: Build ID 12338157 Localized file check-in by OneLocBuild Task: Build definition ID 8117: Build ID 12346234 Sep 8, 2025
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 8117: Build ID 12346234 Localized file check-in by OneLocBuild Task: Build definition ID 8117: Build ID 12350847 Sep 9, 2025
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 8117: Build ID 12350847 Localized file check-in by OneLocBuild Task: Build definition ID 8117: Build ID 12354842 Sep 9, 2025
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 8117: Build ID 12354842 Localized file check-in by OneLocBuild Task: Build definition ID 8117: Build ID 12356711 Sep 9, 2025
@dotnet-bot dotnet-bot changed the title Localized file check-in by OneLocBuild Task: Build definition ID 8117: Build ID 12356711 Localized file check-in by OneLocBuild Task: Build definition ID 8117: Build ID 12357104 Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants