-
Notifications
You must be signed in to change notification settings - Fork 731
Localized file check-in by OneLocBuild Task: Build definition ID 8117: Build ID 12357104 #6755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
…: Build ID 12313767
…: Build ID 12313767
…: Build ID 12313767
src/NuGet.Clients/NuGet.PackageManagement.UI/xlf/Resources.cs.xlf
Outdated
Show resolved
Hide resolved
@@ -993,7 +993,7 @@ nuget sign MyPackage.nupkg -CertificateFingerprint certificate_fingerprint -Outp | |||
</trans-unit> | |||
<trans-unit id="SignCommandNoCertificateException"> | |||
<source>No certificate was provided. For a list of accepted ways to provide a certificate, please visit https://docs.nuget.org/docs/reference/command-line-reference</source> | |||
<target state="new">No certificate was provided. For a list of accepted ways to provide a certificate, please visit https://docs.nuget.org/docs/reference/command-line-reference</target> | |||
<target state="translated">No se encontró el archivo de certificado "{0}". Para obtener una lista de las formas aceptadas de proporcionar un certificado, visite https://docs.nuget.org/docs/reference/command-line-reference</target> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't correct...there's no "{0}"
in the original source string, and so it'll cause an issue in the build, not to mention the localization itself. Any idea where this happens to be coming from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was in the original translations...and was causing build issues then...I wonder where it's coming from.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm looking at the right spot, this string has not changed in 8 years and does not have {0}
.
Is the loc tooling adding that placeholder somehow?
https://github.com/NuGet/NuGet.Client/blame/546b0dc025190ab9cf744ad4be544c23042688c1/src/NuGet.Clients/NuGet.CommandLine/NuGetCommand.resx#L750C51-L750C51
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing OneLoc documentation, it seems LocVer rules could be assuming intent or using references from similar strings to add the placeholder?
@mmitche do you have suggestions on what we should do to avoid this problem? Lock the strings, or similar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this may be coming from the old localization. It's incorrect here:
I am not sure about how to keep this from happening. Do we have a contact on the loc team?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created a ticket with the loc team https://ceapex.visualstudio.com/CEINTL/_workitems/edit/1077270
…: Build ID 12346234
…: Build ID 12346234
…: Build ID 12350847
…: Build ID 12350847
This is the pull request automatically created by the OneLocBuild task in the build process to check-in localized files generated based upon translation source files (.lcl files) handed-back from the downstream localization pipeline. If there are issues in translations, visit https://aka.ms/icxLocBug and log bugs for fixes. The OneLocBuild wiki is https://aka.ms/onelocbuild and the localization process in general is documented at https://aka.ms/AllAboutLoc.