-
Notifications
You must be signed in to change notification settings - Fork 9.1k
v3.2: Enc style defaults #4899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.2: Enc style defaults #4899
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Helpful clarification, thanks.
v3.1.2 Backport PR #4899 Encoding style default behavior
I've got a schema change for this, but I don't see how it can be tested, since "default" is an annotation-only keyword and its presence or absence cannot cause a validation failure. |
@karenetheridge I would not expect a test is necessary- does the coverage go down in a way that makes things fail when you add the schema change? If not, at least for right now I think that's sufficient. Testing |
…, explode, allowReserved are present see OAI#4899
…, explode, allowReserved are present see OAI#4899
…, explode, allowReserved are present see OAI#4899
…, explode, allowReserved are present see OAI#4899
…, explode, allowReserved are present see OAI#4899
…, explode, allowReserved are present see OAI#4899
While working on cookie-related style changes, I noticed that we are unclear on how
style
defaulting works for the Encoding Object. Specifically, in 3.1.1 we clarified that all ofstyle
,explode
, andallowReserved
apply when any of those three are explicitly present. Otherwise,contentType
applies (even if it is absent- its defaults apply).So the default behavior for
style
takes place if either of the other two fields are there, but not if none of them are there (whethercontentType
is there or not).This requires some rather complex schema changes and tests, which have not been done yet.
On the one hand, this is a clarification and should probably be backported to 3.1.2. On the other hand, it has schema changes, but more in the "we got the schema wrong" sense than in the "we're changing what was expected." I'm not entirely sure what to do with this for 3.1.2.