Builder ssz #14976
Merged
Builder ssz #14976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
commented
Feb 24, 2025
| opt := func(r *http.Request) { | ||
| r.Header.Set(api.VersionHeader, version.String(sb.Version())) | ||
| r.Header.Set("Content-Type", api.OctetStreamMediaType) | ||
| r.Header.Set("Accept", api.OctetStreamMediaType) |
There was a problem hiding this comment.
should the Accept also have json to properly process error message?
nalepae
reviewed
Mar 4, 2025
Co-authored-by: Manu NALEPA <[email protected]>
Co-authored-by: Manu NALEPA <[email protected]>
nalepae
reviewed
Mar 14, 2025
api/client/builder/client.go
Outdated
| if ver >= version.Electra { | ||
| return c.parseHeaderElectra(data) | ||
| case ver >= version.Deneb: | ||
| } else if ver >= version.Deneb { |
There was a problem hiding this comment.
Nit: else not needed.
Could be:
if ver >= version.Electra {
return ...
}
if ver >= version.Deneb {
return ...
}
...
return nil, fmt.Errorf("unsupported header version %s", versionHeader)|
|
||
| var errResponseVersionMismatch = errors.New("builder API response uses a different version than requested in " + api.VersionHeader + " header") | ||
|
|
||
| func getVersionsBlockToPayload(blockVersion int) (int, error) { |
beacon-chain/builder/option.go
Outdated
| if endpoint != "" { | ||
| var opts []builder.ClientOpt | ||
| if sszEnabled { | ||
| log.Info("Using Builder APIs with SSZ enabled.") |
There was a problem hiding this comment.
No period . at the end of single sentence log.
There was a problem hiding this comment.
All logs should have a prefix. Here could be builder.
nalepae
approved these changes
Mar 14, 2025
rkapka
pushed a commit
that referenced
this pull request
Mar 19, 2025
* wip * refactoring functions for easier readability * allow ssz for register validator * changelog * adding in blinded block submission tests * adding in tests for header ssz * fixing linting and tests * adding in custom errors and fixing ssz validator registration * Update api/client/builder/client.go Co-authored-by: Manu NALEPA <[email protected]> * Update api/client/builder/client.go Co-authored-by: Manu NALEPA <[email protected]> * manu's feedback * linting * adding in info log to notify that this setting was turned on * fixing linting * manu's feedback * fixing import --------- Co-authored-by: Manu NALEPA <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
implements ssz mode for using a builder setup, the following endpoints will request and receive responses in ssz format when the
--enable-builder-ssz=trueflag is passed to the beacon node/eth/v1/builder/header/{{.Slot}}/{{.ParentHash}}/{{.Pubkey}}/eth/v1/builder/blinded_blocks/eth/v1/builder/validatorsnote: this pr does not update builder E2E to support ssz, this is another todo item for proper testing
Which issues(s) does this PR fix?
Fixes # ethereum/builder-specs#104, ethereum/builder-specs#110
Other notes for review
Acknowledgements