Update Roslyn to 4.14.0-3.25168.13 #2664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
commented
Mar 19, 2025
| @@ -549,7 +549,7 @@ public class Foo | |||
| Assert.Null(exception); | |||
| } | |||
|
|
|||
| [Fact] | |||
| [Fact(Skip = "Need Roslyn EA for the TestGeneratorReference")] | |||
There was a problem hiding this comment.
The change to include checksum in the caching (dotnet/roslyn#77141) causes the test to throw due to our TestGeneratorReference class. An interface was added for testing purposes and we can use that once Roslyn exposes it to us through our ExternalAccess library.
JoeRobich
commented
Mar 19, 2025
| } | ||
| } | ||
| "; | ||
| string input = $$""" |
There was a problem hiding this comment.
Reformatted this so that my formatter won't remove this necessary whitespace.
JoeRobich
commented
Mar 19, 2025
| <TreatWarningsAsErrors>true</TreatWarningsAsErrors> | ||
| <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration> | ||
| <GenerateAssemblyInfo>true</GenerateAssemblyInfo> | ||
| <SuppressNETCoreSdkPreviewMessage>true</SuppressNETCoreSdkPreviewMessage> | ||
| <SuppressTfmSupportBuildWarnings>true</SuppressTfmSupportBuildWarnings> |
There was a problem hiding this comment.
Added to suppress warnings due to building against net6.0 with net9.0 libraries.
JoeRobich
commented
Mar 19, 2025
| ("Generate type 'Console' -> Generate nested class 'Console'", CodeActionKind.QuickFix), | ||
| ("Extract local function", CodeActionKind.RefactorExtract), | ||
| ("Extract method", CodeActionKind.RefactorExtract), | ||
| ("Use expression body for method", CodeActionKind.Refactor), |
There was a problem hiding this comment.
Expression body refactoring are now being offered for non-empty selections dotnet/roslyn#76969
dibarbet
approved these changes
Mar 19, 2025
333fred
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.