Skip to content

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Sep 6, 2025

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

timvw added a commit to timvw/openapi-generator that referenced this pull request Sep 7, 2025
…Of support

- Merged PR OpenAPITools#21911 from wing328 which adds anyOf test samples
- Regenerated samples with our new anyOf implementation
- Models now correctly generate as structs with optional fields (OR semantics)
- ModelIdentifier and AnotherAnyOfTest demonstrate proper anyOf behavior

Co-Authored-By: William Cheng <[email protected]>
timvw added a commit to timvw/openapi-generator that referenced this pull request Sep 7, 2025
Documented the real-world implications of the anyOf fix by showing:
- How the old generator would produce duplicate enum variants (broken Rust code)
- Why wing328's test case perfectly demonstrates the problem
- The practical difference between treating anyOf as choice vs composition

These findings emerged from merging PR OpenAPITools#21911 and seeing firsthand how
the old behavior would literally generate uncompilable code for certain
anyOf schemas.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant