major ui cleanup - phase 1 #672
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- imported strong ok http client from netcipher due to R.class conflicts with dependencies - Refactored SaveClient to set/unset orbot proxy - added dependency injection for saveclient and tor status repository - update general settings to include tor connection status with some fakery for user experience when orbot is flaky - refactored GDrive implementation to use basic API with SaveClient - added a broadcast reciever for Orbot status, updates the tor repository
removed unused activities and layout files converting activities into fragments and link them in nav_graph space_setup_navigation.xml
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This commit: - Configures the Android build workflow in a new GitHub Actions workflow file (`android-build.yml`). - Adds concurrency to the `detekt.yml` workflow to prevent duplicate runs for the same reference. - Updates the `ProofModeSettingsActivity` to use a dedicated binding layout (`ActivityProofmodeSettingsBinding`) instead of the general settings container. - Creates the new layout file `activity_proofmode_settings.xml` for the Proof Mode settings screen. - Configures release and debug signing configurations in `app/build.gradle.kts`. - Enables minify and shrink resources for the release build type in `app/build.gradle.kts`.
- remove EditFolderActivity from AndroidManifest
Conflicts: app/build.gradle app/src/main/java/net/opendasharchive/openarchive/SaveApp.kt app/src/main/java/net/opendasharchive/openarchive/core/di/CoreModule.kt app/src/main/java/net/opendasharchive/openarchive/features/media/ReviewActivity.kt app/src/main/java/net/opendasharchive/openarchive/features/settings/GeneralSettingsActivity.kt app/src/main/java/net/opendasharchive/openarchive/services/internetarchive/IaConduit.kt app/src/main/java/net/opendasharchive/openarchive/services/webdav/WebDavConduit.kt app/src/main/java/net/opendasharchive/openarchive/upload/UploadService.kt app/src/main/java/net/opendasharchive/openarchive/util/Prefs.kt app/src/main/res/layout/activity_main.xml app/src/main/res/xml/prefs_general.xml build.gradle gradle/wrapper/gradle-wrapper.properties settings.gradle
avoid reciever, use callback
running is slow for debugging
feat: renable orbot and use status
…removal Removed "Tor is disabled" pop-up
# Conflicts: # app/build.gradle.kts # app/src/main/AndroidManifest.xml # app/src/main/java/net/opendasharchive/openarchive/features/settings/SettingsFragment.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed unused activities and layout files
converting activities into fragments and link them in nav_graph space_setup_navigation.xml