Update BitBltArmSimdSourceWord.s to latest ben avison version #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half a dozen small bug fixes from ben Co-Authored-By: bavison <[email protected]>
These may not really need updating; it's not like performance of bitblt is crucial in general when debugging. Against that, one should debug the same code as the production build. The differences in optimisation levels may need some discussion?
|
I see the autobuild failed on the ARM64 squeak.cog.spur debug build because of some issue with BitBltArm64.c line 1536
/* Inner loop */
for (; remain >= 256/destBPP; remain -= 256/destBPP) {
__asm__ volatile (
/* Load source word (if necessary) and shuffle */
"cmp %[unskew], %[src_bits] \n\t"
No idea what "error: impossible constraint in 'asm'" means in this context. Ideas?
On 2021-09-06, at 3:26 PM, tim Rowledge ***@***.***> wrote:
Half a dozen small bug fixes from ben
Co-Authored-By: bavison ***@***.***
You can view, comment on, or merge this pull request online at:
#592
Commit Summary
• Update BitBltArmSimdSourceWord.s to latest ben avison version
File Changes
• M platforms/Cross/plugins/BitBltPlugin/BitBltArmSimdSourceWord.s (19)
Patch Links:
• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/592.patch
• https://github.com/OpenSmalltalk/opensmalltalk-vm/pull/592.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
tim
--
tim Rowledge; ***@***.***; http://www.rowledge.org/tim
Strange OpCodes: CCC: Crash if Carry Clear
|
hogoww
referenced
this pull request
in hogoww/opensmalltalk-vm
Dec 25, 2021
… false ] on method [ markAndShouldScan: ]
hogoww
referenced
this pull request
in hogoww/opensmalltalk-vm
Dec 25, 2021
…false ] on method [ markAndShouldScan: ] KILLED by 1/10 test cases.
hogoww
referenced
this pull request
in hogoww/opensmalltalk-vm
Feb 26, 2022
…oat value ] on method [ allOldSpaceEntitiesForCompactingFrom:to:do: ] 10 test cases.
hogoww
referenced
this pull request
in hogoww/opensmalltalk-vm
Feb 26, 2022
…at value ] on method [ allOldSpaceEntitiesForCompactingFrom:to:do: ] 3/10 Test Cases are NOT EQUIVALENT
|
@timrowledge does this somehow complement #565 ? |
|
Wow, this is from a while ago. I'd have to say that yes, it definitely relates to #565. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Half a dozen small bug fixes from ben
Co-Authored-By: bavison [email protected]