Skip to content

Update documentation for consistency with the build parameters implementation #4286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2025
Merged

Update documentation for consistency with the build parameters implementation #4286

merged 1 commit into from
Feb 4, 2025

Conversation

sangafabrice
Copy link
Contributor

@sangafabrice sangafabrice commented Nov 22, 2024 •
edited by microsoft-github-policy-service bot
Loading

PR Summary

  • Remove misleading parameter values from Build and Test command documentation
  • The valid set of values of the parameter -Framework does not contain netcoreapp2 or netcoreapp2.1
  • Replace invalid values with net6.0

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

@sangafabrice
Update documentation for consistency with the build parameters implem…
8723f69 
…entation

- Remove misleading parameter values from Build and Test command documentation
- The valid set of values of the parameter `-Framework` does not contain `netcoreapp2` or `netcoreapp2.1`
- Replace invalid values with `net6.0`
@daxian-dbw daxian-dbw merged commit 455eebe into PowerShell:master Feb 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sangafabrice @daxian-dbw