Skip to content

Conversation

Hind-M
Copy link
Member

@Hind-M Hind-M commented Aug 28, 2025

No description provided.

@Hind-M Hind-M force-pushed the handle_version branch 2 times, most recently from 5c63460 to cdc5bdb Compare August 28, 2025 14:39
@Hind-M Hind-M changed the title Handle versioning Handle versioning and install Aug 29, 2025
Copy link
Member

@Alex-PLACET Alex-PLACET left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you a test for the installation ?

Comment on lines +248 to +298
PATTERN ".clang-*" EXCLUDE
PATTERN "README.md" EXCLUDE)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well this is mirroring what's on sparrow and seems legit, don't we need it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need it

@Hind-M
Copy link
Member Author

Hind-M commented Sep 1, 2025

Have you a test for the installation ?

Yeah I'm planning to add it once the build is fixed.

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@963b02b). Learn more about missing BASE report.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #14   +/-   ##
=======================================
  Coverage        ?   70.91%           
=======================================
  Files           ?       18           
  Lines           ?      832           
  Branches        ?        0           
=======================================
  Hits            ?      590           
  Misses          ?      242           
  Partials        ?        0           
Flag Coverage Δ
unittests 70.91% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants