-
Notifications
You must be signed in to change notification settings - Fork 3
Handle versioning and install #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
5c63460
to
cdc5bdb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you a test for the installation ?
PATTERN ".clang-*" EXCLUDE | ||
PATTERN "README.md" EXCLUDE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well this is mirroring what's on sparrow and seems legit, don't we need it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need it
Yeah I'm planning to add it once the build is fixed. |
f0a90cb
to
3b6cd40
Compare
993dee8
to
df3b076
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
=======================================
Coverage ? 70.91%
=======================================
Files ? 18
Lines ? 832
Branches ? 0
=======================================
Hits ? 590
Misses ? 242
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
11a2df3
to
fbcb7ad
Compare
No description provided.