Weight Preshuffle Block Scale gemm support #2785
Open
+1,240
−259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amd-khushbu
requested review from
illsilin,
carlushuang,
qianfengz,
aosewski,
poyenc,
geyyer,
bartekxk,
andriy-ca,
afagaj,
asleepzzz,
tenpercent,
ThomasNing,
coderfeli,
shumway and
vidyasagar-amd
as code owners
ThomasNing
requested changes
Sep 7, 2025
| { | ||
| using BlockWarps = typename Problem::BlockGemmShape::BlockWarps; | ||
| using WarpTile = typename Problem::BlockGemmShape::WarpTile; | ||
| // static_assert(std::is_same_v<typename Problem::ComputeDataType, ck_tile::pk_int4_t>, |
| }; | ||
|
|
||
| template <typename Problem, typename PipelinePolicy = GemmWPQuantPipelineAgBgCrPolicy> | ||
| struct WPQuantBPipelineAgBgCrV1 : public BaseWPQuantBPipelineAgBgCrV1<Problem> |
There was a problem hiding this comment.
We are now upgrading to V2 let's use the V2 pipeline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added support for Preshuffle B(weight) tensor with block scale gemm.
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered