Skip to content

Returning the use of the proper stream in allreduce #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Returning the use of the proper stream in allreduce #382

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1395ff4
Returning the use of the proper stream in allreduce
gshtras Jan 23, 2025
fdc3642
Merge branch 'main' into bring_stream_back
gshtras Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions vllm/distributed/parallel_state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@
import vllm.envs as envs
from vllm.distributed.utils import StatelessProcessGroup
from vllm.logger import init_logger
from vllm.utils import direct_register_custom_op, supports_custom_op
from vllm.utils import (current_stream, direct_register_custom_op,
supports_custom_op)

if TYPE_CHECKING:
from vllm.config import VllmConfig
Expand Down Expand Up @@ -365,7 +366,7 @@ def _all_reduce_out_place(self, input_: torch.Tensor) -> torch.Tensor:
return out
pynccl_comm = self.pynccl_comm
assert pynccl_comm is not None
out = pynccl_comm.all_reduce(input_)
out = pynccl_comm.all_reduce(input_, stream=current_stream())
if out is None:
# fall back to the default all-reduce using PyTorch.
# this usually happens during testing.
Expand Down
Loading