Skip to content

Conversation

Sliverguo
Copy link
Contributor

@Sliverguo Sliverguo commented Sep 18, 2021

拉取/合并请求描述:(PR description)

[
1.修改wifi scan功能,不限制扫描ap个数。
2.删除wlan种work queue功能,wifi scan不需要缓存ap信息之后,基本不需要此功能。
3.支持wifi join的时候scan动作可配置。
4.支持快速连接。
]

以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 本拉取/合并请求代码是高质量的 Code in this PR is of high quality
  • 本拉取/合并使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ geniusgogo
❌ zetingxu


zetingxu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@chenyingchun0312
Copy link
Contributor

一般会使用这个脚本格式化一下,就不会包格式错误了: https://github.com/mysterywolf/formatting

@enkiller
Copy link
Contributor

enkiller commented Feb 9, 2022

  1. 不限制扫描ap个数
  2. wifi scan不需要缓存ap信息
  3. wifi join的时候scan动作可配置

上面三个功能,可以通过新增 API 的方式实现吗?原有的功能仍保留

@geniusgogo geniusgogo force-pushed the modify_wlan_framework branch from 5a5305b to b101e5d Compare May 13, 2022 06:42
@Sliverguo
Copy link
Contributor Author

Sliverguo commented May 13, 2022

Good job!

@Guozhanxin Guozhanxin added the +1 Agree +1 label May 23, 2022
@Guozhanxin Guozhanxin merged commit 1e27372 into RT-Thread:master May 25, 2022
levizh added a commit to levizh/rt-thread that referenced this pull request May 27, 2022
* 'master' of github.com:levizh/rt-thread: (69 commits)
  Modify wlan framework (RT-Thread#5076)
  [libc] revert back difftime
  [ulog] Optimize unnecessary refresh
  [bsp] rename qemu-riscv-virt64 to qemu-virt64-riscv
  [include] fix comment for rt_container_of
  [adc][pwm] correct the command description
  [stm32][dac] add comment
  [arduino] suuport MsTimer2 library
  [arduino][readme] 增加对5v容忍的描述
  [arduino] add F_CPU to indicate the frequency of CPU
  [arduino] add RTDUINO_NO_SETUP_LOOP
  [bsp/renesas/docs/] Add English documents (RT-Thread#5985)
  [MTD-NAND] Add private data pointer. (RT-Thread#5974)
  [bug] use pointer that memory had freed. (RT-Thread#5971)
  [tools/kconfig-frontends] append path for scons env (RT-Thread#5972)
  [文档] 修正贡献代码指南对于日志使用的描述 (RT-Thread#5975)
  [lvgl] remove LV_DISP_DEF_REFR_PERIOD which are defined manually (RT-Thread#5976)
  remove CMSIS/RTOS folders
  update
  update stm32 ci checking list
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
+1 Agree +1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants