Skip to content

Conversation

dongly
Copy link
Contributor

@dongly dongly commented Oct 22, 2021

拉取/合并请求描述:(PR description)

[

  • 现用 CubeMX 生成代码后,需要复制 SystemClock_Config 函数到 board.c,有点麻烦.

  • 此PR 修改CubeMX 的配置,不生成main(),就可以直接用调用 CubeMX 生成的main.c 了.


stm32的板太多了,先改这个
]

以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 本拉取/合并请求代码是高质量的 Code in this PR is of high quality
  • 本拉取/合并使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@mysterywolf
Copy link
Member

好思路,现在STM32的main.c名存实亡

@liukangcc liukangcc added the BSP: STM32 BSP related with ST/STM32 label Oct 22, 2021
@Guozhanxin
Copy link
Member

有测试过几种编译器啊,有些编译器对这种同名文件好像不太友好。

@dongly
Copy link
Contributor Author

dongly commented Oct 26, 2021

  • gcc 测试通过
  • keil armcc 编译错误,(不是同名问题)
  • keil armclang 测试通过
  • iar 未测试(手头没有iar)

现在有些忙,迟些再处理

@mysterywolf mysterywolf added the in progress PR/issue in progress. label Nov 17, 2021
@dongly
Copy link
Contributor Author

dongly commented Jan 29, 2022

先关闭

@mysterywolf
Copy link
Member

这个修改时有问题的 重名main.c在部分编译器里会直接报错。

@dongly dongly deleted the f407_rm_board_c branch March 31, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSP: STM32 BSP related with ST/STM32 in progress PR/issue in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants