Fix some compilation warning #5744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guozhanxin
reviewed
Mar 30, 2022
Guozhanxin
reviewed
Mar 30, 2022
| @@ -279,10 +279,10 @@ static void stm32_pin_mode(rt_device_t dev, rt_base_t pin, rt_base_t mode) | |||
|
|
|||
| rt_inline rt_int32_t bit2bitno(rt_uint32_t bit) | |||
| { | |||
| rt_uint8_t i; | |||
| rt_int32_t i; | |||
|
格式化规范的问题已经解决,我自己定义的clang-format,不小心用在这了 |
dongly
force-pushed
the
fix_warning
branch
3 times, most recently
from
08f46a7 to
ddb5eb3
Compare
|
https://github.com/mysterywolf/formatting 用这个格式化 这个是专门设计给rtt格式化用的 |
mysterywolf
requested changes
Mar 30, 2022
|
已修改,尽量只改符号,或尽量小的类型 |
BernardXiong
reviewed
Apr 4, 2022
|
已更新 |
dongly
force-pushed
the
fix_warning
branch
3 times, most recently
from
e5302bb to
2976c2e
Compare
|
麻烦再 解决一下冲突 我们再review一下 |
dongly
force-pushed
the
fix_warning
branch
3 times, most recently
from
0659759 to
14c3075
Compare
|
已更新 |
mysterywolf
added
v4.1.1
and removed
discussion
|
冲突已经再次解决,请review @mysterywolf |
|
请ping我的邮箱 [email protected] 我拉你进群 |
|
这份PR开会时再讨论一下细节，期望在4.1.1发布之前合进去 @Guozhanxin |
|
@dongly 请再耐心等待一下，冲突的问题目前先不需要解决。 |
mysterywolf
approved these changes
Aug 2, 2022
|
@dongly 如果有新的修改请不要强制推送，我帮你改了一部分，如果一旦强制推送，我修改的部分就没了 |
Guozhanxin
reviewed
Aug 2, 2022
| rt_err_t result; | ||
|
|
||
| for (int i = 0; i < obj_num; i++) | ||
| for (rt_size_t i = 0; i < sizeof(i2c_obj) / sizeof(struct stm32_i2c); i++) |
Guozhanxin
reviewed
Aug 2, 2022
| { | ||
| 0x74, 0x68, 0x69, 0x73, 0x20, 0x69, 0x73, 0x20, 0x61, 0x20, 0x66, 0x69, 0x6c, 0x65, 0x21, 0x0d, 0x0a, | ||
| }; | ||
|
|
||
| const static struct romfs_dirent _dummy[] = | ||
| static const struct romfs_dirent _dummy[] = |
There was a problem hiding this comment.
这部分代码是脚本自动生成的，如果要修改，后面最好把tool目录下的脚本也修改了。要不然下次生成又被还原了。
There was a problem hiding this comment.
这块应该是要改一下脚本吧 脚本生成的有问题 确实应该是static关键字在前 const在后
mysterywolf
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[
修复 gcc 带参数 " -W" 编译出现的一些警告
]
以下的内容不应该在提交PR时的message修改，修改下述message，PR会被直接关闭。请在提交PR后，浏览器查看PR并对以下检查项逐项check，没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up