-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[device][adc] implement adc_get_vref #5988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Guozhanxin
merged 10 commits into
RT-Thread:master
from
byte-me-stan:feat/stm32_adc_get_vref
May 29, 2022
Merged
[device][adc] implement adc_get_vref #5988
Guozhanxin
merged 10 commits into
RT-Thread:master
from
byte-me-stan:feat/stm32_adc_get_vref
May 29, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add stm32_adc_get_vref
fixed formatting issue
mysterywolf
requested changes
May 25, 2022
mysterywolf
requested changes
May 25, 2022
mysterywolf
reviewed
May 25, 2022
mysterywolf
reviewed
May 25, 2022
mysterywolf
requested changes
May 28, 2022
check error code
mysterywolf
requested changes
May 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please carefully crossing check with the file that I sent to you.
mysterywolf
requested changes
May 28, 2022
mysterywolf
requested changes
May 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please help me to add and delete these two lines
Co-authored-by: Man, Jianting (Meco) <[email protected]>
mysterywolf
requested changes
May 28, 2022
mysterywolf
requested changes
May 28, 2022
more clean up
mysterywolf
approved these changes
May 28, 2022
请Squash合并 |
Guozhanxin
approved these changes
May 29, 2022
levizh
added a commit
to levizh/rt-thread
that referenced
this pull request
May 31, 2022
…hc32_pr * 'master' of https://github.com/RT-Thread/rt-thread: Hc32 pr (RT-Thread#6003) [add] winsock implement on windows simulator. (RT-Thread#6010) [spi device] remove _spi_bus_device_control (RT-Thread#5898) [net][lwip] Support windows simulator (RT-Thread#5993) [componnets][pin]add pin operate command in MSH (RT-Thread#5892) [device][adc] implement adc_get_vref (RT-Thread#5988) [drivers][hwcrypto] Correct function return value definition (RT-Thread#5984) [STM32][RTC] add support for STM32L0 series. (RT-Thread#5994) Fix bug when restarting and getting interrupts that are not processed. (RT-Thread#5997) [kernel][timer] fixed bug (RT-Thread#6004)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add stm32_adc_get_vref
拉取/合并请求描述:(PR description)
[
这段方括号里的内容是您必须填写并替换掉的,否则PR不可能被合并。方括号外面的内容不需要修改,但请仔细阅读。
The content in this square bracket must be filled in and replaced, otherwise, PR can not be merged. The contents outside square brackets need not be changed, but please read them carefully.
请在这里填写您的PR描述,可以包括以下之一的内容:为什么提交这份PR;解决的问题是什么,你的解决方案是什么;
Please fill in your PR description here, which can include one of the following items: why to submit this PR; what is the problem solved and what is your solution;
并确认并列出已经在什么情况或板卡上进行了测试。
And confirm in which case or board has been tested.
]
以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up