feat(bsp/gd32f1-f4/drv_sdio):增加gd32下sdio驱动 #6176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guozhanxin
reviewed
Jul 22, 2022
| @@ -44,6 +44,7 @@ if GetDepend(['RT_USING_WDT']): | |||
|
|
|||
| if GetDepend(['RT_USING_SDIO']): | |||
| src += ['GD32F20x_standard_peripheral/Source/gd32f20x_sdio.c'] | |||
| src += ['GD32F20x_standard_peripheral/Source/gd32f20x_dma.c'] | |||
There was a problem hiding this comment.
dma这个文件是不是单独搞个宏来控制比较好，以后其他的驱动可能也会依赖这个文件吧。如果后面有LCD驱动也需要dma就容易重复添加了。
There was a problem hiding this comment.
郭老师这个应该是scons的责任 如果驱动里使用到了dma和sdio，直接把这两个加进来没啥问题。scons里在汇总的时候去除重复文件即可，毕竟Python处理这个比强制用户处理方便多了
Guozhanxin
added
change req
mysterywolf
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述：(PR description)
[
1、增加sdio驱动，使用块设备的方式进行注册
2、使用成都资芯科技有限公司的GD32F450ZKT6开发板进行了验证（rt-thread studio 开发环境）
]
以下的内容不应该在提交PR时的message修改，修改下述message，PR会被直接关闭。请在提交PR后，浏览器查看PR并对以下检查项逐项check，没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up