portable static asserts #712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR replaces direct uses of C’s _Static_assert in the ART code with a portable CROARING_STATIC_ASSERT macro and defines that macro to map to static_assert in C++ or _Static_assert in C.
- Added
CROARING_STATIC_ASSERTmacro inportability.hto unify C/C++ assertions. - Updated four alignment checks and one size check in
art.cto use the new macro.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/art/art.c | Replaced _Static_assert calls with CROARING_STATIC_ASSERT |
| include/roaring/portability.h | Defined CROARING_STATIC_ASSERT macro for C/C++ |
Comment on lines
+592
to
+593
| #else | ||
| #define CROARING_STATIC_ASSERT(x, y) _Static_assert(x, y) |
There was a problem hiding this comment.
Guard the C branch of this macro with a check for C11 support (e.g., __STDC_VERSION__ >= 201112L) so that older C compilers without _Static_assert don’t break the build.
Suggested change
| #else | |
| #define CROARING_STATIC_ASSERT(x, y) _Static_assert(x, y) | |
| #elif defined(__STDC_VERSION__) && (__STDC_VERSION__ >= 201112L) | |
| #define CROARING_STATIC_ASSERT(x, y) _Static_assert(x, y) | |
| #else | |
| #define CROARING_STATIC_ASSERT(x, y) /* static assert not supported */ |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, run
tools/clang-format.shon your changes. See the "Contributing" section in the README for details.Fixes #711