remove an unneded allocation in roaring_bitmap_portable_serialize #735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually, in roaring_bitmap_portable_serialize. There's no need to allocate an array for the run container bitset, then copying into the destination buffer. Instead, write directly into the destination buffer.
There was a problem hiding this comment.
Pull Request Overview
Optimizes memory allocation in the ra_portable_serialize function by eliminating an unnecessary intermediate array allocation for the run container bitset, instead writing directly to the destination buffer.
- Replaces heap allocation with direct buffer manipulation
- Eliminates memory copy operation between intermediate array and destination buffer
- Removes associated memory deallocation call
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Wow. |
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually, in ra_portable_serialize.
There's no need to allocate an array for the run container bitset, then copying into the destination buffer. Instead, write directly into the destination buffer.