Skip to content

Conversation

droshev
Copy link
Contributor

@droshev droshev commented Jun 27, 2020

Related Issue

fixes: #1114

Renamed class fd-bar--cosy to fd-bar--cozy
Affected components:

  • bar.md
  • calendar.md
  • dialog.md
  • menu.md
  • message-box.md
  • popover.md
  • switch.md
  • combobox-input.md
  • date-picker.md
  • multi-input.md
  • time-picker.md

@droshev droshev added this to the Sprint 40 - Honolulu milestone Jun 27, 2020
@droshev droshev requested a review from jbadan June 27, 2020 21:39
@droshev droshev self-assigned this Jun 27, 2020
@netlify
Copy link

netlify bot commented Jun 27, 2020

Deploy preview for fundamental-styles ready!

Built with commit 78c51ee

https://deploy-preview-1186--fundamental-styles.netlify.app

@droshev droshev requested a review from a team June 27, 2020 22:20
@droshev droshev added the Bug Something isn't working label Jun 27, 2020
- \`.fd-message-box__content--xl\`: 3rem - min-width: 1440px
On mobile devices the component should be in \`cosy\` mode. Add the \`fd-bar--cosy\` modifier class to the header and the footer. The buttons in the footer should also be in Cosy mode. The deafult mode for Buttons is \`cosy\` so no modifier classes are required.
On mobile devices the component should be in \`cosy\` mode. Add the \`fd-bar--cozy\` modifier class to the header and the footer. The buttons in the footer should also be in Cosy mode. The deafult mode for Buttons is \`cosy\` so no modifier classes are required.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be in `cozy` mode

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

docs: {
iframeHeight: 100,
storyDescription: 'For Tablet and Mobile (Cosy mode) apply the <code>fd-bar--cosy</code> class to the container element.'
storyDescription: 'For Tablet and Mobile (Cosy mode) apply the <code>fd-bar--cozy</code> class to the container element.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Cozy mode)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

</ul>
<br><br>
On mobile devices the component should be in `cosy` mode. Add the `fd-bar--cosy` modifier class to the header and the footer. The buttons in the footer should also be in Cosy mode. The deafult mode for Buttons is `cosy` so no modifier classes are required.
On mobile devices the component should be in `cosy` mode. Add the `fd-bar--cozy` modifier class to the header and the footer. The buttons in the footer should also be in Cosy mode. The deafult mode for Buttons is `cosy` so no modifier classes are required.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace all cosy with cozy, not just class name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@droshev droshev requested review from a team and stefanoScalzo June 29, 2020 16:25
@droshev droshev force-pushed the feat/rename-cosy-to-cozy branch from f93538b to 78c51ee Compare June 29, 2020 18:15
Copy link
Contributor

@stefanoScalzo stefanoScalzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@droshev droshev merged commit 286c54d into master Jun 29, 2020
@droshev droshev deleted the feat/rename-cosy-to-cozy branch June 29, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Naming: Cozy vs. Cosy
2 participants