-
Notifications
You must be signed in to change notification settings - Fork 59
docs: update buttons in compact bars #2064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploy preview for fundamental-styles ready! Built with commit 6b8f63e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is NOT a Breaking change, it's just an example of what can go inside a Bar component. The implementation libraries do not depend on this additional class. Also, the buttons were left cosy intentionally as the user is not prevented from mixing cozy/compact mode inside Bar component. For me personally this PR (the issue) does not bring value but if we decide to merge it, it should not be a Breaking change PR.
I agree with you. On the other hand we should show the best practices and the right approach. |
@InnaAtanasova I have updated one of the examples explaining that the we can mix compact bar with cozy elements. Thank you for pointing out. |
Related Issue
fixes: #2030
Description
use compact buttons in compact bars
Screenshots
Before:
After:
Please check whether the PR fulfills the following requirements
normalize
optionunnormalize
option