Skip to content

Conversation

droshev
Copy link
Contributor

@droshev droshev commented Jan 16, 2021

Related Issue

fixes: #2030

Description

use compact buttons in compact bars

Screenshots

Before:

Screen Shot 2021-01-17 at 6 56 16 PM

After:

Screen Shot 2021-01-17 at 6 57 13 PM

Please check whether the PR fulfills the following requirements

  1. The output matches the design specs
  • Includes Compact/Cosy/Tablet design
  1. Testing
  • tested Storybook examples with "CSS Resources" normalize option
  • tested Storybook examples with "CSS Resources" unnormalize option
  • Updated tests
  1. Documentation
  • Storybook documentation has been created/updated

@droshev droshev self-assigned this Jan 16, 2021
@droshev droshev requested a review from a team January 16, 2021 16:46
@droshev droshev added this to the Sprint 54 - Los Angeles milestone Jan 16, 2021
@netlify
Copy link

netlify bot commented Jan 16, 2021

Deploy preview for fundamental-styles ready!

Built with commit 6b8f63e

https://deploy-preview-2064--fundamental-styles.netlify.app

Copy link
Contributor

@InnaAtanasova InnaAtanasova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is NOT a Breaking change, it's just an example of what can go inside a Bar component. The implementation libraries do not depend on this additional class. Also, the buttons were left cosy intentionally as the user is not prevented from mixing cozy/compact mode inside Bar component. For me personally this PR (the issue) does not bring value but if we decide to merge it, it should not be a Breaking change PR.

@droshev
Copy link
Contributor Author

droshev commented Jan 18, 2021

This is NOT a Breaking change, it's just an example of what can go inside a Bar component. The implementation libraries do not depend on this additional class. Also, the buttons were left cosy intentionally as the user is not prevented from mixing cozy/compact mode inside Bar component. For me personally this PR (the issue) does not bring value but if we decide to merge it, it should not be a Breaking change PR.

I agree with you. On the other hand we should show the best practices and the right approach.

@droshev droshev requested a review from InnaAtanasova January 18, 2021 21:13
@droshev
Copy link
Contributor Author

droshev commented Jan 21, 2021

This is NOT a Breaking change, it's just an example of what can go inside a Bar component. The implementation libraries do not depend on this additional class. Also, the buttons were left cosy intentionally as the user is not prevented from mixing cozy/compact mode inside Bar component. For me personally this PR (the issue) does not bring value but if we decide to merge it, it should not be a Breaking change PR.

@InnaAtanasova I have updated one of the examples explaining that the we can mix compact bar with cozy elements. Thank you for pointing out.

@droshev droshev merged commit 9721b82 into main Jan 21, 2021
@droshev droshev deleted the docs/update-bar-examples branch January 21, 2021 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation - all compact bar examples should have all compact buttons
3 participants