feat: Add no-data, remove borders from responsive mode #2192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKMarkowski
changed the title
|
Deploy preview for fundamental-styles ready! Built with commit e4a7075 |
JKMarkowski
force-pushed
the
feat/table-enhancements
branch
from
7f4b0a9 to
27d97d3
Compare
itmilos
approved these changes
Mar 10, 2021
InnaAtanasova
requested changes
Mar 10, 2021
this might be an option when max-width of the cell is provided |
JKMarkowski
force-pushed
the
feat/table-enhancements
branch
from
58ca285 to
48a428e
Compare
JKMarkowski
force-pushed
the
feat/table-enhancements
branch
from
6028743 to
d085462
Compare
JKMarkowski
force-pushed
the
feat/table-enhancements
branch
from
7c6bfa0 to
cbf53f7
Compare
|
@InnaAtanasova changes that we agreed on are applied, could you check it again? :) |
InnaAtanasova
approved these changes
Mar 12, 2021
Comment on lines
+128
to
+130
| word-break: break-word; | ||
| overflow: hidden; | ||
| text-overflow: ellipsis; |
There was a problem hiding this comment.
you could use the mixin here
There was a problem hiding this comment.
@itmilos why did you resolve this comment?
There was a problem hiding this comment.
One of the Definitions of Done is Mixins are used for repeatable code (fd-rtl, fd-ellipsis, fd-flex, fd-selected, fd-focus, ect.) and there's a mixin fd-ellipsis that has these 3 rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
part of SAP/fundamental-ngx#4622
part of https://github.tools.sap/dxp/jukebox/issues/420
Description
There are
Please check whether the PR fulfills the following requirements
remfd-*class is used in the filefd-rtl,fd-ellipsis,fd-flex,fd-selected,fd-focus, ect.)fd-reset()mixin is applied to all elementsnormalizeoptionunnormalizeoption[ci visual]so it can trigger chromatic visual regression (e.g.test: run chromatic visual regression [ci visual])