Skip to content

Conversation

InnaAtanasova
Copy link
Contributor

Related Issue

Part of #3166

Description

  • added a new modifier class .fn-message-strip--dismissible for when the message strip is dismissible (has a close button)
  • use Nested instead of Layout for the close button of the Message strip
    Before:
<div class="fn-message-strip">
  <span class="fn-message-strip__text">Information (default) Message Strip Text</span>
  <button class="fn-button fn-button--layout fn-button--icon-only fn-message-strip__close-button" aria-label="Close">
    <span class="sap-icon sap-icon--decline"></span>
  </button>
</div>

After:

<div class="fn-message-strip fn-message-strip--dismissible">
    <span class="fn-message-strip__text">Information (default) Message Strip Text</span>
    <button class="fn-nested-button fn-message-strip__close-button" aria-label="close">
        <span class="sap-icon sap-icon--decline"></span>
    </button>
</div>

Screenshots

Before:

Screen Shot 2022-02-15 at 2 41 45 PM

Screen Shot 2022-02-15 at 2 41 40 PM

After:

Screen Shot 2022-02-15 at 2 41 20 PM

Screen Shot 2022-02-15 at 2 41 27 PM

@InnaAtanasova InnaAtanasova added this to the Sprint 81 - Santiago milestone Feb 15, 2022
@InnaAtanasova InnaAtanasova requested a review from a team February 15, 2022 19:43
@InnaAtanasova InnaAtanasova self-assigned this Feb 15, 2022
@netlify
Copy link

netlify bot commented Feb 15, 2022

✔️ Deploy Preview for fundamental-styles ready!

🔨 Explore the source changes: 0401998

🔍 Inspect the deploy log: https://app.netlify.com/sites/fundamental-styles/deploys/620c026c6c059900079bea29

😎 Browse the preview: https://deploy-preview-3192--fundamental-styles.netlify.app

@InnaAtanasova InnaAtanasova merged commit 4e21253 into main Feb 15, 2022
@InnaAtanasova InnaAtanasova deleted the fix/fn-message-strip-update branch February 15, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants