Skip to content

Conversation

mikerodonnell89
Copy link
Member

@mikerodonnell89 mikerodonnell89 commented Mar 31, 2022

part of #3213

BREAKING CHANGE

  • year & month items should have fd-button fd-button--transparent classes from now.

@netlify
Copy link

netlify bot commented Mar 31, 2022

Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit 0b70fbe
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/624f14900dba7b000884d88a
😎 Deploy Preview https://deploy-preview-3273--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@InnaAtanasova InnaAtanasova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The border/box-shadow is not rounded (Horizon):

Screen Shot 2022-04-01 at 3 43 48 PM

  1. The years and months are blue in the design specs and the current month and year are blue and bold:

Screen Shot 2022-04-01 at 3 50 00 PM

Screen Shot 2022-04-01 at 3 50 47 PM

Fundamental-styles:
Screen Shot 2022-04-01 at 3 50 24 PM
Screen Shot 2022-04-01 at 3 50 52 PM

@mikerodonnell89
Copy link
Member Author

mikerodonnell89 commented Apr 1, 2022

@InnaAtanasova re: corners without border-radius, that is coming from the dialog

re: the blue buttons, I am waiting on the button PR before that

@github-actions
Copy link

github-actions bot commented Apr 4, 2022

This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days

BREAKING CHANGE:
* You should apply fd-button fd-button--transparent classes to the months & years items
@platon-rov
Copy link
Contributor

@InnaAtanasova yours feedback processed now.

However, the year & month items still will have black color in horizon themes and it's because of the bug we have on main. It's already fixed in button's pr and will be applied automatically here also, so you can just skip this one.

@platon-rov platon-rov requested a review from InnaAtanasova April 6, 2022 12:58
@InnaAtanasova InnaAtanasova self-requested a review April 6, 2022 15:45
Copy link
Contributor

@InnaAtanasova InnaAtanasova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The week days and number of the week should not have background
Screen Shot 2022-04-06 at 11 46 56 AM
Screen Shot 2022-04-06 at 11 47 36 AM

@platon-rov platon-rov requested a review from InnaAtanasova April 8, 2022 14:56
@github-actions
Copy link

This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days

@droshev droshev added this to the Sprint 85 - Quito milestone Apr 13, 2022
@droshev droshev merged commit 4b548e1 into main Apr 13, 2022
@droshev droshev deleted the feat/calendar-horizon branch April 13, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants