-
Notifications
You must be signed in to change notification settings - Fork 59
feat(styles): icon tabs header horizon delta theming #3301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for fundamental-styles ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
fb79c84
to
db44dd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Padding of the header is set with sizing. By default fd-icon-tab-bar does not have any padding
I see, but accordingly to the specifications size S should be applied for small screens, M for medium and so on, and we don't apply it implicitly. It's weirdo to don't have paddings at all and i don't see anything about this variant without paddings in the wiki, maybe we should contact designers, what do you think?
For some reason Label color and font is correctly set, but visually it does not appear. Although in theming variables they exist
Inactive tab should have color: --sapTextColor
, but it has color: var(--sapContent_LabelColor)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accidentally approved.
This pull request is stale because it has been open 2 days with no activity. Remove stale label or comment or this will be closed in 3 days |
…hould have been process type tab header
f349f23
to
96d5af0
Compare
466718d
to
108bd7f
Compare
Related Issue
part of #3213
Description
Icon tabs bar update
Breaking Changes
position: absolute
, now positions usingmargin-left: auto
. It now is always in the end of container