Skip to content

feat: menu hover #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 7, 2019
Merged

feat: menu hover #364

merged 8 commits into from
Oct 7, 2019

Conversation

stefanoScalzo
Copy link
Contributor

Related Issue

Closes #363

Description

Added the span icon element within the anchor tag
Screen Shot 2019-10-04 at 11 52 34 AM

Screenshots

Before:

After:

Screen Shot 2019-10-04 at 11 53 35 AM

@netlify
Copy link

netlify bot commented Oct 4, 2019 •
edited
Loading

Deploy preview for fundamental-styles ready!

Built with commit 17c9d80

https://deploy-preview-364--fundamental-styles.netlify.com

jbadan
jbadan suggested changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@jbadan jbadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a heads up - this is a breaking change for the implementation libraries and needs to be communicated via opening an issue on the repos to match this html.

Please delete the scss/* files added here and audit that you've only updated the correct tests that correspond to this change - nothing but menu should be touched most likely. Please include screenshots from the results of npm run test. Thanks!

@stefanoScalzo stefanoScalzo requested a review from jbadan October 4, 2019 17:50
@droshev
Copy link
Contributor

droshev commented Oct 4, 2019

@jbadan we discussed this with @stefanoScalzo as this is a breaking change.
@stefanoScalzo can you update the description of the PR stating that this is breaking change?
Also we should open issue in each library referencing this PR as a source.

@droshev droshev added the Bug Something isn't working label Oct 4, 2019
@droshev droshev added this to the sprint 21 - Khal Drogo milestone Oct 4, 2019
@jbadan jbadan mentioned this pull request Oct 4, 2019
Closed
jbadan
jbadan approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@jbadan jbadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@stefanoScalzo stefanoScalzo merged commit c44bc9f into master Oct 7, 2019
@droshev droshev deleted the feat/menu-hover branch October 13, 2019 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droshev droshev Awaiting requested review from droshev

@JKMarkowski JKMarkowski Awaiting requested review from JKMarkowski

@InnaAtanasova InnaAtanasova Awaiting requested review from InnaAtanasova

1 more reviewer

@jbadan jbadan jbadan approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
sprint 21 - Khal Drogo
Development

Successfully merging this pull request may close these issues.

Fix menu to have icon within anchor
3 participants
@stefanoScalzo @droshev @jbadan