Skip to content

Conversation

InnaAtanasova
Copy link
Contributor

Related Issue

Closes none

Description

  • Spacing between Title and Byline is now 0,5rem, not 0.75rem
  • Icon size is now 2rem, not 2.5rem
  • Byline height for compact and cozy is 80px (5rem)
  • Wrapping behaviour issues:
    • The Avatar is top aligned
    • The left and right sections are not in 2 columns
  • unread notifications have bold title

Before:
Screenshot 2023-07-12 at 4 38 14 PM
Screenshot 2023-07-12 at 4 38 04 PM

After:

Screenshot 2023-07-12 at 4 38 29 PM
Screenshot 2023-07-12 at 4 38 22 PM

BREAKING CHANGE:

  • Unread fd-list__item requires fd-list__item--unread modifier class to make the title bold
  • <div class="fd-list__byline fd-list__byline--2-col"> is now <div class="fd-list__byline fd-list__byline--wrap">

@InnaAtanasova InnaAtanasova added this to the Sprint 117 milestone Jul 12, 2023
@InnaAtanasova InnaAtanasova requested a review from a team July 12, 2023 20:46
@InnaAtanasova InnaAtanasova self-assigned this Jul 12, 2023
@netlify
Copy link

netlify bot commented Jul 12, 2023

Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit 3db663a
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/64b1d7dadaafce000886b417
😎 Deploy Preview https://deploy-preview-4687--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@InnaAtanasova InnaAtanasova force-pushed the fix/list-design-review-fixes branch from 13dd277 to f547072 Compare July 14, 2023 16:28
@droshev droshev force-pushed the fix/list-design-review-fixes branch from f547072 to 3db663a Compare July 14, 2023 23:18
@droshev droshev merged commit d4e236b into main Jul 14, 2023
@droshev droshev deleted the fix/list-design-review-fixes branch July 14, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants