Skip to content

Allow None override for version_base and ancestor_id in create_package_version #3670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Allow None override for version_base and ancestor_id in create_package_version #3670

wants to merge 3 commits into from

Conversation

zenibako
Copy link

@zenibako zenibako commented Oct 6, 2023 •
edited
Loading

If you attempt to override the preset version_base and ancestor_id options for the create_package_version task (for example, to bypass GitHub resolution in the release_2gp_beta flow), you will be blocked by errors (_get_base_version_number() will attempt to parse the value as a version number, and _resolve_ancestor_id() doesn't recognize the value).

This PR adds a new utils.process_none_arg function, and updates create_package_version to use this new function for version_base and ancestor_id.

@zenibako zenibako requested a review from a team as a code owner October 6, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla:signed oss-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zenibako @jstvz