fix: add support for enums with single enumeration #681
Conversation
| @@ -50,7 +50,7 @@ public function parse(object $object): self | |||
| $struct->deps = $deps; | |||
| $struct->parse($item->content, $deps); | |||
|
|
|||
| if (isset($item->content->content[0]->meta->id)) { | |||
| if (isset($item->content->content) && is_array($item->content->content) && isset($item->content->content[0]->meta->id)) { | |||
There was a problem hiding this comment.
Is this related to the rest of the changes?
There was a problem hiding this comment.
Yes, because the $item->content->content is not an array when there is only one enumeration.
There was a problem hiding this comment.
No, in my case it is the value of the enum. In the test you can see an example and there it is a string, see https://github.com/SMillerDev/phpdraft/pull/681/files#diff-b33b2099416ec2a729244bddbbf8f2f3125952aa5d11a6bdfb87f28eef655cbaR335-R337
There was a problem hiding this comment.
i think this could be a separate PR, because this change on it's own solve the issues we have right now. i also miss a test for this change
There was a problem hiding this comment.
In my personal project I've done worse things for commit grouping. But whatever people do, the CI has to pass.
There was a problem hiding this comment.
the reason i said it should be a separate PR, because then that could be merged earlier/separately
|
@brianstoop will you fix the tests for this? |
|
@SMillerDev I should have fixed the tests in my latest commit |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #681 +/- ##
=========================================
Coverage 66.60% 66.60%
- Complexity 439 443 +4
=========================================
Files 26 26
Lines 1129 1129
=========================================
Hits 752 752
Misses 377 377 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.