Skip to content

Conversation

marverix
Copy link
Contributor

Hello, I would like to contribute and add Docker Bake JSON schema.

Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@marverix
Copy link
Contributor Author

Can you give me some advices why pre-commit.ci - pr fails? Logs are not very informative.

@hyperupcall
Copy link
Member

hyperupcall commented Jul 24, 2024

@marverix Yeah, pre-commit.ci has an issue where it can't automatically fix files in a fork that isn't owned by a non-organization (GitHub doesn't make it possible). We have a prettier:fix script you can run like npm run prettier:fix. But be sure to only add & commit the files you've changed because pre-commit.ci doesn't work well with other files like src/test/json/.prettierrc.json etc.

@marverix
Copy link
Contributor Author

@hyperupcall Thanks, done!

@hyperupcall
Copy link
Member

hyperupcall commented Jul 25, 2024

awesome thanks

@hyperupcall hyperupcall merged commit 21004ed into SchemaStore:master Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants