Handle environment vars. with space properly #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have this env. var: no_proxy=*.local, 169.254/16 it is very hard to get the quoting correct. It is easier to just write the correct entries to the seluser's .bash_aliases file, which will be included by .bashrc when running xvfb-run as the seluser.
|
this is a step in the right direction. I still had to run my node-chrome-debug using |
|
This same problem exists in 2.53.1 as reported in #327 |
|
Should solve #227 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xin the preceding checkbox, I verify that I have signed the Contributor License AgreementIf you have this environment variable:
no_proxy=*.local, 169.254/16it is very hard to get the quoting correct. It is easier to just write
the correct entries to the seluser's .bash_aliases file, which will be
included by .bashrc when running xvfb-run as the seluser.