Skip to content

Conversation

Cornelius117
Copy link
Contributor

@Cornelius117 Cornelius117 commented Sep 18, 2025

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Add the corresponding vid & pid to the NEW_MATTER_LOCK_PRODUCTS table to enable the Deasino devices (One of these was transferred to another manufacturer, Viomi) to support PIN feature.

Summary of Completed Tests

After the modification, the pin feature of these two devices is enabled normally without exception. Please refer to the link below for details:
https://smartthings.atlassian.net/wiki/spaces/CS/pages/4236215029/Function+test+after+pin+feature+of+Deasino+devices+is+enabled

Copy link
Contributor

@Huangxiangjie Huangxiangjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added devices supporting PIN feature

@HunsupJung HunsupJung merged commit 1730cbc into SmartThingsCommunity:main Sep 22, 2025
7 checks passed
Copy link

Copy link

File Coverage
All files 71%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua 64%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 4446756

@Cornelius117 Cornelius117 deleted the update-new-doorlock-deasino branch September 22, 2025 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants