-
Notifications
You must be signed in to change notification settings - Fork 640
Create packages using fpm instead of debuild #777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create packages using fpm instead of debuild #777
Conversation
This looks awesome, I'll try it out tonight. 😸 |
@jakejarrett I asked packagecloud.io for a free Open-Source account/plan. Lets see what they answer. This would streamline getting the package to users. |
@@ -56,4 +54,7 @@ fpm -t deb \ | |||
--description "Soundnode App is an Open-Source project to support Soundcloud for desktop Mac, Windows, and Linux." \ | |||
--after-install "fpm/create-symlink" \ | |||
--after-remove "fpm/remove-symlink" \ | |||
--deb-no-default-config-files | |||
--deb-no-default-config-files \ | |||
"$DIST_DIR/.=/usr/share/soundnode/" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The app
@jakejarrett I would like to have an SVG file of the soundnode icon: @pmarquees: I saw that you added the soundnode icon. Do you have an SVG version for me? |
In the latest commit I had to resize the icon from apps/soundnode.png in 114x114 to fpm/soundnode-48x48.png in 48x48. This means the icon is now essentially duplicated. Maybe we should convert it automatically using
This would however require imagemagick to be installed for building debian packages. If thats OK @jakejarrett , I can add this step to the Still, I need a svg of the icon. |
@jakejarrett They answered telling me that its no problem having an account for that. I created it and will be maintaining a debian repository containing a package of this project. Aside from the small issue with the I have also updated the documentation for building the debian package. Once this is in |
@JonasGroeger Looks good, I'd suggest squashing the commits down to a single commit if possible, Besides that, it should be good to merge. |
* Added: Debian packaging with icon, .desktop file, /usr/bin/soundnode * Missing: scalable svg icon
@jakejarrett With delight :) |
@jakejarrett ping :) |
@JonasGroeger sorry been a bit preoccupied with some stuff lately. This is good to merge. |
This PR introduces a shell script called
build-deb
which can be used to create debian packages of this project.After sucessfully building the project using
grunt build
, you can then go ahead and run one ofDIST=linux64
is the default.Using fpm makes it also easier to build
rpm
s or other packages.Since fpm does not yet support signing deb packages (see jordansissel/fpm#170, jordansissel/fpm#809, jordansissel/fpm#467), this isn't done as of yet.