Skip to content

Conversation

JonasGroeger
Copy link
Contributor

@JonasGroeger JonasGroeger commented May 24, 2016

This PR introduces a shell script called build-deb which can be used to create debian packages of this project.

After sucessfully building the project using grunt build, you can then go ahead and run one of

VERSION=0.6.4 DIST=linux64 ./fpm/build-deb
VERSION=0.6.4 DIST=linux32 ./fpm/build-deb

DIST=linux64 is the default.

Using fpm makes it also easier to build rpms or other packages.

Since fpm does not yet support signing deb packages (see jordansissel/fpm#170, jordansissel/fpm#809, jordansissel/fpm#467), this isn't done as of yet.

@jakejarrett
Copy link
Member

This looks awesome, I'll try it out tonight. 😸

@JonasGroeger
Copy link
Contributor Author

JonasGroeger commented May 25, 2016

@jakejarrett I asked packagecloud.io for a free Open-Source account/plan. Lets see what they answer. This would streamline getting the package to users.

@JonasGroeger JonasGroeger changed the title Create packages using fpm Create packages using fpm instead of debuild May 25, 2016
@@ -56,4 +54,7 @@ fpm -t deb \
--description "Soundnode App is an Open-Source project to support Soundcloud for desktop Mac, Windows, and Linux." \
--after-install "fpm/create-symlink" \
--after-remove "fpm/remove-symlink" \
--deb-no-default-config-files
--deb-no-default-config-files \
"$DIST_DIR/.=/usr/share/soundnode/" \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The app

@JonasGroeger
Copy link
Contributor Author

JonasGroeger commented May 26, 2016

@jakejarrett I would like to have an SVG file of the soundnode icon: soundnode.svg. Then I can put it in /usr/share/icons/hicolor/scalable.

@pmarquees: I saw that you added the soundnode icon. Do you have an SVG version for me?

@JonasGroeger
Copy link
Contributor Author

JonasGroeger commented May 26, 2016

In the latest commit I had to resize the icon from apps/soundnode.png in 114x114 to fpm/soundnode-48x48.png in 48x48. This means the icon is now essentially duplicated. Maybe we should convert it automatically using

convert -resize 48 app/soundnode.png fpm/soundnode-48x48.png

This would however require imagemagick to be installed for building debian packages. If thats OK @jakejarrett , I can add this step to the build-deb script.

Still, I need a svg of the icon.

@JonasGroeger
Copy link
Contributor Author

JonasGroeger commented May 31, 2016

@jakejarrett They answered telling me that its no problem having an account for that. I created it and will be maintaining a debian repository containing a package of this project. Aside from the small issue with the *.svg icon (for which I have also mailed @pmarquees), this is ready to merge imho.

I have also updated the documentation for building the debian package.

Once this is in master, I will upload a package of this project to the debian repository.

This was referenced May 31, 2016
@jakejarrett
Copy link
Member

@JonasGroeger Looks good, I'd suggest squashing the commits down to a single commit if possible, Besides that, it should be good to merge.

* Added: Debian packaging with icon, .desktop file, /usr/bin/soundnode
* Missing: scalable svg icon
@JonasGroeger
Copy link
Contributor Author

@jakejarrett With delight :)

@JonasGroeger
Copy link
Contributor Author

@jakejarrett ping :)

@jakejarrett
Copy link
Member

@JonasGroeger sorry been a bit preoccupied with some stuff lately. This is good to merge.

@jakejarrett jakejarrett merged commit 98c1257 into Soundnode:master Jun 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants