Feature: Give option to specify the directory where envfile will be created #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamhssingh
suggested changes
Nov 1, 2020
src/create-envfile.py
Outdated
| text_file.write(out_file) | ||
| else: | ||
| with open(f"/github/workspace/{directory}/{file_name}", "w") as text_file: |
src/create-envfile.py
Outdated
|
|
||
| if "None" in directory: | ||
| with open(f"/github/workspace/{file_name}", "w") as text_file: |
|
Also, can you squash changes? @sumit4613 |
fix env variable name use f-strings fix typing mistake update readme handles a case when user want to create env file at root update readme update readme and prepare to raise PR
AngelOnFira
requested changes
Nov 21, 2020
README.md
Outdated
| @@ -21,21 +21,24 @@ jobs: | |||
|
|
|||
| steps: | |||
| - name: Make envfile | |||
| uses: SpicyPizza/create-envfile@v1 | |||
| uses: SpicyPizza/create-envfile@master | |||
|
@AngelOnFira I had updated this PR with all required changes. Please let me know if I had left anything. |
|
Thanks for the work @sumit4613 😃 |
|
I'll try to create an updated release in the next few days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #4
Adds support to specify the directory where envfile will be created.
@AngelOnFira Please update this PR if any change is required.
Thanks!