chore: update ssr-query package #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,8 +11,7 @@ export const createRouter = () => { | |||
| <% if (addOnEnabled['tanstack-query']) { %> | |||
| const rqContext = TanstackQuery.getContext(); | |||
There was a problem hiding this comment.
we must create a new query client for each request. is this happening?
There was a problem hiding this comment.
I'm honestly not entirely sure how this is wired up
I think this is the implementation
|
This
https://github.com/TanStack/create-tsrouter-app/blob/main/frameworks/react-cra/add-ons/tanstack-query/assets/src/integrations/tanstack-query/root-provider.tsx.ejs#L60-L79
is the non-tRPC version. It creates a new queryClient on each request.
…On Tue, Aug 12, 2025 at 1:25 PM Brenley Dueck ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In frameworks/react-cra/add-ons/start/assets/src/router.tsx.ejs
<#152 (comment)>
:
> @@ -11,8 +11,7 @@ export const createRouter = () => {
<% if (addOnEnabled['tanstack-query']) { %>
const rqContext = TanstackQuery.getContext();
I'm honestly not entirely sure how this is wired up
I think this is the implementation
https://github.com/TanStack/create-tsrouter-app/blob/main/frameworks/react-cra/add-ons/tanstack-query/assets/src/integrations/tanstack-query/root-provider.tsx.ejs
—
Reply to this email directly, view it on GitHub
<#152 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAFO6AH3PGMS4YOQF6XZK33NJEUXAVCNFSM6AAAAACDXQ6CQOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCMJSGY4TKMJTHE>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the query integration to use the new pacakage and initialize things correctly.
I did some brief testing but would appreciate others trying it out too.