onUpdate option

[tigawanna]

I think am doing something wrong here but my implementation below works for onInsert but not for onUpdate , the onUpdate isn't even getting called

      getKey: (item) => item.id,
      // schema: WatchlistResponseSchema,
      onInsert: async ({ transaction }) => {
        const { original, modified } = transaction.mutations[0];
        await createWatchlist(modified);
      },
      onUpdate: async ({ transaction }) => {
        const { original, modified } = transaction.mutations[0];
        await updateWatchlist(modified);
      },

Am wondering if am calling collection.update correctly , when i hover the types it says the firts argument is a key and am wodering ifit's the query key or it's the one got from getKey: (item) => item.id and what else could i be doing wrong

          if (editingWatchlist) {
            myWatchlistsCollection(qc).update(editingWatchlist.id, (draft) => {
              draft.title = "new title";
            });
          } else {
            myWatchlistsCollection(qc).insert(data as any);
          }

am on the latest version

{
    "@tanstack/query-db-collection": "^0.1.2",
    "@tanstack/react-db": "^0.1.0"
}

[KyleAMathews]

Huh that looks right. You're not getting any error or other notice in the console? Maybe it's the same as #366 — perhaps we shipped a regression recently...

[KyleAMathews]

Have you tried any of the examples?

[tigawanna]

The examples work so i took a closer look at my implementation and i think the issue stems from me returning a collection from a function which creates multiple instances of the same collection if the function iscalled in multiple spots

doing this

  const myWatchlistCollection = myWatchlistsCollection(qc);

and using that for the live query and update call fixes the update problem

In my case am wrapping it in a function in order to pass in stuff like external filters and a query client instance to the collection
const qc = useQueryClient();

This might make it harder for me to for example update a community watchist when my watchlist changes hard because ieverything is tied to the components

i'll keep playing around with it to see if i can find more elegang workaournds to this limitations maybe using go=lobal stores with something like #357

[KyleAMathews]

Ah yeah, you want to use a weakmap cache when creating collections on the fly to ensure you get back only one instance.

[tigawanna]

For anyone else who wants to do this this is what's working for me

interface CommunityWatchlistItemsCollectionProps {
  keyword?: string;
  page?: number;
  qc: QueryClient;
  watchlistId: string;
}

// Function that creates a new items collection instance
function createCommunityWatchlistItemsCollection({
  keyword,
  page = 1,
  qc,
  watchlistId,
}: CommunityWatchlistItemsCollectionProps) {
  return createCollection(
    queryCollectionOptions({
      // Key for items of a specific community watchlist
      queryKey: ["watchlist", "community", keyword, page, "details", watchlistId],
      queryFn: async () => {
        const response = await getCommunityWatchListFromQueryClient({ keyword, page, qc });
        const singleWatchlist = response.items.filter((item) => {
          return item.id === watchlistId;
        });
        return singleWatchlist[0]?.expand?.items ?? [];
      },
      queryClient: queryClient,
      getKey: (item) => item.id,
    })
  );
}

// Type for the items collection return type
type CommunityWatchlistItemsCollection = ReturnType<typeof createCommunityWatchlistItemsCollection>;

// Cache to memoize items collections per QueryClient and filters
const communityWatchlistItemsCache: WeakMap<
  QueryClient,
  Map<string, CommunityWatchlistItemsCollection>
> = new WeakMap();

[KyleAMathews]

if it's the query key or it's the one got from getKey: (item) => item.id

Its whatever you return for getKey so in this case, the id of the item.