Skip to content

chore(tsconfig.json): simplify 'include' patterns by consolidating file extensions and directory paths #9547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 3, 2025
Merged

chore(tsconfig.json): simplify 'include' patterns by consolidating file extensions and directory paths #9547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b4707be
chore(tsconfig.json): simplify 'include' patterns by consolidating fi…
sukvvon Aug 10, 2025
ae4d50d
Merge branch 'main' into chore/tsconfig-json-simplify-include-pattern…
sukvvon Aug 10, 2025
891776b
Merge branch 'main' into chore/tsconfig-json-simplify-include-pattern…
sukvvon Aug 12, 2025
780ffb0
Merge branch 'main' into chore/tsconfig-json-simplify-include-pattern…
sukvvon Aug 14, 2025
633ca6a
Merge branch 'main' into chore/tsconfig-json-simplify-include-pattern…
manudeli Sep 3, 2025
b75efe3
Merge branch 'main' into chore/tsconfig-json-simplify-include-pattern…
TkDodo Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/angular-query-devtools-experimental/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"useDefineForClassFields": false,
"target": "ES2022"
},
"include": ["src", "*.config.js", "*.config.ts", "package.json"],
"include": ["src", "*.config.*", "package.json"],
"references": [
{ "path": "../query-devtools" },
{ "path": "../angular-query-experimental" }
Expand Down
9 changes: 1 addition & 8 deletions packages/angular-query-experimental/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,6 @@
"useDefineForClassFields": false,
"target": "ES2022"
},
"include": [
"src",
"scripts",
"test-setup.ts",
"*.config.js",
"*.config.ts",
"package.json"
],
"include": ["src", "scripts", "test-setup.ts", "*.config.*", "package.json"],
"references": [{ "path": "../query-core" }, { "path": "../query-devtools" }]
}
8 changes: 1 addition & 7 deletions packages/angular-query-persist-client/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,7 @@
"useDefineForClassFields": false,
"target": "ES2022"
},
"include": [
"src",
"test-setup.ts",
"*.config.js",
"*.config.ts",
"package.json"
],
"include": ["src", "test-setup.ts", "*.config.*", "package.json"],
"references": [
{ "path": "../angular-query-experimental" },
{ "path": "../query-persist-client-core" }
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-plugin-query/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
"outDir": "./dist-ts",
"rootDir": "."
},
"include": ["src", "*.config.js", "*.config.ts", "package.json"]
"include": ["src", "*.config.*", "package.json"]
}
2 changes: 1 addition & 1 deletion packages/query-async-storage-persister/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
"outDir": "./dist-ts",
"rootDir": "."
},
"include": ["src", "*.config.js", "*.config.ts", "package.json"],
"include": ["src", "*.config.*", "package.json"],
"references": [{ "path": "../query-persist-client-core" }]
}
8 changes: 1 addition & 7 deletions packages/query-broadcast-client-experimental/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,6 @@
"outDir": "./dist-ts",
"rootDir": "."
},
"include": [
"src",
"test-setup.ts",
"*.config.js",
"*.config.ts",
"package.json"
],
"include": ["src", "test-setup.ts", "*.config.*", "package.json"],
"references": [{ "path": "../query-core" }]
}
2 changes: 1 addition & 1 deletion packages/query-codemods/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
"outDir": "./dist-ts",
"rootDir": "."
},
"include": ["src", "*.config.js", "*.config.ts", "package.json"]
"include": ["src", "*.config.*", "package.json"]
}
2 changes: 1 addition & 1 deletion packages/query-core/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
"outDir": "./dist-ts",
"rootDir": "."
},
"include": ["src", "*.config.js", "*.config.ts", "package.json"]
"include": ["src", "*.config.*", "package.json"]
}
2 changes: 1 addition & 1 deletion packages/query-devtools/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
"jsx": "preserve",
"jsxImportSource": "solid-js"
},
"include": ["src", "*.config.js", "*.config.ts", "package.json"],
"include": ["src", "*.config.*", "package.json"],
"references": [{ "path": "../query-core" }]
}
2 changes: 1 addition & 1 deletion packages/query-persist-client-core/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@
"outDir": "./dist-ts",
"rootDir": "."
},
"include": ["src", "*.config.js", "*.config.ts", "package.json"],
"include": ["src", "*.config.*", "package.json"],
"references": [{ "path": "../query-core" }]
}
2 changes: 1 addition & 1 deletion packages/query-sync-storage-persister/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"outDir": "./dist-ts",
"rootDir": "."
},
"include": ["src", "*.config.js", "*.config.ts", "package.json"],
"include": ["src", "*.config.*", "package.json"],
"references": [
{ "path": "../query-core" },
{ "path": "../query-persist-client-core" }
Expand Down
2 changes: 1 addition & 1 deletion packages/query-test-utils/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
"outDir": "./dist-ts",
"rootDir": "."
},
"include": ["src", "*.config.js", "package.json"]
"include": ["src", "*.config.*", "package.json"]
}
8 changes: 1 addition & 7 deletions packages/react-query-devtools/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,6 @@
"rootDir": ".",
"jsx": "react-jsx"
},
"include": [
"src",
"test-setup.ts",
"*.config.js",
"*.config.ts",
"package.json"
],
"include": ["src", "test-setup.ts", "*.config.*", "package.json"],
"references": [{ "path": "../query-devtools" }, { "path": "../react-query" }]
}
2 changes: 1 addition & 1 deletion packages/react-query-next-experimental/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@
"rootDir": ".",
"jsx": "react-jsx"
},
"include": ["src", "*.config.js", "*.config.ts", "package.json"],
"include": ["src", "*.config.*", "package.json"],
"references": [{ "path": "../react-query" }]
}
8 changes: 1 addition & 7 deletions packages/react-query-persist-client/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,7 @@
"rootDir": ".",
"jsx": "react-jsx"
},
"include": [
"src",
"test-setup.ts",
"*.config.js",
"*.config.ts",
"package.json"
],
"include": ["src", "test-setup.ts", "*.config.*", "package.json"],
"references": [
{ "path": "../query-persist-client-core" },
{ "path": "../react-query" }
Expand Down
8 changes: 1 addition & 7 deletions packages/react-query/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,5 @@
"rootDir": ".",
"jsx": "react-jsx"
},
"include": [
"src",
"test-setup.ts",
"*.config.js",
"*.config.ts",
"package.json"
]
"include": ["src", "test-setup.ts", "*.config.*", "package.json"]
}
2 changes: 1 addition & 1 deletion packages/solid-query-devtools/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@
"jsx": "preserve",
"jsxImportSource": "solid-js"
},
"include": ["src", "*.config.js", "*.config.ts", "package.json"],
"include": ["src", "*.config.*", "package.json"],
"references": [{ "path": "../query-devtools" }, { "path": "../solid-query" }]
}
8 changes: 1 addition & 7 deletions packages/solid-query-persist-client/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,7 @@
"jsx": "preserve",
"jsxImportSource": "solid-js"
},
"include": [
"src",
"test-setup.ts",
"*.config.js",
"*.config.ts",
"package.json"
],
"include": ["src", "test-setup.ts", "*.config.*", "package.json"],
"references": [
{ "path": "../query-persist-client-core" },
{ "path": "../solid-query" }
Expand Down
8 changes: 1 addition & 7 deletions packages/solid-query/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,6 @@
"jsx": "preserve",
"jsxImportSource": "solid-js"
},
"include": [
"src",
"test-setup.ts",
"*.config.js",
"*.config.ts",
"package.json"
],
"include": ["src", "test-setup.ts", "*.config.*", "package.json"],
"references": [{ "path": "../query-core" }]
}
9 changes: 1 addition & 8 deletions packages/svelte-query-devtools/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,6 @@
"outDir": "./dist-ts",
"rootDir": "."
},
"include": [
"src/**/*.js",
"src/**/*.ts",
"src/**/*.svelte",
"*.config.js",
"*.config.ts",
"package.json"
],
"include": ["src", "*.config.*", "package.json"],
"references": [{ "path": "../query-devtools" }, { "path": "../svelte-query" }]
}
12 changes: 1 addition & 11 deletions packages/svelte-query-persist-client/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,7 @@
"outDir": "./dist-ts",
"rootDir": "."
},
"include": [
"src/**/*.js",
"src/**/*.ts",
"src/**/*.svelte",
"tests/**/*.js",
"tests/**/*.ts",
"tests/**/*.svelte",
"*.config.js",
"*.config.ts",
"package.json"
],
"include": ["src", "tests", "*.config.*", "package.json"],
"references": [
{ "path": "../query-persist-client-core" },
{ "path": "../svelte-query" }
Expand Down
12 changes: 1 addition & 11 deletions packages/svelte-query/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,6 @@
"outDir": "./dist-ts",
"rootDir": "."
},
"include": [
"src/**/*.js",
"src/**/*.ts",
"src/**/*.svelte",
"tests/**/*.js",
"tests/**/*.ts",
"tests/**/*.svelte",
"*.config.js",
"*.config.ts",
"package.json"
],
"include": ["src", "tests", "*.config.*", "package.json"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Preserve Svelte SFC coverage under tests and src

Directory-level "src"/"tests" may omit .svelte from the TS program. Keep explicit globs to avoid regressions in editor tooling and svelte-check.

Apply:

-  "include": ["src", "tests", "*.config.*", "package.json"],
+  "include": ["src", "tests", "src/**/*.svelte", "tests/**/*.svelte", "*.config.*", "package.json"],

Quick check:

🏁 Script executed:

#!/bin/bash
fd -e svelte packages/svelte-query/{src,tests} -x echo '{}'
# If any paths print, ensure svelte-check reports them with this tsconfig.

Length of output: 487

🏁 Script executed:

#!/bin/bash
# Search for all .svelte files under src and tests directories
fd -e svelte . packages/svelte-query/src packages/svelte-query/tests -x echo {}

Length of output: 1272

Include Svelte SFC globs in tsconfig.json include
In packages/svelte-query/tsconfig.json, update the include array to explicitly include .svelte files in both src and tests so that svelte-check and editor tooling pick them up:

-  "include": ["src", "tests", "*.config.*", "package.json"],
+  "include": [
+    "src",
+    "tests",
+    "src/**/*.svelte",
+    "tests/**/*.svelte",
+    "*.config.*",
+    "package.json"
+  ],
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"include": ["src", "tests", "*.config.*", "package.json"],
"include": [
"src",
"tests",
"src/**/*.svelte",
"tests/**/*.svelte",
"*.config.*",
"package.json"
],
🤖 Prompt for AI Agents 
In packages/svelte-query/tsconfig.json around line 7, the "include" array
doesn't explicitly include Svelte single-file components, so editor tooling and
svelte-check won't pick up .svelte files; update the include array to add globs
such as "src/**/*.svelte" and "tests/**/*.svelte" (or simply "**/*.svelte")
alongside the existing entries so SFCs in both src and tests are included.

"references": [{ "path": "../query-core" }]
}
8 changes: 1 addition & 7 deletions packages/vue-query-devtools/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,6 @@
"outDir": "./dist-ts",
"rootDir": "."
},
"include": [
"src/**/*.ts",
"src/**/*.vue",
"*.config.js",
"*.config.ts",
"package.json"
],
"include": ["src", "*.config.*", "package.json"],
"references": [{ "path": "../vue-query" }, { "path": "../query-devtools" }]
}
8 changes: 1 addition & 7 deletions packages/vue-query/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,6 @@
"outDir": "./dist-ts",
"rootDir": "."
},
"include": [
"src",
"test-setup.ts",
"*.config.js",
"*.config.ts",
"package.json"
],
"include": ["src", "test-setup.ts", "*.config.*", "package.json"],
"references": [{ "path": "../query-core" }]
}
2 changes: 1 addition & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@
"strict": true,
"target": "ES2020"
},
"include": ["eslint.config.js", "prettier.config.js"]
"include": ["*.config.*"]
}
Loading