chore(deps): update all non-major dependencies #9628
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
github-actions
bot
added
package: react-query-devtools
package: react-query
package: react-query-persist-client
package: vue-query
package: query-core
package: solid-query
package: query-persist-client-core
package: eslint-plugin-query
package: svelte-query
package: svelte-query-devtools
package: query-devtools
package: angular-query-experimental
package: angular-query-devtools-experimental
package: query-async-storage-persister
labels
WalkthroughUpdated CI workflow action versions and bumped numerous dependency/devDependency versions across root, examples, integrations, and package manifests; no source-code, public API, or control-flow changes were introduced. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (81)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (76)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2025-09-02T17:57:33.184ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (1)
Comment |
github-actions
bot
added
package: query-sync-storage-persister
package: solid-query-persist-client
package: svelte-query-persist-client
package: vue-query-devtools
package: solid-query-devtools
package: query-broadcast-client-experimental
package: react-query-next-experimental
package: angular-query-persist-client
package: query-test-utils
labels
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx affected --targets=test:sherif,test:knip,tes... |
❌ Failed | 3m 13s | View ↗ |
nx run-many --target=build --exclude=examples/*... |
❌ Failed | 1m 27s | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-09-14 01:35:14 UTC
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 20
🧹 Nitpick comments (13)
examples/react/eslint-legacy/package.json (1)
23-26: Align React 19 with @types v19 across all React examples
The following examples depend on React 19 but still reference @types/react@18 and @types/react-dom@18, which can cause type mismatches with TypeScript 5.8:
- examples/react/algolia/package.json
- examples/react/basic/package.json
- examples/react/eslint-legacy/package.json
- examples/react/react-router/package.json
In each, update the devDependencies to:
"@types/react": "^19.0.1", "@types/react-dom": "^19.0.2",.github/workflows/autofix.yml (1)
21-21: Pin actions/checkout to a commit SHA for supply-chain hardening
Optional, but recommended for immutable CI builds.
Example:- uses: actions/[email protected] + uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feacpackages/solid-query/package.json (1)
74-78: Solid toolchain bumps look consistentnpm-run-all2, solid-js, and vite-plugin-solid are aligned with other Solid packages in this PR. Peer range remains "^1.6.0", which is fine but broad; consider tightening the min if features require ≥1.9.
examples/react/algolia/package.json (1)
11-24: Use caret for @algolia/client-search
Replace the pinned version with a caret for consistency:- "@algolia/client-search": "5.37.0", + "@algolia/client-search": "^5.37.0",npm view confirms it requires Node ≥ 14.0.0 and its ESM/CJS exports align with your “type”: “module” + Vite setup.
packages/solid-query-devtools/package.json (1)
68-72: Peer range still valid; optional tighten-upDevDeps bumped (solid-js 1.9.9, vite-plugin-solid 2.11.8). Peer dep on solid-js is "^1.6.0", which covers 1.9.x—no action required. Optionally, document tested range (e.g., “>=1.6 <2”) in README to set expectations.
packages/react-query/package.json (1)
1-87: Add missing Vite devDependencyIn packages/react-query/package.json you have
@vitejs/plugin-react(^4.7.0) but noviteentry—add underdevDependencies:"devDependencies": { - "@vitejs/plugin-react": "^4.7.0" + "@vitejs/plugin-react": "^4.7.0", + "vite": "^6.3.0" }.github/workflows/pr.yml (1)
25-25: Consider pinning GitHub Actions to commit SHAs and adding job timeouts.actions/checkout and nrwl/nx-set-shas are on version tags. For supply‑chain hardening, pin to the release commit SHA with an inline comment for the tag. Also consider
timeout-minuteson jobs to prevent hangs.Also applies to: 33-33, 54-54
packages/solid-query-persist-client/package.json (1)
73-77: Dev deps bumped; peer range remains broad—consider CI matrix for Solid versions.Peer allows solid-js >=1.6 while tests run on 1.9.x. Optional: add a small CI matrix to smoke‑test a lower Solid within the supported peer range to catch regressions.
.github/workflows/ci.yml (1)
30-30: Same as pr.yml: optionally pin actions and add timeouts.Pin actions/checkout to a commit SHA and consider
timeout-minuteson the job/steps for resilience.packages/query-devtools/package.json (1)
67-81: Unifysolid-jsversions across the workspace
Update allsolid-jsentries to the same range (for example,^1.9.9), replacing the older^1.6.0in:
- packages/solid-query/package.json (lines 75 & 80)
- packages/solid-query-persist-client/package.json (lines 74 & 80)
- packages/solid-query-devtools/package.json (lines 69 & 75)
Then runpnpm -w dedupeto collapse duplicate versions in the lockfile.examples/react/rick-morty/package.json (1)
11-14: MUI upgrades OK; consider migrating off @mui/styles (deprecated).@mui/styles is legacy and discouraged for new code; plan a follow-up to replace it (e.g., Emotion/Pigment CSS). This is optional for this Renovate PR. (npmjs.com, mui.com)
package.json (1)
53-55: React Hooks plugin is RCeslint-plugin-react-hooks is on 6.0.0-rc1. If not intentional, prefer a stable tag to avoid churn; otherwise document the reason in the PR description.
- "eslint-plugin-react-hooks": "^6.0.0-rc1", + "eslint-plugin-react-hooks": "^6.0.0" # when GA landsexamples/angular/pagination/package.json (1)
19-19: Unify semver strategy for zone.jsThis example pins zone.js exactly (0.15.1) while other packages use ~0.15.1. Consider aligning to a single strategy for predictability.
- "zone.js": "0.15.1" + "zone.js": "~0.15.1"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.github/workflows/autofix.yml(1 hunks).github/workflows/ci.yml(1 hunks).github/workflows/pr.yml(2 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-devtools-experimental/package.json(1 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/query-sync-storage-persister/package.jsonexamples/solid/astro/package.jsonpackages/solid-query-devtools/package.jsonpackages/react-query-persist-client/package.jsonpackages/solid-query/package.jsonpackages/query-persist-client-core/package.jsonpackages/angular-query-persist-client/package.jsonpackages/svelte-query/package.jsonexamples/solid/basic-graphql-request/package.jsonpackages/vue-query/package.jsonpackages/react-query-devtools/package.jsonexamples/react/basic-graphql-request/package.jsonpackages/vue-query-devtools/package.jsonpackages/query-core/package.jsonexamples/angular/basic-persister/package.jsonpackages/query-async-storage-persister/package.jsonpackages/react-query/package.jsonpackages/angular-query-experimental/package.jsonintegrations/react-vite/package.jsonintegrations/react-next-15/package.jsonpackages/react-query-next-experimental/package.jsonpackages/solid-query-persist-client/package.jsonexamples/vue/persister/package.jsonpackages/query-broadcast-client-experimental/package.jsonexamples/solid/basic/package.jsonexamples/solid/default-query-function/package.jsonpackages/angular-query-devtools-experimental/package.jsonpackages/svelte-query-devtools/package.jsonexamples/solid/simple/package.jsonpackages/svelte-query-persist-client/package.jsonintegrations/solid-vite/package.jsonpackage.json
📚 Learning: 2025-08-19T03:18:18.303Z
Learnt from: oscartbeaumont
PR: TanStack/query#9564
File: packages/solid-query-devtools/src/production.tsx:2-3
Timestamp: 2025-08-19T03:18:18.303Z
Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach.
Applied to files:
packages/solid-query-devtools/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (58)
examples/vue/2.7-basic/package.json (1)
17-17: Vite 4.x bump for Vue 2.7 example looks good.No compatibility concerns with vue2 + vite-plugin-vue2 2.0.3.
packages/query-persist-client-core/package.json (1)
66-66: npm-run-all2 patch bump is safe.No script changes needed; CLI remains
npm-run-all.examples/react/shadow-dom/package.json (1)
19-22: Vite 6.3 + plugin-react 4.7 with React 19 types is consistent.This example is already on @types v19; upgrade set looks coherent.
packages/query-test-utils/package.json (1)
38-38: Uniform npm-run-all2 patch bump acknowledged.Matches the repo-wide update pattern.
examples/vue/2.6-basic/package.json (1)
18-18: Vite 4.x patch bump for Vue 2.6 example is fine.Keeps compatibility with vite-plugin-vue2 2.0.3.
examples/react/devtools-panel/package.json (1)
17-20: React devtools-panel: Vite/tooling bumps look consistent.No API or script changes required.
examples/vue/dependent-queries/package.json (1)
15-18: Vite 6.x bump: declare Node >=18 and regenerate lockfileOnly
examples/solid/basic-graphql-request/package.jsondeclaresengines.node(≥18); the root andexamples/vue/dependent-queries/package.jsonlack a Node version constraint. Addengines.node: ">=18"(and update your CI matrix), then reinstall to refresh the lockfile and lock Vite/plugin minors.examples/vue/nuxt3/package.json (1)
13-14: Nuxt upgrade sanity check
Version ^3.19.1 confirmed;nuxt.config.tscontains nonitro,experimental, orviteflags. Runnpm run dev,npm run build, andnpm run previewto catch any config regressions.examples/svelte/simple/package.json (1)
16-21: Ignore SvelteKit compatibility check for this example
Theexamples/svelte/simplesetup is a plain Svelte template—there’s no@sveltejs/kitdependency or Kit-specific config (noadapter-autoorvitePlugininsvelte.config.js), so verifying SvelteKit defaults isn’t applicable.Likely an incorrect or invalid review comment.
examples/solid/default-query-function/package.json (1)
13-19: Solid/Vite alignment looks goodsolid-js ^1.9.9 with vite ^6.3.5 and vite-plugin-solid ^2.11.8 is a known-good combo. No action beyond lockfile update.
examples/vue/persister/package.json (1)
15-22: Run build & smoke-test forexamples/vue/persister
Verifiedidb-keyvalis ^6.2.2 (no duplicates) and Vite is ^6.3.5 with @vitejs/plugin-vue ^5.2.4—please do a quick install, build, and runtime check to ensure ESM/CJS bundling works.packages/query-core/package.json (1)
61-64: npm-run-all2 bump validated
All package scripts continue to invoke “npm-run-all” (no hardcoded “npm-run-all2” usages detected).examples/solid/astro/package.json (1)
15-22: Approve dependencies bump in examples/solid/astro/package.json
Dependencies align with repo-wide versions (astro 5.5.6, solid-js 1.9.9, @astrojs/solid-js 5.1.0, tailwindcss 3.4.17); no compatibility issues detected.packages/react-query-persist-client/package.json (1)
67-71: Version consistency across workspaces: All instances of@vitejs/plugin-reactare^4.7.0and@testing-library/reactare^16.3.0in everypackage.json—no skew detected.integrations/react-vite/package.json (1)
11-15: Approve code changes: Vite and plugin-react versions are consistent across all React Vite integrations and examples. All scanned package.json files use Vite ^6.3.5 and @vitejs/plugin-react ^4.7.0.packages/react-query-next-experimental/package.json (1)
61-64: Approve dev-only dependency bumps
Vite plugin is imported inpackages/react-query-next-experimental/vite.config.ts, so the@vitejs/plugin-reactdev bump is used and safe; runtime surface remains unchanged.examples/solid/solid-start-streaming/package.json (1)
14-19: Approve: SolidStart 1.1.7 & vinxi 0.5.8 updates
Node >=18 is enforced in examples/solid/solid-start-streaming/package.json; no breaking changes expected.integrations/svelte-vite/package.json (1)
12-13: Approve Svelte/Vite version alignment
All Svelte (^5.38.7) and Vite (^6.3.5) versions are consistent across relevant workspaces and examples; peer ranges in svelte-query packages cover Svelte 5.packages/svelte-query/package.json (1)
50-57: Approve Svelte dev tooling version updates
PeerDependencies already allow Svelte ^5.0.0 and all Svelte examples use ^5.38.7; no breaking changes or CI impact.examples/react/playground/package.json (1)
17-20: Approve React playground toolchain bump – dependencies now align with other React examples; React ^19 verified consistently across all examples and packages.examples/react/suspense/package.json (1)
19-22: Verified Suspense example build with updated Vite/plugin
Suspense example builds successfully using Vite ^6.3.5 and @vitejs/plugin-react ^4.7.0 with no SWC/plugin default regressions or Suspense-related warnings.packages/query-sync-storage-persister/package.json (1)
67-67: LGTM: npm-run-all2 patch bump.Matches repo-wide update; no runtime impact expected.
packages/query-async-storage-persister/package.json (1)
67-67: LGTM: npm-run-all2 patch bump; deps align with learning.@tanstack/query-core is already a workspace dep (per prior learning); safe patch update.
examples/solid/basic-graphql-request/package.json (2)
13-16: Build passed with [email protected] & [email protected]—run TS type check
The Solid GraphQL example builds successfully; to catch any tightened type errors, run a full type‐check in the example:pnpm --filter "./examples/solid/basic-graphql-request" exec tsc --noEmit
19-21: Example build is green; verify Vite/Solid plugin version parity
Runcd examples/solid/basic-graphql-request && pnpm install && pnpm run buildto confirm the example builds cleanly, then ensure itsviteandvite-plugin-solidversions align with those in the otherexamples/solid/*/package.json.examples/react/simple/package.json (1)
17-19: examples/react/simple: build passed with Vite 6.3.5 & @vitejs/plugin-react 4.7.0
Build completed successfully with the updated tooling; no further changes required.examples/svelte/optimistic-updates/package.json (1)
15-22: Confirm Node engine ranges and svelte-check compatibility
- @sveltejs/kit 2.37.1 requires Node ≥18.13; vite 6.3.5 supports Node 18.x, 20.x or ≥22; svelte 5.38.7 requires Node ≥18. Ensure your CI matrix covers at least Node 18.13 and 20.x.
- svelte-check 4.3.1 peer-declares
svelte: "^4.0.0 || ^5.0.0-next.0"andtypescript: ">=5.0.0". Stable Svelte 5.38.7 falls outside the prerelease range and will trigger a peer-dependency warning—confirm support for Svelte 5 stable or upgrade to a svelte-check version that officially includes it.examples/react/basic-graphql-request/package.json (1)
13-20: Peer dependencies are compatible
- @vitejs/plugin-react 4.7.0 declares vite '^4.2.0 || ^5.0.0 || ^6.0.0 || ^7.0.0', satisfying vite ^6.3.5.
- graphql-request 7.2.0 declares graphql '14 - 16', satisfying graphql ^16.11.0.
integrations/vue-vite/package.json (1)
13-16: Peer ranges are already compatible
@vitejs/[email protected] declares vue^3.2.25(includes 3.4.27) and vite^5.0.0 || ^6.0.0(includes 6.3.5), so no changes required.examples/solid/simple/package.json (1)
13-20: No changes needed: peer dependencies satisfied
[email protected] requires vite ^3.0.0‒^7.0.0 and solid-js ^1.7.2; the project’s versions (^6.3.5 and ^1.9.9) satisfy these ranges.integrations/react-webpack-5/package.json (1)
14-19: Approve Babel/Webpack configuration
Peer dependencies for @babel/[email protected] and @babel/[email protected] both support @babel/core >= 7.0.0-0, and the chosen versions align with React 19’s automatic runtime and Webpack 5—no issues.packages/query-broadcast-client-experimental/package.json (1)
61-68: Ensure CJS interop viatest:build
Imports only use ESM-style named exports frombroadcast-channel(no CommonJSrequirefound). Now runnpm run test:buildand verify that the generated CJS bundle resolvesbroadcast-channelcorrectly.examples/angular/devtools-panel/package.json (1)
12-27: Verify @angular/compiler-cli TypeScript peer dependency
All Angular examples pin TS to 5.8.3; confirm that @angular/[email protected] peerDependencies.typescript accepts TS 5.8.x (e.g. runnpm view @angular/[email protected] peerDependencies.typescript).integrations/react-next-15/package.json (1)
9-9: Temporal polyfill bump is safe.No breaking changes expected for typical usage; Next 15 + React 19 remain unaffected.
packages/angular-query-devtools-experimental/package.json (1)
57-62: Dev Angular bumps LGTM; peer ranges remain wide enough.No runtime deps changed; only dev tooling. Good.
packages/react-query-devtools/package.json (1)
86-91: Aligns with React 19 and Testing Library v16.Peer range already allows ^18 || ^19; this is consistent.
examples/svelte/ssr/package.json (1)
15-22: Svelte/Kit/Vite bumps look consistent.No API surface here; just tooling updates.
packages/react-query/package.json (1)
73-82: Dev tooling bumps look consistent across workspace.React 19 + @types/react 19 + plugin-react 4.7 + Vite 6.3 is a good set.
examples/svelte/star-wars/package.json (1)
15-25: Svelte + Vite bumps look good; verify Node runtime ≥18.Vite 6 and SvelteKit 2 require modern Node. CI likely uses Node 20, but double‑check local/engines consistency to avoid dev-time surprises.
If you want, I can add an engines field or confirm Node versions across the repo.
examples/react/offline/package.json (1)
16-25: Verify MSW registration with bumped dependencies
Run the offline React example (pnpm -w -F @tanstack/query-example-react-offline dev) to confirm service worker registration remains clean under Vite 6.3 with MSW v2.11.1 and react-hot-toast v2.6.0.examples/react/basic/package.json (1)
21-22: Retain @types/react and @types/react-dom
React v19 does not include its own TypeScript definitions—continue installing @types/react and @types/react-dom to ensure proper typings. (19.react.dev, docs.codemod.com)Likely an incorrect or invalid review comment.
packages/svelte-query-devtools/package.json (1)
45-54: Svelte tooling bumps LGTM.Peer range already includes ^5, and the svelte/svelte-check bumps align with Kit/Vite updates elsewhere.
examples/svelte/auto-refetching/package.json (1)
15-16: Confirm uniform versions; manual build & type-check requiredAll Svelte examples (except
simple, which is plain Svelte) now use
• @sveltejs/kit ^2.37.1
• @sveltejs/adapter-auto ^6.1.0
• vite ^6.3.5
• svelte ^5.38.7Run local builds and
svelte-checkagainst TS 5.8.3 to verify plugin/peer compatibility with @sveltejs/vite-plugin-svelte (^5.1.1).examples/react/chat/package.json (1)
17-19: validate Tailwind v4 config in examples/react/chat
Notailwind.config.*orpostcss.config.*found underexamples/react/chat—Tailwind will fall back to its defaults. If you require custom settings, add atailwind.config.jswith acontentarray (replacing any oldpurgekey) and remove any v3-only options.examples/svelte/load-more-infinite-scroll/package.json (1)
15-16: Approve Svelte toolchain bumps – smoke build succeeded
Minimal canary build passed with @sveltejs/adapter-auto@^6.1.0 and @sveltejs/kit@^2.37.1 matching other examples.packages/svelte-query-persist-client/package.json (1)
50-50: Approve changes: eslint-plugin-svelte@^3.12.2 supports ESLint v8.57.1 and above (including v9.x) and our ESLint ^9.35.0 satisfies this (npmjs.com)packages/angular-query-experimental/package.json (1)
71-81: DTS output verified for angular-query-experimental
[email protected] correctly generates declaration files with TS 5.8.3—no regressions detected.examples/react/default-query-function/package.json (1)
17-20: Versions confirmed for Vite‐based examplesAll React examples that use Vite list @vitejs/plugin-react ^4.7.0 and vite ^6.3.5. The Next.js and React Native samples intentionally don’t include Vite and can be ignored. A smoke build of default-query-function passed; consider also verifying the basic and chat examples build correctly under TS 5.8.3 to sanity-check fast refresh and the JSX transform.
packages/eslint-plugin-query/package.json (1)
62-70: ESLint 9 + @typescript-eslint 8.42 alignment looks good; Node pinned in .nvmrc to 24.4.1 – verify your CI honors this or explicitly sets Node ≥18.18.0examples/svelte/playground/package.json (1)
15-22: Validate with svelte-check and build smoke test
Run svelte-check viapnpm -C examples/svelte/playground exec svelte-check(or add
"check": "svelte-check"to package.json)
and verifypnpm -C examples/svelte/playground run buildcompletes without errors.
examples/angular/basic-persister/package.json (1)
12-27: Fixexamples/angular/basic-persisterbuild failure
Build is currently failing with an Angular compilation error:Error: ENOENT: no such file or directory, uv_resident_set_memoryfrom the Angular compiler plugin. Investigate and resolve this issue so the example can successfully build and we can validate the persister interop.
⛔ Skipped due to learnings
Learnt from: TkDodo PR: TanStack/query#9612 File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0 Timestamp: 2025-09-02T17:57:33.184Z Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.examples/angular/optimistic-updates/package.json (1)
12-25: Confirm form-related typings with TS 5.8 in a proper environment. Build failed here due to missing/proc/self/statin this sandbox (uv_resident_set_memory error) (stackoverflow.com); Angular 20.2.x supports Node v24.3.0 (angular.dev). Re-run build in CI or a local full-Linux environment to validate strict template type drift.integrations/solid-vite/package.json (1)
11-13: Solid + Vite bumps look fine; ensure CI Node matrix aligns with Vite 6 support.Vite 6 supports Node 18/20/22+. If your CI still runs Node 16/19, adjust it to avoid spurious failures. (main.vite.dev, main.vitejs.dev)
packages/angular-query-persist-client/package.json (1)
60-71: Angular 20.2 devDeps: verify workspace TypeScript ≥5.9 and Node ≥20.19.Angular 20.2.x requires TS >=5.9 and Node >=20.19. If the workspace/root still pins TS 5.8.3, local builds/tests here may fail. (angular.dev)
integrations/react-webpack-4/package.json (1)
14-17: Babel deps upgraded — still compatible with webpack 4.babel-loader 8.x supports webpack 4 and 5; this bump is safe for the v4 example. (webpack.js.org, github.com)
package.json (2)
41-45: ESLint plugin peer dependencies verifiedAll listed plugins resolved against eslint 9.35.0 with no peer-dependency warnings on install.
69-76: CI covers TS 5.x aliases via existingtest:typestarget
Theci.ymlandpr.ymlworkflows runpnpm run test:ci/test:pr, which invoke the NXtest:typestarget across all packages. Each package’stest:typesscript in turn runs itstest:types:ts50–test:types:ts57commands, exercising every TS alias without needing an explicit matrix.integrations/angular-cli-20/package.json (1)
12-21: Angular 20.2.x dependency set looks consistentCore/angular and rxjs/tslib/zone.js versions are in lockstep and match examples. LGTM.
| "@angular/common": "^20.2.4", | ||
| "@angular/compiler": "^20.2.4", | ||
| "@angular/core": "^20.2.4", | ||
| "@angular/platform-browser": "^20.2.4", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Angular 20.2 upgrade: double-check TypeScript support window.
Angular often pins a TS range. You have TS 5.8.3 here; ensure it’s within Angular 20.2.x supported versions to avoid ngc/CLI issues.
Also applies to: 19-19, 22-24
🌐 Web query:
What TypeScript versions are officially supported by Angular v20.2.x (framework and CLI)?
💡 Result:
Angular v20.2.x supports TypeScript >=5.9.0 and <6.0.0 (applies to the framework and CLI). [1][2]
Sources:
[1] Angular — Version compatibility (angular.dev).
[2] "What’s new in Angular 20.2?" — Ninja Squad blog.
Upgrade TypeScript to ≥5.9.0 for Angular 20.2.x
In examples/angular/auto-refetching/package.json devDependencies, bump "typescript" from ^5.8.3 to at least ^5.9.0 (Angular 20.2.x requires TS ≥5.9.0 <6.0.0).
🤖 Prompt for AI Agents
In examples/angular/auto-refetching/package.json around lines 12 to 15, the
devDependency "typescript" is still ^5.8.3 which is incompatible with Angular
20.2.x; update the "typescript" entry in devDependencies to at least "^5.9.0"
(ensure the range stays <6.0.0), save package.json and run the package manager
install to update lockfile/dependencies.
| "@angular/common": "^20.2.4", | ||
| "@angular/compiler": "^20.2.4", | ||
| "@angular/core": "^20.2.4", | ||
| "@angular/platform-browser": "^20.2.4", | ||
| "@tanstack/angular-query-experimental": "^5.87.1", | ||
| "rxjs": "^7.8.2", | ||
| "tslib": "^2.8.1", | ||
| "zone.js": "0.15.0" | ||
| "zone.js": "0.15.1" | ||
| }, | ||
| "devDependencies": { | ||
| "@angular/build": "^20.0.0", | ||
| "@angular/cli": "^20.0.0", | ||
| "@angular/compiler-cli": "^20.0.0", | ||
| "@angular/build": "^20.2.2", | ||
| "@angular/cli": "^20.2.2", | ||
| "@angular/compiler-cli": "^20.2.4", | ||
| "typescript": "5.8.3" |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Angular 20.2 + TS 5.8 combo: please verify supported TypeScript range.
Core/framework is ^20.2.4 while the workspace uses TypeScript 5.8.3. That’s likely fine, but Angular’s supported TS matrix can be strict across minors.
🌐 Web query:
Which TypeScript versions are officially supported by Angular 20.2.x (framework and CLI)?
💡 Result:
Angular 20.2.x officially supports TypeScript >=5.9.0 and <6.0.0 (framework and CLI). (angular.dev)
Citations:
Upgrade TypeScript to ≥5.9.0 <6.0.0
Angular 20.2.x officially requires TS >=5.9.0 <6.0.0; devDependencies currently specify 5.8.3—bump to at least 5.9.0 (examples/angular/infinite-query-with-max-pages/package.json) (angular.dev)
🤖 Prompt for AI Agents
In examples/angular/infinite-query-with-max-pages/package.json around lines 12
to 25 the devDependency "typescript" is pinned to 5.8.3 which is incompatible
with Angular 20.2.x; update the "typescript" version to a value in the supported
range (>=5.9.0 <6.0.0), e.g., set it to "5.9.0" or a later 5.x patch (5.9.x),
and then run npm install (or pnpm/ yarn) and verify the example builds.
| "@angular/common": "^20.2.4", | ||
| "@angular/compiler": "^20.2.4", | ||
| "@angular/core": "^20.2.4", | ||
| "@angular/platform-browser": "^20.2.4", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Angular 20.2.x with TS 5.8.3: verify supported range
Angular’s supported TypeScript ranges can be tight. Please confirm 20.2.x officially supports TS 5.8.3 used here.
🌐 Web query:
What TypeScript versions are officially supported by Angular 20.2.x (framework and CLI)?
💡 Result:
Angular 20.2.x (framework and CLI) officially supports TypeScript >= 5.9.0 and < 6.0.0. [1]
Sources
[1] Angular Version compatibility (Angular docs).
Upgrade TypeScript to ≥5.9.0 <6.0.0
Angular 20.2.x requires TypeScript versions ≥5.9.0 and <6.0.0; TS 5.8.3 is unsupported. Update your devDependencies (e.g. in examples/angular/pagination/package.json) to bump TypeScript accordingly.
🤖 Prompt for AI Agents
In examples/angular/pagination/package.json around lines 12–15 the project lists
Angular 20.2.x but still uses an unsupported TypeScript (5.8.3); update the
devDependencies TypeScript entry to a version compatible with Angular 20
(>=5.9.0 <6.0.0) such as ^5.9.0, then run npm/yarn install to refresh the
lockfile; ensure the updated version satisfies the peer range and rebuild/test
the example.
| "@angular/build": "^20.2.2", | ||
| "@angular/cli": "^20.2.2", | ||
| "@angular/compiler-cli": "^20.2.4", | ||
| "typescript": "5.8.3" |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Angular build/CLI/compiler-cli bumps: confirm CLI↔TS compatibility
Ensure @angular/cli@^20.2.2 and compiler-cli@^20.2.4 are compatible with TypeScript 5.8.3 and your tsconfig settings.
🌐 Web query:
Is TypeScript 5.8 supported by @angular/cli 20.2 and @angular/compiler-cli 20.2?
💡 Result:
Short answer: No. Angular 20.2 requires TypeScript >= 5.9 (< 6.0); TypeScript 5.8 is supported by earlier 20.0/20.1 releases but not by 20.2. [1][2]
Sources:
- Angular version compatibility table (Angular docs). [1]
- Angular (next) version compatibility table / release notes. [2]
Upgrade TypeScript to ≥5.9 <6.0 for Angular 20.2 compatibility
Change "typescript": "5.8.3" to at least "^5.9.0" (<6.0.0) in examples/angular/pagination/package.json to satisfy @angular/[email protected] and @angular/[email protected] requirements. (angular.dev)
🤖 Prompt for AI Agents
In examples/angular/pagination/package.json around lines 22 to 25, the
TypeScript version is pinned to "5.8.3" which is incompatible with
@angular/[email protected] and @angular/[email protected]; update the TypeScript
dependency to a version >=5.9 and <6.0 (e.g. "^5.9.0") to satisfy Angular 20.2
compatibility and ensure the version range is reflected in package.json
dependencies or devDependencies accordingly.
examples/vue/simple/package.json
Outdated
| "@vitejs/plugin-vue": "^5.2.4", | ||
| "typescript": "5.8.3", | ||
| "vite": "^6.2.4" | ||
| "vite": "^6.3.5" | ||
| } |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Validate Vue plugin + Vite bumps with Vue 3.4.x.
Do a quick build to ensure no plugin API changes affect the example.
🏁 Script executed:
#!/bin/bash
pnpm -w -F @tanstack/query-example-vue-simple run buildLength of output: 3239
examples/vue/simple – add missing @tanstack/vue-query-devtools dependency
The build is failing with “Failed to resolve entry for package @tanstack/vue-query-devtools.” In examples/vue/simple/package.json, under dependencies, add the matching @tanstack/vue-query-devtools version (e.g. "@tanstack/vue-query-devtools": "workspace:^") and rerun pnpm run build.
🤖 Prompt for AI Agents
In examples/vue/simple/package.json around lines 16 to 19, the build fails
because the @tanstack/vue-query-devtools dependency is missing; add an entry
under "dependencies" for "@tanstack/vue-query-devtools" with the workspace
version (for example "@tanstack/vue-query-devtools": "workspace:^") so it
matches other workspace packages, save the file and run pnpm install (or pnpm -w
install) then rerun pnpm run build.
| "@angular/build": "^20.2.2", | ||
| "@angular/cli": "^20.2.2", | ||
| "@angular/compiler-cli": "^20.2.4", | ||
| "typescript": "~5.8.2" |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
TS ~5.8.2: align with example or confirm range
This uses ~5.8.2 while the example uses 5.8.3. Optional: align to 5.8.3 for determinism, or keep ~ for patch drift—just be consistent across Angular samples.
- "typescript": "~5.8.2"
+ "typescript": "5.8.3"🌐 Web query:
Does Angular 20.2.x officially support TypeScript 5.8.x?
💡 Result:
Short answer: No — Angular 20.2.x requires TypeScript >=5.9 and does not officially support TypeScript 5.8.x. [1]
Source: Angular "Version compatibility" table. [1]
Upgrade TypeScript to >=5.9.0 for Angular 20.2.x compatibility
Angular 20.2.x requires TypeScript >=5.9.0 <6.0.0, so ~5.8.2 is unsupported. (angular.dev)
- "typescript": "~5.8.2"
+ "typescript": ">=5.9.0 <6.0.0"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@angular/build": "^20.2.2", | |
| "@angular/cli": "^20.2.2", | |
| "@angular/compiler-cli": "^20.2.4", | |
| "typescript": "~5.8.2" | |
| "@angular/build": "^20.2.2", | |
| "@angular/cli": "^20.2.2", | |
| "@angular/compiler-cli": "^20.2.4", | |
| "typescript": ">=5.9.0 <6.0.0" |
🤖 Prompt for AI Agents
integrations/angular-cli-20/package.json lines 24-27: the TypeScript version is
pinned to ~5.8.2 which is incompatible with Angular 20.2.x; update the
dependency to a TypeScript range that satisfies Angular's requirement (>=5.9.0
<6.0.0) — for example set "typescript" to "^5.9.0" (or "~5.9.0") in
package.json, then run your package manager (npm/yarn/pnpm) to reinstall and run
the project build/tests to verify compatibility.
package.json
Outdated
| @@ -5,7 +5,7 @@ | |||
| "type": "git", | |||
| "url": "https://github.com/TanStack/query.git" | |||
| }, | |||
| "packageManager": "pnpm@10.13.1", | |||
| "packageManager": "pnpm@10.15.1", | |||
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Confirm CI/dev environments support pnpm 10.15.1
Make sure GitHub Actions, local dev docs, and any version managers (.nvmrc/.node-version/Volta) align with [email protected] and its Node.js requirements.
Run:
🏁 Script executed:
#!/bin/bash
# Where do we pin Node?
fd -a '(\.nvmrc|\.node-version|package\.json|README\.md)' -HI | xargs -I {} sh -c 'echo "---- {}"; sed -n "1,120p" "{}" | rg -n "node|engines|volta|pnpm" -n || true'
# CI: check Node / pnpm setup
fd -a .github/workflows -t f | xargs -I {} sh -c 'echo "---- {}"; rg -n "setup-node|node-version|pnpm" "{}" -n || true'Length of output: 29271
🏁 Script executed:
#!/bin/bash
echo ".nvmrc content:"
sed -n '1,20p' .nvmrc
echo "CI workflows search:"
rg -nE 'setup-node|node-version|pnpm' -n .github/workflowsLength of output: 109
🏁 Script executed:
#!/bin/bash
echo ".nvmrc:"
head -n 5 .nvmrc || echo "no .nvmrc"
echo "Find .node-version:"
test -f .node-version && head -n 5 .node-version || echo "no .node-version"
echo "List CI workflow files:"
find .github/workflows -type f -maxdepth 2 -print || echo "no workflows directory"
echo "Search workflows for Node/pnpm setup:"
rg -n 'setup-node|node-version|pnpm' .github/workflows || echo "no matches"Length of output: 740
Align Node.js version and pin in CI
- .nvmrc sets Node.js v24.4.1, but pnpm@10 only officially supports Node.js 18–22 (pnpm.io); adjust .nvmrc (or use
.npmrcuse-node-version) to a supported LTS. - Add
actions/setup-node@v3with the samenode-versionin.github/workflows/ci.ymlandpr.yml. - Document the Node.js requirement in README (or add a
.node-version/Volta config) for local-dev consistency.
🤖 Prompt for AI Agents
In package.json around line 8 (the [email protected] pin) the project Node version in
.nvmrc (v24.4.1) is incompatible with pnpm@10 which officially supports Node
18–22; update .nvmrc to a supported LTS (for example 22.x) or upgrade/downgrade
the pinned pnpm to a version that supports Node 24, then add
actions/setup-node@v3 to .github/workflows/ci.yml and .github/workflows/pr.yml
with the same node-version value to enforce the runtime in CI, and document the
chosen Node requirement in README or add a .node-version / Volta config file for
local-dev consistency.
| "@vitest/coverage-istanbul": "3.2.4", | ||
| "@vitest/eslint-plugin": "^1.3.9", | ||
| "cpy-cli": "^5.0.0", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Vitest upgrades: double-check coverage + eslint integration
After bumping vitest and @vitest/coverage-istanbul, confirm coverage provider config matches (istanbul vs v8) and lint rules still detect test globals.
Run:
Also applies to: 78-79
🏁 Script executed:
#!/bin/bash
# Look for coverage provider setting
fd -a 'vitest.config.*' -t f | xargs -I {} sh -c 'echo "---- {}"; rg -n "coverage|provider" "{}" -n || true'
# Ensure ESLint knows vitest env
fd -a '.eslintrc*' -HI | xargs -I {} sh -c 'echo "---- {}"; rg -n "vitest|jest" "{}" -n || true'Length of output: 1894
Add Vitest configuration for Istanbul coverage and enable Vitest in ESLint
- No
vitest.config.*detected → Vitest will use its default (V8) provider. Create a root config (e.g.vitest.config.ts) with:import { defineConfig } from 'vitest/config' export default defineConfig({ test: { coverage: { provider: 'istanbul' } } })
- None of the existing
.eslintrc.*files declare the Vitest plugin or environment → add to your ESLint config:so test globals are recognized.extends: ['plugin:vitest/recommended'], env: { vitest: true }
🤖 Prompt for AI Agents
In package.json around lines 49 to 51, there is no Vitest project config and
ESLint is not set up for Vitest; add a root vitest.config.* (e.g.,
vitest.config.ts) that calls defineConfig and sets test.coverage.provider to
"istanbul" so the @vitest/coverage-istanbul package is used, and update your
root ESLint configuration file(s) (.eslintrc.js/.json/.ts) to extend
"plugin:vitest/recommended" and add env: { vitest: true } so Vitest globals are
recognized by the linter.
| @@ -55,7 +55,7 @@ | |||
| "devDependencies": { | |||
| "@tanstack/vue-query": "workspace:*", | |||
| "@vitejs/plugin-vue": "^5.2.4", | |||
| "eslint-plugin-vue": "^9.27.0", | |||
| "eslint-plugin-vue": "^9.33.0", | |||
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Confirm eslint-plugin-vue 9.33.0 rule changes don’t break linting.
New rules/defaults can flip errors. Please run the package lint to verify no new violations.
🏁 Script executed:
#!/bin/bash
pnpm -w -F @tanstack/vue-query-devtools run test:eslintLength of output: 484
🏁 Script executed:
#!/bin/bash
set -eux
# Install workspace dependencies first
pnpm install --frozen-lockfile
# Rerun eslint for the vue-query-devtools package
pnpm -w -F @tanstack/vue-query-devtools run test:eslintLength of output: 124908
Remove unused @ts-expect-error in vue-query’s ESLint config
In packages/vue-query/eslint.config.js (line 3), the @ts-expect-error is no longer needed and triggers TS2578. Delete or update that directive to fix the compile error, then rerun pnpm -w -F @tanstack/vue-query-devtools run test:eslint to confirm eslint-plugin-vue 9.33.0 rules don’t introduce new lint violations.
🤖 Prompt for AI Agents
In packages/vue-query/eslint.config.js around line 3, the inline
@ts-expect-error directive is no longer necessary and causes TS2578; remove that
@ts-expect-error comment (or replace it with a targeted ts-ignore/explicit
typing if genuinely required) so the file compiles cleanly, then run pnpm -w -F
@tanstack/vue-query-devtools run test:eslint to verify eslint-plugin-vue 9.33.0
doesn’t introduce new lint errors.
renovate
bot
force-pushed
the
renovate/all-minor-patch
branch
from
b611e96 to
c307bb6
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (3)
packages/vue-query-devtools/package.json (1)
58-61: eslint-plugin-vue 9.33.0 + Vite 6.3.6 — rerun lint/build to catch rule flips.Please rerun the package’s ESLint and build to ensure no new violations or bundling regressions. This echoes an earlier comment about eslint-plugin-vue upgrades across the repo.
Suggested commands:
#!/bin/bash pnpm install --frozen-lockfile pnpm -w -F @tanstack/vue-query-devtools run test:eslint pnpm -w -F @tanstack/vue-query-devtools run buildpackage.json (2)
8-8: pnpm 10.15.1 — ensure Node version alignment in local/CI.Verify the repo’s pinned Node version(s) (.nvmrc/.node-version/Volta) and CI workflows match a Node release supported by pnpm 10. If mismatched, bump Node in those places or adjust pnpm. Mirrors a prior note on this topic.
Script to surface versions:
#!/bin/bash set -euo pipefail echo "Node pins:" fd -HI '(\.nvmrc|\.node-version|package\.json)' | xargs -I {} sh -c 'echo "---- {}"; rg -n "engines|volta|node" "{}" -n || true' echo echo "Workflows Node/pnpm setup:" fd -a .github/workflows -t f | xargs -I {} sh -c 'echo "---- {}"; rg -n "setup-node|node-version|pnpm" "{}" -n || true'
49-51: Ensure Istanbul coverage is configured for @vitest/coverage-istanbul.If no vitest.config.* sets coverage.provider, Vitest defaults to v8. Add a root config to opt into Istanbul and enable ESLint’s Vitest rules. (Reiterating an earlier suggestion.)
Add files:
// vitest.config.ts import { defineConfig } from 'vitest/config' export default defineConfig({ test: { coverage: { provider: 'istanbul' } } })- "devDependencies": { + "devDependencies": { "@vitest/eslint-plugin": "^1.3.9", ... "vitest": "3.2.4" }, + "eslintConfig": { + "extends": ["plugin:vitest/recommended"], + "env": { "vitest/globals": true } + }Also applies to: 77-79
🧹 Nitpick comments (2)
integrations/react-vite/package.json (1)
11-15: Vite 6.3.6 + @vitejs/plugin-react 4.7.0 upgrade — looks fine; consider moving to devDependencies.Tooling like Vite and its plugins are typically dev-only to avoid inflating consumers’ installs. If this package isn’t published with a runtime need for them, consider relocating to devDependencies.
Proposed change:
{ "dependencies": { "@tanstack/react-query": "workspace:*", "@tanstack/react-query-devtools": "workspace:*", - "@vitejs/plugin-react": "^4.7.0", - "react": "^19.0.0", - "react-dom": "^19.0.0", - "vite": "^6.3.6" + "react": "^19.0.0", + "react-dom": "^19.0.0" }, + "devDependencies": { + "@vitejs/plugin-react": "^4.7.0", + "vite": "^6.3.6" + } }package.json (1)
1-10: Optional: declare engines to codify supported Node/pnpm.Codifies runtime expectations and helps tooling.
{ "name": "root", "private": true, + "engines": { + "node": ">=18 <25", + "pnpm": ">=10.15.0" + }, "repository": {
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.github/workflows/autofix.yml(1 hunks).github/workflows/ci.yml(1 hunks).github/workflows/pr.yml(2 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-devtools-experimental/package.json(1 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (5)
- packages/query-sync-storage-persister/package.json
- examples/vue/2.7-basic/package.json
- packages/query-core/package.json
- examples/solid/simple/package.json
- examples/vue/dependent-queries/package.json
🚧 Files skipped from review as they are similar to previous changes (72)
- integrations/react-next-15/package.json
- examples/solid/basic/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/react/basic/package.json
- examples/react/suspense/package.json
- integrations/svelte-vite/package.json
- packages/svelte-query-persist-client/package.json
- examples/vue/2.6-basic/package.json
- examples/svelte/star-wars/package.json
- packages/svelte-query-devtools/package.json
- examples/angular/simple/package.json
- packages/solid-query-devtools/package.json
- examples/angular/rxjs/package.json
- packages/query-async-storage-persister/package.json
- examples/svelte/playground/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/vue/simple/package.json
- examples/solid/astro/package.json
- packages/eslint-plugin-query/package.json
- .github/workflows/ci.yml
- examples/solid/basic-graphql-request/package.json
- examples/react/devtools-panel/package.json
- examples/react/react-router/package.json
- packages/react-query/package.json
- integrations/react-webpack-5/package.json
- packages/query-test-utils/package.json
- integrations/react-webpack-4/package.json
- examples/react/basic-graphql-request/package.json
- .github/workflows/autofix.yml
- examples/react/shadow-dom/package.json
- packages/svelte-query/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/react/eslint-legacy/package.json
- examples/vue/persister/package.json
- examples/vue/nuxt3/package.json
- examples/angular/pagination/package.json
- examples/solid/solid-start-streaming/package.json
- examples/react/default-query-function/package.json
- packages/solid-query/package.json
- packages/react-query-persist-client/package.json
- packages/react-query-next-experimental/package.json
- examples/solid/default-query-function/package.json
- integrations/solid-vite/package.json
- examples/angular/basic/package.json
- examples/vue/basic/package.json
- packages/vue-query/package.json
- examples/react/playground/package.json
- examples/svelte/simple/package.json
- packages/query-persist-client-core/package.json
- examples/angular/router/package.json
- examples/react/star-wars/package.json
- examples/react/chat/package.json
- packages/angular-query-experimental/package.json
- integrations/vue-vite/package.json
- examples/svelte/ssr/package.json
- examples/svelte/optimistic-updates/package.json
- .github/workflows/pr.yml
- examples/react/react-native/package.json
- examples/react/rick-morty/package.json
- examples/svelte/auto-refetching/package.json
- packages/angular-query-persist-client/package.json
- examples/angular/basic-persister/package.json
- examples/svelte/basic/package.json
- examples/react/algolia/package.json
- examples/angular/auto-refetching/package.json
- examples/angular/devtools-panel/package.json
- examples/react/simple/package.json
- packages/query-devtools/package.json
- packages/angular-query-devtools-experimental/package.json
- integrations/angular-cli-20/package.json
- packages/react-query-devtools/package.json
- examples/angular/optimistic-updates/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/solid-query-persist-client/package.jsonpackages/vue-query-devtools/package.jsonintegrations/react-vite/package.jsonpackage.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (3)
examples/react/offline/package.json (1)
16-25: MSW 2.11.1 and react-hot-toast 2.6.0 — quick smoke test the example.
- MSW: confirm the worker still registers with the existing "msw.workerDirectory": ["public"] config.
- react-hot-toast: verify toasts render under React 19 with no act warnings.
Commands to validate locally:
#!/bin/bash pnpm -F @tanstack/query-example-react-offline install --frozen-lockfile pnpm -F @tanstack/query-example-react-offline run dev # In the browser console: ensure MSW starts (no 404 for /mockServiceWorker.js) and UI toasts display.packages/solid-query-persist-client/package.json (1)
73-77: Dev dependency bumps align with peer ranges — LGTM.solid-js dev bump to ^1.9.9 is compatible with peer "^1.6.0"; vite-plugin-solid and npm-run-all2 minors are safe. No action needed.
package.json (1)
41-79: ESLint 9.35 + React Hooks plugin rc + Vitest 3.2 — re-run repo lint/tests.Major/minor linter/test bumps can surface new errors. Please run the affected scripts repo-wide.
#!/bin/bash pnpm install --frozen-lockfile pnpm run test:eslint pnpm run test:lib pnpm run test:types pnpm run test:build
| "@sveltejs/adapter-auto": "^6.1.0", | ||
| "@sveltejs/kit": "^2.37.1", | ||
| "@sveltejs/vite-plugin-svelte": "^5.1.1", | ||
| "svelte": "^5.36.8", | ||
| "svelte-check": "^4.3.0", | ||
| "svelte": "^5.38.7", | ||
| "svelte-check": "^4.3.1", | ||
| "typescript": "5.8.3", | ||
| "vite": "^6.2.4" | ||
| "vite": "^6.3.6" | ||
| } |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
SvelteKit 2.37.1 + Svelte 5.38.7 — run svelte-check and build.
Minor/patch bumps should be safe; please validate types and a production build.
🏁 Script executed:
#!/bin/bash
pnpm -F @tanstack/query-example-svelte-load-more-infinite-scroll install --frozen-lockfile
pnpm -F @tanstack/query-example-svelte-load-more-infinite-scroll exec svelte-check
pnpm -F @tanstack/query-example-svelte-load-more-infinite-scroll run buildLength of output: 3975
Fix SvelteKit setup and missing @tanstack/svelte-query dependency
svelte-check errored: cannot find ./.svelte-kit/tsconfig.json (you need to generate it before running type checks—e.g. run pnpm run dev or add a prepare: svelte-kit sync script).
vite build failed: cannot resolve package entry for @tanstack/svelte-query—you must install it (e.g. add "@tanstack/svelte-query" to your dependencies in examples/svelte/load-more-infinite-scroll/package.json) and verify its exports field.
🤖 Prompt for AI Agents
In examples/svelte/load-more-infinite-scroll/package.json around lines 15 to 22,
the project is missing a prepare script to generate .svelte-kit/tsconfig.json
and the @tanstack/svelte-query dependency required by the app; add a "prepare"
script that runs svelte-kit sync (so the tsconfig is generated for type checks)
and add "@tanstack/svelte-query" to the dependencies with a compatible version,
then run the package manager to install and confirm the package resolves (or pin
a version known to export correctly), and finally run the dev build to ensure
.svelte-kit is created and vite can resolve the new dependency.
c307bb6 to
2aa5b29
Compare
renovate
bot
force-pushed
the
renovate/all-minor-patch
branch
from
0ef356f to
939e8db
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
examples/react/simple/package.json (1)
16-20: Ensure consistent Node engine declarations across repository
- Only
examples/solid/solid-start-streaming/package.jsondeclares anengines.node(>=18). Add an"engines": { "node": ">=18" }field to the root and allexamples/*andintegrations/*package.jsonfiles to enforce a compatible Node version and prevent CI/local drift.- Vite is consistently pinned at
^6.3.6(with Vue 2.x examples intentionally using^4.5.14for Vue 2 compatibility), and@vitejs/plugin-reactis uniformly^4.7.0—no further alignment needed.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.github/workflows/autofix.yml(1 hunks).github/workflows/ci.yml(1 hunks).github/workflows/pr.yml(2 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-devtools-experimental/package.json(1 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- packages/svelte-query-persist-client/package.json
- packages/query-async-storage-persister/package.json
🚧 Files skipped from review as they are similar to previous changes (80)
- examples/vue/basic/package.json
- examples/react/eslint-legacy/package.json
- examples/solid/basic/package.json
- examples/solid/astro/package.json
- packages/query-persist-client-core/package.json
- examples/react/suspense/package.json
- examples/vue/2.6-basic/package.json
- packages/solid-query/package.json
- examples/react/basic-graphql-request/package.json
- integrations/react-vite/package.json
- examples/vue/dependent-queries/package.json
- .github/workflows/autofix.yml
- integrations/svelte-vite/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/svelte/star-wars/package.json
- packages/react-query-persist-client/package.json
- examples/svelte/auto-refetching/package.json
- integrations/react-webpack-5/package.json
- examples/solid/simple/package.json
- examples/react/playground/package.json
- examples/angular/devtools-panel/package.json
- examples/angular/basic/package.json
- packages/query-test-utils/package.json
- examples/angular/simple/package.json
- examples/vue/persister/package.json
- packages/solid-query-devtools/package.json
- packages/angular-query-experimental/package.json
- integrations/react-next-15/package.json
- packages/query-core/package.json
- examples/angular/pagination/package.json
- packages/react-query-next-experimental/package.json
- examples/angular/router/package.json
- packages/vue-query/package.json
- packages/query-sync-storage-persister/package.json
- examples/solid/solid-start-streaming/package.json
- examples/angular/rxjs/package.json
- .github/workflows/pr.yml
- examples/svelte/load-more-infinite-scroll/package.json
- integrations/angular-cli-20/package.json
- examples/angular/auto-refetching/package.json
- examples/react/shadow-dom/package.json
- examples/react/basic/package.json
- examples/vue/simple/package.json
- examples/svelte/simple/package.json
- integrations/react-webpack-4/package.json
- packages/angular-query-persist-client/package.json
- examples/svelte/basic/package.json
- packages/eslint-plugin-query/package.json
- packages/svelte-query-devtools/package.json
- examples/vue/2.7-basic/package.json
- examples/solid/default-query-function/package.json
- examples/solid/basic-graphql-request/package.json
- integrations/vue-vite/package.json
- packages/react-query/package.json
- packages/solid-query-persist-client/package.json
- packages/svelte-query/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- integrations/solid-vite/package.json
- packages/vue-query-devtools/package.json
- examples/react/offline/package.json
- examples/react/react-native/package.json
- examples/svelte/playground/package.json
- examples/angular/optimistic-updates/package.json
- examples/react/star-wars/package.json
- examples/react/algolia/package.json
- examples/svelte/optimistic-updates/package.json
- examples/svelte/ssr/package.json
- .github/workflows/ci.yml
- package.json
- examples/react/rick-morty/package.json
- packages/angular-query-devtools-experimental/package.json
- examples/react/chat/package.json
- examples/react/default-query-function/package.json
- packages/react-query-devtools/package.json
- examples/react/devtools-panel/package.json
- packages/query-devtools/package.json
- examples/react/react-router/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/angular/basic-persister/package.json
- examples/vue/nuxt3/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test
🔇 Additional comments (1)
examples/react/simple/package.json (1)
16-20: Vite and plugin-react bumps look goodMinor/patch updates, no config changes in this file. Should be compatible with React 19 used here.
renovate
bot
force-pushed
the
renovate/all-minor-patch
branch
from
939e8db to
5cbc635
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
.github/workflows/pr.yml (2)
25-27: actions/checkout v4.3.0 bump LGTM; optionally harden the step.Approved as-is. To reduce supply-chain risk, consider pinning to the commit SHA and disabling credential persistence since the workflow does not push.
Apply this optional hardening locally within these steps:
- uses: actions/[email protected] + uses: actions/[email protected] with: fetch-depth: 0 + persist-credentials: falseRepeat the same addition for the Preview job’s Checkout step. For SHA-pinning, replace the version tag with the exact commit SHA for v4.3.0 after verifying it in the action’s release notes.
Also applies to: 54-56
33-36: nrwl/nx-set-shas updated to v4.3.3 — confirm input compatibility and consider pinning.Looks good. Please verify that
main-branch-nameis still the correct input in v4.3.3 and that this step behaves as expected on both events configured for this workflow (pull_request and push to svelte-5-adapter). Also consider pinning to the action’s commit SHA.If you want, I can check the latest docs and surface any input changes or deprecations.
packages/angular-query-experimental/package.json (1)
83-85: Optional: cap Angular peer range to avoid silently claiming 21+ compatibility.Peers currently allow ">=16.0.0". Consider "<21.0.0" to defer 21.x until verified. Low-risk guardrail for consumers.
Example snippet (outside the changed lines):
"peerDependencies": { "@angular/common": ">=16.0.0 <21.0.0", "@angular/core": ">=16.0.0 <21.0.0" }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.github/workflows/autofix.yml(1 hunks).github/workflows/ci.yml(1 hunks).github/workflows/pr.yml(2 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-devtools-experimental/package.json(1 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- examples/svelte/playground/package.json
- packages/react-query-persist-client/package.json
- examples/solid/basic-graphql-request/package.json
🚧 Files skipped from review as they are similar to previous changes (76)
- examples/svelte/load-more-infinite-scroll/package.json
- examples/angular/simple/package.json
- packages/solid-query-devtools/package.json
- examples/solid/simple/package.json
- packages/query-core/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/angular/devtools-panel/package.json
- examples/solid/astro/package.json
- packages/react-query/package.json
- examples/react/algolia/package.json
- examples/react/chat/package.json
- integrations/react-webpack-5/package.json
- packages/angular-query-persist-client/package.json
- examples/svelte/ssr/package.json
- examples/react/rick-morty/package.json
- examples/solid/basic/package.json
- packages/query-devtools/package.json
- examples/react/default-query-function/package.json
- integrations/svelte-vite/package.json
- examples/react/eslint-legacy/package.json
- examples/vue/persister/package.json
- integrations/react-next-15/package.json
- examples/svelte/star-wars/package.json
- .github/workflows/autofix.yml
- .github/workflows/ci.yml
- examples/vue/2.6-basic/package.json
- examples/solid/solid-start-streaming/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/react/react-router/package.json
- examples/vue/simple/package.json
- examples/angular/router/package.json
- examples/react/simple/package.json
- integrations/solid-vite/package.json
- packages/eslint-plugin-query/package.json
- examples/svelte/auto-refetching/package.json
- integrations/vue-vite/package.json
- examples/vue/basic/package.json
- examples/solid/default-query-function/package.json
- packages/svelte-query-devtools/package.json
- examples/svelte/optimistic-updates/package.json
- packages/query-persist-client-core/package.json
- integrations/react-webpack-4/package.json
- packages/query-test-utils/package.json
- examples/svelte/basic/package.json
- examples/angular/basic/package.json
- examples/react/offline/package.json
- examples/react/react-native/package.json
- examples/svelte/simple/package.json
- examples/angular/optimistic-updates/package.json
- examples/angular/pagination/package.json
- packages/solid-query/package.json
- examples/angular/query-options-from-a-service/package.json
- packages/svelte-query/package.json
- packages/vue-query/package.json
- examples/react/star-wars/package.json
- examples/vue/nuxt3/package.json
- examples/angular/auto-refetching/package.json
- examples/vue/dependent-queries/package.json
- packages/query-sync-storage-persister/package.json
- packages/svelte-query-persist-client/package.json
- packages/query-async-storage-persister/package.json
- packages/react-query-next-experimental/package.json
- packages/angular-query-devtools-experimental/package.json
- examples/react/playground/package.json
- integrations/react-vite/package.json
- integrations/angular-cli-20/package.json
- packages/vue-query-devtools/package.json
- examples/react/shadow-dom/package.json
- examples/angular/rxjs/package.json
- examples/react/devtools-panel/package.json
- examples/react/basic-graphql-request/package.json
- packages/react-query-devtools/package.json
- examples/angular/basic-persister/package.json
- examples/react/suspense/package.json
- package.json
- examples/react/basic/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/angular-query-experimental/package.jsonpackages/solid-query-persist-client/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (7)
packages/solid-query-persist-client/package.json (3)
73-77: Dev dependency bumps look good and are scoped to tooling only.Upgrading npm-run-all2, solid-js, and vite-plugin-solid in devDependencies is consistent with other Solid packages and should not affect runtime/consumers. Peer range "solid-js": "^1.6.0" already covers 1.9.x.
66-68: Dependency sanity check passed. No direct imports from@tanstack/query-corefound inpackages/solid-query-persist-client/src.
73-77: All npm-run-all usages covered
Every package using thenpm-run-allCLI has thenpm-run-all2dependency declared, and there are norun-p/run-saliases in use. No changes needed.packages/angular-query-experimental/package.json (3)
66-69: Deps on query-core/devtools correctly use workspace:*This aligns with our prior learning about cross-package imports in this repo. No action needed.
76-78: Tooling bump safe: vite-plugin-dts version is uniform across packages.All instances use version 4.5.4; no drift detected.
71-74: Angular devDependencies consistency verified
All @angular/{common, core, compiler, platform-browser} devDependencies are pinned to ^20.2.4 across the monorepo.examples/vue/2.7-basic/package.json (1)
17-17: Peer & engine constraints verified; bump approved. [email protected] supports Vite ^4.0.0 and Vite 4.5.14’s Node engine (^14.18.0 || >=16.0.0) poses no conflicts; matches the 2.6-basic example.
renovate
bot
force-pushed
the
renovate/all-minor-patch
branch
from
5cbc635 to
4fd9fc6
Compare
There was a problem hiding this comment.
Actionable comments posted: 6
♻️ Duplicate comments (1)
examples/vue/simple/package.json (1)
10-14: Missing devtools dep resolved; consider workspace range for consistency.Thanks for adding @tanstack/vue-query-devtools; this should fix the previous build error. Optional: switch its version to a workspace range to match other examples.
- "@tanstack/vue-query-devtools": "^5.87.3", + "@tanstack/vue-query-devtools": "workspace:^",
🧹 Nitpick comments (9)
examples/angular/optimistic-updates/package.json (2)
20-20: zone.js 0.15.1 is fine; consider zoneless only if the example is signals‑driven.If this example is fully signals‑based and intended to be zoneless, you can drop the zone.js dependency and configure zoneless CD; otherwise keep as‑is. (angular.dev)
17-17: Optional: pin @tanstack/angular-query-experimental to avoid surprise breaks.Docs note the package is experimental and may introduce breaking changes even in minor/patch. Consider pinning to an exact version (or ~ for patch‑only) to reduce churn in examples. (tanstack.com)
- "@tanstack/angular-query-experimental": "^5.87.3", + "@tanstack/angular-query-experimental": "5.87.3",integrations/react-vite/package.json (1)
11-14: Move Vite and @vitejs/plugin-react into devDependencies
integrations/react-vite/package.json is marked"private": true, so these build-time tools should live under devDependencies (consistent with other examples)."dependencies": { "@tanstack/react-query": "workspace:*", "@tanstack/react-query-devtools": "workspace:*", - "@vitejs/plugin-react": "^4.7.0", "react": "^19.0.0", "react-dom": "^19.0.0", - "vite": "^6.3.6" }, + "devDependencies": { + "@vitejs/plugin-react": "^4.7.0", + "vite": "^6.3.6" + }examples/solid/basic-graphql-request/package.json (2)
11-12: Keep @TanStack package patch levels alignedOptional: bump @tanstack/solid-query to the same patch as devtools for consistency across examples.
- "@tanstack/solid-query": "^5.87.1", + "@tanstack/solid-query": "^5.87.3",
19-20: Declare Node engine for example (Vite 6 requires Node ≥18)Add an engines field to make the requirement explicit like other examples.
"devDependencies": { "typescript": "5.8.3", "vite": "^6.3.6", "vite-plugin-solid": "^2.11.8" - } + }, + "engines": { + "node": ">=18" + }examples/svelte/optimistic-updates/package.json (1)
15-22: Optional: declare engines to prevent local Node mismatch.Helps contributors avoid Vite 6/Kit 2 running on unsupported Node versions.
Apply in this file (or rely on root if already present):
"private": true, "type": "module", + "engines": { + "node": ">=18.18 <19 || >=20" + },packages/angular-query-persist-client/package.json (1)
60-71: Consider bounding peer ranges to avoid accidental Angular 21 installs.Peer deps currently allow ">=16.0.0". Suggest tightening to <21 to avoid unintended major upgrades by consumers.
- "peerDependencies": { - "@angular/common": ">=16.0.0", - "@angular/core": ">=16.0.0", - "@tanstack/angular-query-experimental": "workspace:^" - } + "peerDependencies": { + "@angular/common": ">=16.0.0 <21", + "@angular/core": ">=16.0.0 <21", + "@tanstack/angular-query-experimental": "workspace:^" + }examples/angular/basic-persister/package.json (2)
12-15: Add engines to guide consumers/CI.If CLI 20 requires newer Node, encode it to prevent mismatches.
{ "name": "@tanstack/query-example-angular-basic-persister", "type": "module", + "engines": { + "node": ">=20" + }, "scripts": {Also applies to: 21-21, 24-26
12-15: Optional: align TanStack package minors for the example.Example mixes @tanstack/angular-query-experimental ^5.87.3 with @tanstack/angular-query-persist-client ^5.62.7. Consider bumping persist-client to latest 5.x for consistency, unless intentionally pinned.
- "@tanstack/angular-query-persist-client": "^5.62.7", + "@tanstack/angular-query-persist-client": "^5.87.3",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.github/workflows/autofix.yml(1 hunks).github/workflows/ci.yml(1 hunks).github/workflows/pr.yml(2 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-devtools-experimental/package.json(1 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (72)
- packages/query-core/package.json
- examples/react/eslint-legacy/package.json
- packages/query-persist-client-core/package.json
- examples/react/basic/package.json
- .github/workflows/pr.yml
- examples/react/basic-graphql-request/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- packages/solid-query/package.json
- examples/svelte/auto-refetching/package.json
- examples/angular/pagination/package.json
- packages/react-query-persist-client/package.json
- examples/vue/nuxt3/package.json
- examples/react/chat/package.json
- examples/vue/persister/package.json
- examples/solid/basic/package.json
- packages/query-sync-storage-persister/package.json
- examples/react/devtools-panel/package.json
- packages/query-test-utils/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/solid/astro/package.json
- examples/react/shadow-dom/package.json
- packages/vue-query-devtools/package.json
- packages/eslint-plugin-query/package.json
- packages/svelte-query/package.json
- examples/vue/2.7-basic/package.json
- packages/angular-query-devtools-experimental/package.json
- examples/angular/basic/package.json
- packages/svelte-query-persist-client/package.json
- packages/vue-query/package.json
- packages/svelte-query-devtools/package.json
- examples/react/rick-morty/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/svelte/ssr/package.json
- packages/solid-query-persist-client/package.json
- examples/solid/default-query-function/package.json
- examples/vue/basic/package.json
- integrations/svelte-vite/package.json
- integrations/react-webpack-4/package.json
- examples/angular/router/package.json
- integrations/solid-vite/package.json
- integrations/react-webpack-5/package.json
- packages/react-query-devtools/package.json
- examples/react/playground/package.json
- packages/react-query-next-experimental/package.json
- integrations/angular-cli-20/package.json
- packages/react-query/package.json
- examples/svelte/basic/package.json
- examples/svelte/simple/package.json
- examples/react/react-native/package.json
- examples/svelte/playground/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/react/offline/package.json
- packages/query-devtools/package.json
- examples/react/react-router/package.json
- examples/angular/simple/package.json
- packages/angular-query-experimental/package.json
- examples/vue/dependent-queries/package.json
- examples/angular/rxjs/package.json
- examples/svelte/star-wars/package.json
- examples/react/star-wars/package.json
- integrations/react-next-15/package.json
- examples/react/simple/package.json
- examples/vue/2.6-basic/package.json
- .github/workflows/autofix.yml
- package.json
- .github/workflows/ci.yml
- examples/angular/devtools-panel/package.json
- examples/angular/auto-refetching/package.json
- examples/react/suspense/package.json
- examples/solid/simple/package.json
- examples/react/algolia/package.json
- packages/solid-query-devtools/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
examples/solid/basic-graphql-request/package.jsonintegrations/react-vite/package.jsonexamples/angular/basic-persister/package.jsonpackages/query-async-storage-persister/package.jsonpackages/angular-query-persist-client/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (7)
packages/query-async-storage-persister/package.json (1)
66-68: LGTM: npm-run-all2 bump is consistent across all packages Verified no packages depend on the oldnpm-run-alland every package invoking the CLI declaresnpm-run-all2@^5.0.2.examples/angular/optimistic-updates/package.json (1)
12-16: LGTM on Angular bumps; align tooling with TS update.Core/framework packages updated consistently to 20.2.4. After updating TS to 5.9.x, the set should be compatible. RxJS ^7.8.2 remains within Angular 20’s supported range. (angular.dev)
examples/solid/basic-graphql-request/package.json (1)
13-15: Peer dependency ranges are correct
[email protected] supports graphql 14–16 (satisfied by 16.11.0), [email protected] supports solid-js ^1.7.2 (satisfied by 1.9.9) and vite ^6 (included in ^3–^7), and [email protected] requires Node ≥18.0.0. No install‐time warnings expected.examples/solid/solid-start-streaming/package.json (2)
20-22: Engines field looks goodExplicit Node >=18 matches the toolchain requirements.
14-19: Peer deps OK; vinxi engine range unspecified—verify Node compatibility
The peerDependencies of @solidjs/[email protected] (vinxi ^0.5.7) and @solidjs/[email protected] (solid-js ^1.8.6) are satisfied by vinxi ^0.5.8 and solid-js 1.9.9. However, [email protected] does not declare anenginesfield in its package metadata—manually confirm it supports your Node ≥18 runtime/SSR environment.packages/angular-query-persist-client/package.json (2)
60-71: No direct ‘@tanstack/query-core’ imports found; no additional workspace dependency needed.
60-71: Bump TS matrix and verify Node.js & zone.js
- TS matrix includes 5.0–5.7 but Angular 20.2.x requires TypeScript >=5.9 <6.0—update tests/CI to at least TS 5.9 (e.g., 5.9.x and current). (angular.dev)
- Ensure CI’s Node.js version matches Angular 20.2.x supported range (^20.19.0 || ^22.12.0 || ^24.0.0). (angular.dev)
- Remind consumers that this library doesn’t declare zone.js—apps must include a zone.js version compatible with Angular 20.2.x (e.g., [email protected]). [manual verify]
| "@angular/common": "^20.2.4", | ||
| "@angular/compiler": "^20.2.4", | ||
| "@angular/core": "^20.2.4", | ||
| "@angular/platform-browser": "^20.2.4", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Angular deps/tooling bumped to 20.2.x—confirm TS/Node/Zone compatibility.
- TS is pinned to 5.8.3; ensure Angular 20.2.x supports it.
- Zone.js 0.15.1: confirm it’s the recommended version for Angular 20.2.x.
- CLI/Build 20.2.2 may require a minimum Node version; consider adding engines.
Also applies to: 21-21, 24-26
🌐 Web query:
Which TypeScript versions are supported by Angular 20.2.x, and is 5.8.3 supported?
💡 Result:
Angular 20.2.x supports TypeScript >= 5.9.0 and < 6.0.0. TypeScript 5.8.3 is below that minimum, so it is not supported for Angular 20.2.x. [1][2]
Sources:
[1] Angular version compatibility (angular.dev).
[2] “What’s new in Angular 20.2?” (Ninja Squad blog).
🌐 Web query:
What Node.js versions are supported by @angular/cli 20.2.x?
💡 Result:
@angular/cli 20.2.x supports Node.js: ^20.19.0 || ^22.12.0 || ^24.0.0. [1]
Sources:
[1] Angular Version compatibility (Angular docs).
Update TS, confirm Zone.js, and define Node engines
- TS 5.8.3 is below Angular 20.2.x’s supported range (>= 5.9.0 < 6.0.0); bump to at least 5.9.x (angular.dev)
- Zone.js 0.15.1 satisfies the peerDep “~0.15.0” in @angular/core (OK) (github.com)
- Add to examples/angular/basic-persister/package.json:
to match @angular/cli 20.2.x (Node ^20.19.0 || ^22.12.0 || ^24.0.0) (angular.dev)
"engines": { "node": ">=20.19.0 <25.0.0" }
🤖 Prompt for AI Agents
In examples/angular/basic-persister/package.json around lines 12 to 15, the
package.json needs TypeScript bumped to a supported version, confirmation of
Zone.js compatibility, and a Node engines field; update the devDependency for
typescript to at least 5.9.x (e.g., 5.9.3 or newer within <6.0.0) to meet
Angular 20.2.x requirements, ensure zone.js remains at a compatible version
(0.15.1 is acceptable so no change required), and add an "engines" block with
"node": ">=20.19.0 <25.0.0" to match Angular CLI supported Node versions.
| "@vitejs/plugin-react": "^4.7.0", | ||
| "typescript": "5.8.3", | ||
| "vite": "^6.2.4" | ||
| "vite": "^6.3.6" |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Bumps look good; confirm toolchain compatibility (Node engines).
@vitejs/plugin-react ^4.7.0 with vite ^6.3.6 is a sensible pair for React 19. Please double‑check that the repo’s Node engines satisfy Vite 6’s requirement, and that CI images match it.
Run the following to verify with public docs:
🌐 Web query:
What Node.js versions does Vite 6.3 require, and is @vitejs/plugin-react 4.7.0 compatible with Vite 6 and React 19?
💡 Result:
- Vite 6 (including 6.3) supports Node.js 18, 20 and 22+ (Node 21 dropped). (Vite 6 release notes). [1]
- @vitejs/plugin-react v4.7.0 (release notes) moved its own Node requirement to Node 20.19+ or 22.12+. It is published for the Vite 6 era, so it is compatible with Vite 6; React 19 itself is not explicitly blocked by the plugin, but you may encounter third‑party peer‑dependency conflicts (e.g., testing libs) when upgrading React. Test your full dependency tree and update any packages that have strict peer requirements. [2]
Sources:
[1] Vite 6 announcement / docs.
[2] @vitejs/plugin-react releases (v4.7.0 notes).
Update Node.js engine to ≥20.19
Vite 6.3 supports Node 18, 20 and 22+ but @vitejs/plugin-react 4.7.0 now requires Node 20.19+ (or 22.12+). Ensure the engines.node field in package.json (and your CI images) is set to at least 20.19.
🤖 Prompt for AI Agents
In examples/react/default-query-function/package.json around lines 17 to 19,
update the Node.js engine requirement to at least 20.19 to match
@vitejs/plugin-react v4.7.0: modify the "engines.node" field to ">=20.19.0" (or
">=20.19" per style) and ensure any CI workflows or Docker/base images
referenced by this project are bumped to use Node 20.19+ (or 22.12+) so installs
and builds run on a supported runtime.
| "@sveltejs/adapter-auto": "^6.1.0", | ||
| "@sveltejs/kit": "^2.37.1", | ||
| "@sveltejs/vite-plugin-svelte": "^5.1.1", | ||
| "svelte": "^5.36.8", | ||
| "svelte-check": "^4.3.0", | ||
| "svelte": "^5.38.8", | ||
| "svelte-check": "^4.3.1", | ||
| "typescript": "5.8.3", | ||
| "vite": "^6.2.4" | ||
| "vite": "^6.3.6" | ||
| } |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
LGTM on SvelteKit/Vite devDep bumps; please verify peerDeps and Node engine in CI.
- Expected compatibility: adapter-auto ^6.1.0 + kit ^2.37.x + svelte ^5.38.x + vite ^6.3.x + vite-plugin-svelte ^5.x should align, but peerDep drift can surface only at install/build time.
- Ensure CI uses Node ≥18.18 (prefer ≥20) required by Vite 6 and recent Kit.
Run to confirm no peerDep warnings and that this example builds:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Install with possible lockfile refresh for this example only
pnpm -C examples/svelte/optimistic-updates install --no-frozen-lockfile
# Check peer deps
pnpm -C examples/svelte/optimistic-updates exec npm ls @sveltejs/kit @sveltejs/adapter-auto svelte vite @sveltejs/vite-plugin-svelte
# Type check & build
pnpm -C examples/svelte/optimistic-updates exec svelte-check --fail-on-warnings
pnpm -C examples/svelte/optimistic-updates run buildLength of output: 64057
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Install only the optimistic-updates example in isolation
pnpm install --filter ./examples/svelte/optimistic-updates
# Verify installed versions and peerDeps without workspace noise
pnpm --filter ./examples/svelte/optimistic-updates ls --depth 0 @sveltejs/kit @sveltejs/adapter-auto svelte vite @sveltejs/vite-plugin-svelte
# Type check & build the example
pnpm --filter ./examples/svelte/optimistic-updates exec svelte-check --fail-on-warnings
pnpm --filter ./examples/svelte/optimistic-updates run buildLength of output: 1137
LGTM on SvelteKit/Vite devDep bumps; update CI script
- Peer dependencies align at adapter-auto ^6.1.0, kit ^2.37.x, svelte ^5.38.x, vite ^6.3.x, plugin-svelte ^5.x (no install warnings).
- svelte-check fails before .svelte-kit/tsconfig.json is generated—swap to run
buildbeforesvelte-checkin CI. - CI must use Node ≥ 18.18 (prefer ≥ 20).
🤖 Prompt for AI Agents
In examples/svelte/optimistic-updates/package.json around lines 15-22, update
CI/script behaviour to run the build step before svelte-check and declare the
Node engine requirement: change the CI script (or scripts.ci) to invoke the
project build prior to running svelte-check (e.g., run build && svelte-check) so
.svelte-kit/tsconfig.json exists, and add an "engines" entry for Node (set to at
least ">=18.18", preferably ">=20") to ensure CI uses a supported Node version.
examples/vue/simple/package.json
Outdated
| "@vitejs/plugin-vue": "^5.2.4", | ||
| "typescript": "5.8.3", | ||
| "vite": "^6.2.4" | ||
| "vite": "^6.3.6" |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Vite 6.3 + plugin-vue 5.2 upgrade: verify Node/CI and build.
Vite 6 typically requires a modern Node (≥18). Please confirm CI/local Node versions and run a quick build to catch any plugin API shifts.
🏁 Script executed:
#!/bin/bash
# Verify Node version used in CI and local env, then build this example
node -v
pnpm -v
pnpm -w -F @tanstack/query-example-vue-simple run buildLength of output: 482
🏁 Script executed:
#!/bin/bash
# Install dependencies to enable build
pnpm install --frozen-lockfile
# Confirm local Node version
node -v
# Re-run build for the Vue simple example
pnpm --filter @tanstack/query-example-vue-simple run build
# Check CI Node versions in GitHub workflows
rg -n "node-version" .github/workflowsLength of output: 3708
🏁 Script executed:
#!/bin/bash
# Display dependencies in the Vue simple example’s package.json
sed -n '1,200p' examples/vue/simple/package.jsonLength of output: 428
🏁 Script executed:
#!/bin/bash
# Locate any Vite configuration in the repository
fd --hidden --ignore-case --max-depth 5 "vite.config.*" .Length of output: 2663
🏁 Script executed:
#!/bin/bash
# Display the Vite config for the Vue simple example
sed -n '1,200p' examples/vue/simple/vite.config.tsLength of output: 199
Fix build: resolve @tanstack/vue-query entrypoint & pin Node ≥18 in CI
• examples/vue/simple/vite.config.ts: Vite is failing to resolve @tanstack/vue-query because it’s excluded from pre-bundling. Remove it from optimizeDeps.exclude so the package is properly resolved (or adjust its exports in package.json):
--- examples/vue/simple/vite.config.ts
export default defineConfig({
plugins: [vue()],
optimizeDeps: {
- exclude: ['@tanstack/vue-query', 'vue-demi'],
+ exclude: ['vue-demi'],
},
})• .github/workflows: there’s no node-version pin detected – ensure your CI is using Node 18 or newer to satisfy Vite 6’s requirements.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@vitejs/plugin-vue": "^5.2.4", | |
| "typescript": "5.8.3", | |
| "vite": "^6.2.4" | |
| "vite": "^6.3.6" | |
| // examples/vue/simple/vite.config.ts | |
| export default defineConfig({ | |
| plugins: [vue()], | |
| optimizeDeps: { | |
| exclude: ['vue-demi'], | |
| }, | |
| }) |
🤖 Prompt for AI Agents
examples/vue/simple/package.json around lines 16 to 18: Vite is failing to
resolve @tanstack/vue-query because it’s been excluded from pre-bundling and CI
isn’t pinned to Node ≥18; open examples/vue/simple/vite.config.ts and remove
"@tanstack/vue-query" from optimizeDeps.exclude (so Vite pre-bundles and
resolves its entrypoint) or alternatively adjust that package's exports, and
update your GitHub workflow files under .github/workflows to pin node-version to
18 (or a newer LTS) in the actions/setup-node step so Vite 6 runs on a
compatible Node runtime.
integrations/vue-vite/package.json
Outdated
| "@vitejs/plugin-vue": "^5.2.4", | ||
| "typescript": "5.8.3", | ||
| "vite": "^6.2.4", | ||
| "vite": "^6.3.6", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Bumped Vite/plugin-vue: build + typecheck sanity pass.
Looks good; please validate with a build and ensure vue-tsc works with TS 5.8.x.
🏁 Script executed:
#!/bin/bash
# Build the integration example
pnpm -w -F vue-vite run build
# Optional: typecheck (if vue-tsc is available in this pkg)
pnpm -w -F vue-vite exec vue-tsc --noEmit || trueLength of output: 3347
🏁 Script executed:
#!/bin/bash
# search for @tanstack/vue-query imports in the integration example
rg -n "@tanstack/vue-query" -C3 integrations/vue-vite
# inspect dependencies in package.json
jq '.dependencies' integrations/vue-vite/package.jsonLength of output: 1138
Fix broken build and missing typecheck tool in vue-vite integration
- Build error: Vite cannot resolve
@tanstack/vue-queryentry (commonjs–resolver). Ensure the Vue Query package’spackage.jsonexports (main/module/exports) point to a valid bundle, and that it’s built or prepared before runningintegrations/vue-vitebuild. - Typecheck error:
vue-tscnot found. Add the@vue/tsc(orvue-tsc) package todevDependenciesinintegrations/vue-vite/package.json, or update your typecheck command to usepnpm exec tscif you’re relying on the workspace’s TypeScript compiler.
🤖 Prompt for AI Agents
In integrations/vue-vite/package.json around lines 13–15, the project currently
relies on a workspace/common package that Vite cannot resolve and is missing a
typechecker; to fix: add @tanstack/vue-query (or the correct built bundle) to
dependencies so Vite can resolve a valid entry (or ensure the workspace package
is built/prepared before running this integration's build), and add a
devDependency for a TypeScript Vue checker (e.g., @vue/tsc or vue-tsc) or change
the typecheck script to use pnpm exec tsc so typechecking runs against the
workspace TypeScript compiler.
4fd9fc6 to
4925de9
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
examples/vue/basic/package.json (1)
16-19: Re-run Vue basic build; prior module-resolution error may persistA previous review flagged a Vite build failure resolving @tanstack/vue-query after plugin-vue bumps. Please re-smoke this example and CI Node version. If it still fails, either pin @tanstack/vue-query to a known-good patch or add a Vite alias/optimizeDeps/ssr config for it.
#!/bin/bash # Check Node setup in workflows (expect >=18) rg -nC2 -g '.github/workflows/*.yml' 'setup-node|node-version' # Quick smoke for this example pnpm -C examples/vue/basic install pnpm -C examples/vue/basic build # If resolution still fails, consider: # 1) Pin a specific @tanstack/vue-query patch version in this example # 2) OR add alias + prebundle to examples/vue/basic/vite.config.ts: cat > examples/vue/basic/vite.config.ts <<'EOF' import { defineConfig } from 'vite' import vue from '@vitejs/plugin-vue' export default defineConfig({ plugins: [vue()], // Optionally adjust only if build fails to resolve vue-query: // resolve: { alias: { '@tanstack/vue-query': '@tanstack/vue-query' } }, optimizeDeps: { include: ['@tanstack/vue-query'] }, ssr: { noExternal: ['@tanstack/vue-query'] }, }) EOF
🧹 Nitpick comments (2)
examples/vue/basic/package.json (1)
1-9: Optional: declare engines to enforce Node compat for Vite 6Helps contributors avoid local env mismatches.
{ "name": "@tanstack/query-example-vue-basic", "private": true, "type": "module", + "engines": { + "node": ">=18.0.0" + }, "scripts": {packages/angular-query-persist-client/package.json (1)
60-64: Narrow Angular peerDependencies; no query-core workspace dep needed
- Change peerDependencies in
packages/angular-query-persist-client/package.jsonfrom
">=16.0.0"
to
">=16.0.0 <21.0.0"to prevent accidental compatibility issues when Angular 21 is released.- No direct imports of
@tanstack/query-corewere found inpackages/angular-query-persist-client/src, so adding a workspace dependency for it isn’t necessary.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (81)
.github/workflows/autofix.yml(1 hunks).github/workflows/ci.yml(1 hunks).github/workflows/pr.yml(2 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-devtools-experimental/package.json(1 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- packages/query-test-utils/package.json
- examples/angular/basic/package.json
🚧 Files skipped from review as they are similar to previous changes (72)
- packages/query-persist-client-core/package.json
- packages/query-core/package.json
- packages/svelte-query/package.json
- packages/query-sync-storage-persister/package.json
- .github/workflows/ci.yml
- packages/react-query-persist-client/package.json
- integrations/react-next-15/package.json
- packages/vue-query-devtools/package.json
- integrations/solid-vite/package.json
- packages/react-query-devtools/package.json
- packages/query-async-storage-persister/package.json
- examples/svelte/star-wars/package.json
- examples/angular/devtools-panel/package.json
- examples/svelte/basic/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- integrations/svelte-vite/package.json
- examples/angular/basic-persister/package.json
- examples/react/offline/package.json
- examples/react/react-native/package.json
- examples/react/default-query-function/package.json
- examples/solid/astro/package.json
- examples/react/devtools-panel/package.json
- packages/react-query/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/vue/persister/package.json
- .github/workflows/autofix.yml
- packages/solid-query-devtools/package.json
- packages/angular-query-devtools-experimental/package.json
- integrations/vue-vite/package.json
- examples/react/algolia/package.json
- examples/react/shadow-dom/package.json
- examples/svelte/optimistic-updates/package.json
- examples/angular/rxjs/package.json
- examples/solid/simple/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/react/rick-morty/package.json
- packages/react-query-next-experimental/package.json
- packages/solid-query-persist-client/package.json
- .github/workflows/pr.yml
- examples/vue/nuxt3/package.json
- packages/solid-query/package.json
- packages/eslint-plugin-query/package.json
- integrations/react-webpack-5/package.json
- examples/react/basic-graphql-request/package.json
- examples/react/suspense/package.json
- examples/angular/simple/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/react/playground/package.json
- examples/solid/basic-graphql-request/package.json
- examples/svelte/playground/package.json
- examples/react/chat/package.json
- examples/svelte/auto-refetching/package.json
- examples/vue/simple/package.json
- examples/react/react-router/package.json
- integrations/react-webpack-4/package.json
- examples/angular/pagination/package.json
- examples/angular/optimistic-updates/package.json
- integrations/react-vite/package.json
- examples/react/basic/package.json
- packages/svelte-query-persist-client/package.json
- examples/angular/auto-refetching/package.json
- examples/svelte/simple/package.json
- examples/solid/solid-start-streaming/package.json
- integrations/angular-cli-20/package.json
- examples/angular/router/package.json
- packages/svelte-query-devtools/package.json
- examples/react/star-wars/package.json
- examples/react/simple/package.json
- examples/vue/dependent-queries/package.json
- examples/solid/basic/package.json
- package.json
- packages/query-devtools/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/vue-query/package.jsonpackages/angular-query-experimental/package.jsonpackages/angular-query-persist-client/package.jsonexamples/solid/default-query-function/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test
- GitHub Check: Preview
🔇 Additional comments (13)
examples/vue/basic/package.json (1)
16-16: LGTM: patch bump of @vitejs/plugin-vueMinor/patch within v5; expected to be compatible with Vite ^6.2 in this example.
packages/angular-query-experimental/package.json (2)
71-74: Angular 20.2 compatibility: confirm TS/Node minima and optional peer cap
Minimums for Angular 20.2: TypeScript ≥ 5.9.0 (< 6.0.0) and Node.js ^20.19.0, ^22.12.0, or ^24.0.0. Ensure your CI/test matrix excludes unsupported combos (TS < 5.9.0; Node < 20.19.0).
Optional: cap peer dependencies to<21to prevent inadvertent Angular 21 installs, e.g."peerDependencies": { "@angular/common": ">=16.0.0 <21", "@angular/core": ">=16.0.0 <21" }
76-78: Install dependencies and re-verify lint/build. Localnode_modulesis missing, so ESLint and build checks didn’t execute. Runpnpm install -rthenpnpm -F @tanstack/angular-query-experimental run test:eslint \ && pnpm -F @tanstack/angular-query-experimental run test:buildto confirm no regressions from the updated plugins.
packages/angular-query-persist-client/package.json (1)
67-70: Approve npm-run-all2 usage – npm-run-all2 is a drop-in fork that installs the same npm-run-all, run-s, and run-p binaries, so existing scripts remain valid.examples/svelte/ssr/package.json (3)
15-16: Adapter + Kit minor bumps look good.No breaking majors. Expected to be safe for the SSR example.
18-19: Svelte + svelte-check patch/minor bumps LGTM.Routine updates; no API changes expected in examples.
15-19: Double-check peer/engine compatibility for examples/svelte/ssr
- In
examples/svelte/ssr, runpnpm install --frozen-lockfile # confirm zero peer‐dependency warnings pnpm exec vite --version # should report 6.x pnpm exec svelte-kit --version # should match ^2.37.1- Node v24.3.0 (>=18/20) is already compatible.
- CI: add a job running
pnpm -C examples/svelte/ssr buildto surface any peer/engine issues early.examples/solid/default-query-function/package.json (2)
13-13: LGTM: solid-js bump to ^1.9.9Looks consistent with other Solid example packages in this PR and should be compatible with @tanstack/solid-query v5.
18-18: Confirm peer compatibility and CI Node.js version
[email protected] peer-depends on vite@^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0 and solid-js@^1.0.0—fully compatible with Vite 6.x and Solid 1.9.x. Vite 6 itself requires Node ≥18; ensure your CI runners use Node ≥18. Optional: bump this example’s Vite to ^6.3.6 to match the rest of the repo and reduce duplicate installs.packages/vue-query/package.json (2)
66-66: Install deps & rerun tests across Vue 2/2.7/3
Patch update, low risk. Catch any regressions in devtools integration by installing dependencies and running the lib test matrix across all supported Vue versions.#!/bin/bash # Install all dependencies pnpm install # Run vue-query lib tests across supported Vue versions pnpm -w --filter @tanstack/vue-query run test:lib:2 pnpm -w --filter @tanstack/vue-query run test:lib:2.7 pnpm -w --filter @tanstack/vue-query run test:lib:3 # Verify no other pinned occurrences of @vue/devtools-api rg -n --no-ignore '@vue/devtools-api' -C2
73-73: Verify ESLint core compatibility and CI lint pass
Confirm the root ESLint version meets [email protected] peerDependencies and that CI linting succeeds. Address any new diagnostics in examples/fixtures via folder-level overrides rather than disabling rules globally.examples/react/eslint-legacy/package.json (2)
23-25: LGTM: @vitejs/plugin-react bumped to ^4.7.0 is appropriate with Vite 6.4.7.0 is a stable July 18, 2025 release; staying on v4 avoids the v5 Oxc transition while remaining compatible with current Vite 6 guidance. (releasealert.dev, main.vitejs.dev)
1-36: Ensure React/@types major versions align across examples
Manual verification required: confirm that each example’s React major version matches its @types/react and @types/react-dom entries in its package.json.
renovate
bot
force-pushed
the
renovate/all-minor-patch
branch
from
4925de9 to
be1fb57
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (2)
examples/react/eslint-legacy/package.json (1)
21-22: Align @types/react with React 19*Mismatched majors (React 19 vs @types/react* 18) will cause TS JSX/ReactNode friction.
- "@types/react": "^18.2.79", - "@types/react-dom": "^18.2.25", + "@types/react": "^19.0.0", + "@types/react-dom": "^19.0.0",examples/angular/optimistic-updates/package.json (1)
22-27: Blocking: Angular 20.2.x requires TypeScript ≥5.9 <6 — pinned 5.8.3 will fail builds.Per Angular’s official compatibility table for 20.2.x: TS >=5.9.0 <6.0.0 and Node ^20.19 || ^22.12 || ^24.0 are required. Please bump TypeScript accordingly (and ensure CI Node version meets the requirement). (angular.dev)
[suggested fix]
"devDependencies": { "@angular/build": "^20.2.2", "@angular/cli": "^20.2.2", "@angular/compiler-cli": "^20.2.4", - "typescript": "5.8.3" + "typescript": "5.9.0" }Run this repo-wide check to flag Angular examples still on TS <5.9:
#!/bin/bash set -euo pipefail mapfile -t files < <(fd -t f -a 'package.json' examples/angular) pip -q install packaging >/dev/null python - "$@" <<'PY' "${files[@]}" import json, re, sys from packaging.version import Version MIN = Version("5.9.0"); MAX = Version("6.0.0") bad = [] for p in sys.argv[1:]: try: data = json.load(open(p)) except Exception: continue v = None for sect in ("devDependencies","dependencies"): tv = (data.get(sect) or {}).get("typescript") if tv: v = tv; break if not v: continue m = re.search(r'(\d+\.\d+\.\d+)', v) if not m: print(f"[WARN] {p}: unparseable TS version {v}"); continue ver = Version(m.group(1)) if not (MIN <= ver < MAX): bad.append((p, v)) print("Angular example packages with incompatible TypeScript:", len(bad)) for p, v in bad: print(f" - {p}: typescript={v} (needs >=5.9 <6.0)") PYFor completeness, verify your CI/runtime Node matches Angular 20.2’s requirement (>=20.19.x or >=22.12.x or >=24.0.0). (angular.dev)
🧹 Nitpick comments (6)
.github/workflows/pr.yml (3)
24-27: actions/checkout bump looks fine; consider pinning strategy and disabling persisted creds.
- Option A: reduce Renovate churn by following the major tag.
- Option B: pin to a commit SHA for stronger supply‑chain hardening (preferred in high‑security repos).
- Also consider not persisting the token to Git remotes unless you need to push.
Option A (fewer updates):
-uses: actions/[email protected] +uses: actions/checkout@v4Harden credentials:
with: fetch-depth: 0 + persist-credentials: false
33-36: nx-set-shas upgraded to v4.3.3 — confirm input/output compatibility.Looks correct for Renovate’s non‑major bump. Please verify that:
main-branch-nameis still the right input and no defaults changed.- Behavior remains correct on both pull_request and push events.
Optional (reduce update noise):
-uses: nrwl/[email protected] +uses: nrwl/nx-set-shas@v4
53-57: Mirror the checkout hardening in Preview job.Apply the same pinning strategy and disable persisted creds here for consistency.
-uses: actions/[email protected] +uses: actions/checkout@v4 with: fetch-depth: 0 + persist-credentials: falseexamples/svelte/auto-refetching/package.json (1)
15-19: Verify SvelteKit/Vite compatibility and Node engine in examples
- All Kit-based examples (auto-refetching, basic, load-more-infinite-scroll, optimistic-updates, playground, ssr, star-wars) use identical deps: svelte ^5.38.8, @sveltejs/kit ^2.38.0, @sveltejs/vite-plugin-svelte ^5.1.1, @sveltejs/adapter-auto ^6.1.0, vite ^6.2.4; the
simpleexample is plain Svelte.- Run
npm run devandnpm run buildin each Kit example to confirm compatibility with Vite 6.2.4.- (Optional) Add an
"engines": { "node": ">=14.18.0" }field to enforce Kit’s Node requirement.examples/svelte/simple/package.json (1)
16-18: Optional: add a type-check script for faster local validation.Helps CI and contributors catch TS/Svelte issues quickly.
You can extend scripts like:
{ "scripts": { "check": "svelte-check --tsconfig ./tsconfig.json" } }packages/svelte-query/package.json (1)
59-60: Peer range already includes Svelte 5; verify we don’t rely on 5-only APIs.If any Svelte 5–specific APIs are used, consider dropping 3/4 from the peer range to avoid misleading installs; otherwise keep as-is for broad compatibility.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (81)
.github/workflows/autofix.yml(1 hunks).github/workflows/ci.yml(1 hunks).github/workflows/pr.yml(2 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-devtools-experimental/package.json(1 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (4)
- integrations/svelte-vite/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- packages/angular-query-persist-client/package.json
- examples/vue/basic/package.json
🚧 Files skipped from review as they are similar to previous changes (68)
- packages/query-core/package.json
- packages/query-async-storage-persister/package.json
- packages/query-sync-storage-persister/package.json
- examples/angular/router/package.json
- examples/angular/basic/package.json
- examples/angular/rxjs/package.json
- examples/vue/nuxt3/package.json
- examples/vue/dependent-queries/package.json
- examples/solid/basic/package.json
- examples/react/simple/package.json
- examples/react/chat/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/angular/basic-persister/package.json
- examples/solid/solid-start-streaming/package.json
- examples/react/devtools-panel/package.json
- packages/react-query-persist-client/package.json
- examples/angular/simple/package.json
- examples/vue/simple/package.json
- packages/query-test-utils/package.json
- packages/vue-query-devtools/package.json
- examples/angular/pagination/package.json
- .github/workflows/ci.yml
- integrations/react-next-15/package.json
- .github/workflows/autofix.yml
- packages/react-query/package.json
- integrations/react-vite/package.json
- packages/svelte-query-devtools/package.json
- integrations/solid-vite/package.json
- integrations/vue-vite/package.json
- packages/solid-query-devtools/package.json
- examples/svelte/playground/package.json
- examples/react/basic/package.json
- examples/solid/default-query-function/package.json
- integrations/angular-cli-20/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/svelte/ssr/package.json
- packages/solid-query-persist-client/package.json
- packages/solid-query/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/solid/astro/package.json
- examples/vue/persister/package.json
- packages/angular-query-experimental/package.json
- examples/react/default-query-function/package.json
- packages/vue-query/package.json
- examples/svelte/basic/package.json
- examples/react/shadow-dom/package.json
- packages/query-persist-client-core/package.json
- examples/angular/devtools-panel/package.json
- examples/solid/basic-graphql-request/package.json
- examples/solid/simple/package.json
- packages/react-query-devtools/package.json
- examples/react/offline/package.json
- examples/react/react-router/package.json
- examples/svelte/optimistic-updates/package.json
- examples/angular/auto-refetching/package.json
- packages/angular-query-devtools-experimental/package.json
- examples/react/basic-graphql-request/package.json
- examples/react/react-native/package.json
- examples/react/playground/package.json
- packages/react-query-next-experimental/package.json
- packages/query-devtools/package.json
- packages/svelte-query-persist-client/package.json
- examples/svelte/star-wars/package.json
- integrations/react-webpack-5/package.json
- package.json
- examples/react/star-wars/package.json
- examples/react/rick-morty/package.json
- packages/eslint-plugin-query/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/svelte-query/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test
🔇 Additional comments (9)
examples/react/eslint-legacy/package.json (1)
23-26: Plugin React 4.7 + Vite 6.2 + TS 5.8: sanity check peersLooks good; please confirm no peer warnings and that HMR/fast‑refresh still works across the React examples.
You can verify quickly with:
- pnpm -w -r i
- pnpm -r --filter @tanstack/query-example-eslint-legacy dev
examples/react/algolia/package.json (2)
11-11: Algolia client-search 5.37.0: ESM/bundle checkMinor bump is fine; confirm the example still bundles (Vite) and no TS shape changes in search client usage.
21-24: Bump @vitejs/plugin-react to 4.7 — OKMatches other examples and Vite ^6.2.4. Proceed.
examples/react/suspense/package.json (1)
19-22: @vitejs/plugin-react 4.7 with Vite 6.2 — LGTMNo additional changes needed here.
examples/angular/optimistic-updates/package.json (2)
12-16: Angular deps bump to 20.2.4 looks good.These align across core, compiler, forms, and platform-browser. No issues spotted.
20-20: zone.js patch bump is safe.0.15.1 is compatible with Angular 20.x.
packages/svelte-query/package.json (1)
49-57: Install dependencies and verify Svelte 5 tooling consistency
Ensurenode_modulesis present inpackages/svelte-query(e.g. runpnpm installat the workspace root or within that package), then rerun:pnpm -w why svelte eslint-plugin-svelte pnpm -C packages/svelte-query run test:types pnpm -C packages/svelte-query run test:eslint pnpm -C packages/svelte-query run buildConfirm no missing or mismatched Svelte 5 packages before merging.
integrations/react-webpack-4/package.json (2)
14-17: Babel bumps are compatible with Webpack 4 (babel-loader v8 supports webpack 4/5).Upgrading to @babel/core ^7.28, presets, and babel-loader ^8.4.1 is fine for this webpack 4-based example. babel-loader 8.x explicitly supports webpack 4 or 5 (9.x would require webpack 5). (webpack.js.org, github.com)
14-17: All webpack-4 examples use babel-loader 8.x only Verified thatintegrations/react-webpack-4/package.jsonpins"babel-loader": "^8.4.1"and pnpm lockfile resolution for webpack-4 selects v8.4.1; babel-loader v9.x appears only under the webpack-5 workspace.
examples/svelte/simple/package.json
Outdated
| "@tsconfig/svelte": "^5.0.5", | ||
| "svelte": "^5.38.8", | ||
| "svelte-check": "^4.3.1", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Svelte toolchain bumps LGTM; verify peer deps and engines across the repo.
Looks consistent with Svelte 5 + Vite 6 stacks. Please double-check plugin/Vite/Node compatibility and version coherence across all Svelte examples.
Run these to verify coherence locally (read-only):
And fetch current peer/engine requirements (web):
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# 1) Ensure all Svelte examples use the same svelte/svelte-check/@tsconfig/svelte versions
fd -a package.json examples/svelte | while read -r f; do
echo "== $f"
jq -r '{
svelte: .devDependencies.svelte,
svelte_check: .devDependencies["svelte-check"],
tsconfig_svelte: .devDependencies["@tsconfig/svelte"]
}' "$f"
done | awk 'NF'
# 2) Surface potential mismatches
echo
echo "Potential mismatches:"
fd -a package.json examples/svelte | xargs jq -r '.name + " " + (.devDependencies.svelte // "none")' | sort | uniq -cLength of output: 1656
🌐 Web query:
What Node.js versions does Vite 6.2.x require, and does @sveltejs/[email protected] peer-depend on Vite 6 and Svelte 5?
💡 Result:
Short answer:
- Vite 6.x requires Node.js 18, 20, or 22+ (Node 21 was dropped). [1]
- @sveltejs/vite-plugin-svelte v5 (including 5.1.1) was updated to support Vite 6 and to target Svelte 5 — later 5.x notes explicitly require Vite 6.2 and Svelte 5.26+. [2][3]
Sources:
[1] Vite 6 announcement (Node support: 18, 20, 22+, dropped 21).
[2] @sveltejs/vite-plugin-svelte v5 release/notes (adds Vite 6 support).
[3] v5.1.0 notes / changelog mentioning the "Requires vite 6.2 and svelte 5.26" change.
Align Svelte example dependencies and engine requirements
- Add
@tsconfig/svelte: "^5.0.5"to devDependencies in everyexamples/svelte/*/package.jsonso they all matchsimple/package.json. - Ensure your package.json
enginesfield (or project documentation) specifies Node.js 18, 20, or ≥22 to satisfy Vite 6.x’s requirements. - Confirm
@sveltejs/[email protected]peer-deps on Vite 6 and Svelte ≥5.26 are met by your current Vite and Svelte versions.
🤖 Prompt for AI Agents
In examples/svelte/simple/package.json around lines 16 to 18, the project is
missing alignment with other Svelte examples and Node engine requirements: add
"@tsconfig/svelte": "^5.0.5" to devDependencies in every
examples/svelte/*/package.json to match simple/package.json; update the
package.json "engines" field (or project README) to require Node.js 18, 20, or
>=22 to satisfy Vite 6.x; verify that @sveltejs/[email protected] peer
dependencies are satisfied by ensuring Vite is upgraded to v6 and Svelte is
>=5.26 (or adjust plugin version), and if versions change, update
devDependencies accordingly and run install to confirm no peer-dep warnings.
be1fb57 to
0eeec2b
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (3)
examples/react/offline/package.json (1)
1-4: Add engines to signal Node requirement (dup of earlier suggestion).Helps prevent accidental installs on unsupported Node versions.
Apply:
{ "name": "@tanstack/query-example-react-offline", "private": true, "type": "module", + "engines": { + "node": ">=18.0.0" + },examples/angular/basic/package.json (1)
22-26: TypeScript 5.8.3 is incompatible with Angular 20.2.x; bump to 5.9.x and align compiler-cli.Angular 20.2.x requires TypeScript >=5.9.0 <6.0.0; also keep compiler-cli on the same minor (20.2.x) as core. (angular.dev)
Apply:
"@angular/build": "^20.2.2", "@angular/cli": "^20.2.2", - "@angular/compiler-cli": "^20.3.0", - "typescript": "5.8.3" + "@angular/compiler-cli": "^20.2.4", + "typescript": "^5.9.3"examples/angular/optimistic-updates/package.json (1)
26-26: Upgrade TypeScript to ≥5.9.0 (<6.0.0) in all Angular v20 examplesAll packages under examples/angular/* are pinned to TS 5.8.3 while @angular/core is ^20.3.0, which requires TS >=5.9.0 and will fail type-check/build. Update each package.json:
- "typescript": "5.8.3" + "typescript": "5.9.2"
🧹 Nitpick comments (3)
examples/solid/basic-graphql-request/package.json (1)
20-20: Specify Node engine and confirm plugin compatibility: [email protected] and [email protected] declare nopeerDependenciesorengines; verify they support Vite 6 + Solid 1.9 and add anengines.nodefield or pin the Node version in CI.examples/angular/optimistic-updates/package.json (1)
23-25: CLI/build at 20.2.2 with framework 20.3.0 — acceptable; keep at latest 20.x.20.2.2 is the latest stable CLI/build as of today; align to 20.3.x when it ships. (npmjs.com)
packages/query-devtools/package.json (1)
75-77: Potential breaking change: solid-transition-group 0.2 → 0.3 is pre-1.0 (minor may break).0.x minors can introduce breaking changes. Please verify the devtools UI still mounts/animates correctly and types align. If issues arise, pin to ^0.2.x or adapt usages.
Apply if rollback is needed:
- "solid-transition-group": "^0.3.0", + "solid-transition-group": "^0.2.3",Run these checks locally:
#!/bin/bash pnpm -w i pnpm -w -r run build pnpm -w -r run test:lib pnpm -w -r --filter @tanstack/query-devtools run test:typesAnd look up release notes:
solid-transition-group 0.3.0 release notes breaking changes
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (81)
.github/workflows/autofix.yml(1 hunks).github/workflows/ci.yml(1 hunks).github/workflows/pr.yml(2 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-devtools-experimental/package.json(1 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- integrations/react-webpack-5/package.json
- examples/vue/persister/package.json
🚧 Files skipped from review as they are similar to previous changes (74)
- packages/query-sync-storage-persister/package.json
- packages/react-query-persist-client/package.json
- examples/svelte/basic/package.json
- integrations/solid-vite/package.json
- packages/solid-query-devtools/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/solid/astro/package.json
- examples/react/shadow-dom/package.json
- examples/react/devtools-panel/package.json
- examples/react/chat/package.json
- examples/vue/simple/package.json
- examples/solid/default-query-function/package.json
- examples/solid/basic/package.json
- integrations/react-next-15/package.json
- packages/vue-query/package.json
- examples/solid/solid-start-streaming/package.json
- packages/query-persist-client-core/package.json
- packages/svelte-query/package.json
- packages/query-test-utils/package.json
- examples/react/basic-graphql-request/package.json
- examples/svelte/playground/package.json
- packages/query-async-storage-persister/package.json
- examples/svelte/optimistic-updates/package.json
- examples/svelte/star-wars/package.json
- packages/svelte-query-devtools/package.json
- examples/react/algolia/package.json
- examples/react/react-router/package.json
- packages/svelte-query-persist-client/package.json
- examples/svelte/auto-refetching/package.json
- packages/react-query-devtools/package.json
- examples/react/playground/package.json
- examples/react/react-native/package.json
- examples/solid/simple/package.json
- packages/react-query/package.json
- integrations/svelte-vite/package.json
- packages/query-core/package.json
- examples/angular/rxjs/package.json
- examples/react/simple/package.json
- examples/vue/nuxt3/package.json
- integrations/vue-vite/package.json
- examples/angular/devtools-panel/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- integrations/react-vite/package.json
- packages/vue-query-devtools/package.json
- package.json
- examples/svelte/ssr/package.json
- examples/react/eslint-legacy/package.json
- packages/angular-query-devtools-experimental/package.json
- examples/react/rick-morty/package.json
- packages/angular-query-persist-client/package.json
- packages/react-query-next-experimental/package.json
- examples/angular/simple/package.json
- .github/workflows/pr.yml
- examples/vue/dependent-queries/package.json
- examples/angular/auto-refetching/package.json
- .github/workflows/autofix.yml
- packages/solid-query/package.json
- integrations/angular-cli-20/package.json
- examples/react/star-wars/package.json
- examples/react/basic/package.json
- integrations/react-webpack-4/package.json
- examples/angular/pagination/package.json
- packages/solid-query-persist-client/package.json
- packages/angular-query-experimental/package.json
- examples/react/default-query-function/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/angular/router/package.json
- examples/svelte/simple/package.json
- examples/vue/basic/package.json
- examples/angular/basic-persister/package.json
- packages/eslint-plugin-query/package.json
- .github/workflows/ci.yml
- packages/query-broadcast-client-experimental/package.json
- examples/react/suspense/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
examples/solid/basic-graphql-request/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (7)
examples/solid/basic-graphql-request/package.json (1)
13-15: No compatibility concerns found for bumped packages
[email protected],[email protected], and[email protected]declare no peerDependencies, dependencies, or engine constraints—version bumps are safe.examples/react/offline/package.json (2)
16-16: MSW bump looks good.Minor update; no breaking config changes expected for this example.
19-19: react-hot-toast minor bump LGTM.No API changes affecting this example.
examples/angular/basic/package.json (1)
19-19: zone.js 0.15.1 bump looks good.Compatible even if not using zoneless mode.
examples/angular/optimistic-updates/package.json (2)
12-16: Angular core libs bumped to 20.3 — looks good.No issues spotted with these dependency ranges.
20-20: zone.js patch bump is fine.0.15.1 is compatible with Angular v20.
packages/query-devtools/package.json (1)
67-69: These bumps look semver-safe; proceed.Patch/minor updates for @kobalte/core and solid-primitives should be non‑breaking; no action beyond running type/typecheck CI.
| "@angular/common": "^20.3.0", | ||
| "@angular/compiler": "^20.3.0", | ||
| "@angular/core": "^20.3.0", | ||
| "@angular/platform-browser": "^20.3.0", |
There was a problem hiding this comment.
Do not bump to ^20.3.0 — not published yet; install will fail. Align to latest 20.2.x.
As of September 10, 2025, latest stable Angular core/compiler is 20.2.x; 20.3.x is not on npm. Pinning to ^20.3.0 will result in “No matching version found.” Use 20.2.x instead. (github.com, npmjs.com)
Apply:
- "@angular/common": "^20.3.0",
- "@angular/compiler": "^20.3.0",
- "@angular/core": "^20.3.0",
- "@angular/platform-browser": "^20.3.0",
+ "@angular/common": "^20.2.4",
+ "@angular/compiler": "^20.2.4",
+ "@angular/core": "^20.2.4",
+ "@angular/platform-browser": "^20.2.4",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@angular/common": "^20.3.0", | |
| "@angular/compiler": "^20.3.0", | |
| "@angular/core": "^20.3.0", | |
| "@angular/platform-browser": "^20.3.0", | |
| "@angular/common": "^20.2.4", | |
| "@angular/compiler": "^20.2.4", | |
| "@angular/core": "^20.2.4", | |
| "@angular/platform-browser": "^20.2.4", |
🤖 Prompt for AI Agents
In examples/angular/basic/package.json around lines 12 to 15, the Angular
dependencies are set to ^20.3.0 which is not published and will break installs;
change the versions for "@angular/common", "@angular/compiler", "@angular/core",
and "@angular/platform-browser" to the latest 20.2.x (e.g., ^20.2.0) so they
resolve on npm, update the package.json accordingly, then run an install
(npm/yarn) to verify dependency resolution and run the project tests/build to
confirm no regressions.
| "@vitejs/plugin-react": "^4.7.0", | ||
| "typescript": "5.8.3", | ||
| "vite": "^6.2.4" | ||
| }, |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
@vitejs/plugin-react upgrade is fine; confirm Node ≥18 and ESM config.
Vite 6 and this plugin expect Node 18+. Make sure CI/dev run Node ≥18 and there’s no legacy vite.config.cjs.
Run:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "--- Node setup in workflows"
rg -nP 'actions/setup-node' -S .github/workflows -A2 -B1 || true
rg -nP 'node-version:\s*(\[[^]]+\]|[0-9]+)' .github/workflows -n || true
echo "--- Engines hints"
rg -nP '"engines"\s*:' -n package.json examples/**/package.json || true
echo "--- Legacy CJS Vite configs"
fd -pa 'vite.config.cjs' || echo "OK: no vite.config.cjs found"Length of output: 138
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "--- find package.json files"
find . -type f -name package.json
echo
echo "--- search for engines in any package.json"
grep -R '"engines"' -n . || echo "none"
echo
echo "--- search for actions/setup-node in workflows"
grep -R "actions/setup-node" -n .github/workflows || echo "none"
echo
echo "--- search for node-version in workflows"
grep -R "node-version" -n .github/workflows || echo "none"
echo
echo "--- find vite.config.* files"
find . -type f -name "vite.config.*" || echo "none"Length of output: 6982
Enforce Node ≥18 in CI and add engines field; no CJS config found.
- .github/workflows/** contains no actions/setup-node or
node-versionhint→ addactions/setup-node@v3withnode-version: '18.x'. - examples/react/offline/package.json has no
"engines": { "node": ">=18" }→ add this to prevent installs on older Node. - No vite.config.cjs found (all configs are TS/ESM)→ no legacy‐CJS cleanup required.
🤖 Prompt for AI Agents
In examples/react/offline/package.json around lines 22 to 25, the file is
missing an "engines" field declaring Node >=18 and the repo CI lacks an explicit
Node setup; add "engines": { "node": ">=18" } to this package.json to prevent
installs on older Node, and update your GitHub workflow(s) under
.github/workflows to include actions/setup-node@v3 with node-version: '18.x'
(add or update an existing job step). No vite.config.cjs changes are required
since configs are TS/ESM.
0eeec2b to
91fa012
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (1)
examples/angular/infinite-query-with-max-pages/package.json (1)
22-25: TypeScript 5.8.3 is incompatible with Angular 20.2+ — bump to ≥5.9 <6.0.Angular 20.2.x (and later 20.x minors) require TypeScript >=5.9.0 <6.0.0; pinning 5.8.3 will break builds/IDE tooling. Recommend upgrading to a stable 5.9 patch (e.g., 5.9.2). (angular.dev)
Apply:
- "typescript": "5.8.3" + "typescript": "5.9.2"To confirm and fix across the repo, run:
#!/bin/bash # Find TS 5.8.x pins in Angular examples rg -n --glob 'examples/angular/**/package.json' '"typescript": "5\.8\.[0-9]+"' -C2Also ensure CI uses a supported Node.js (≥20.19, ≥22.12, or ≥24.0). (angular.dev)
🧹 Nitpick comments (1)
examples/react/simple/package.json (1)
16-20: Optional: consider @vitejs/plugin-react-swc for faster HMR/dev.If cold-start and HMR speed in examples is a concern, swapping to @vitejs/plugin-react-swc can reduce transform time. Not required for this PR.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (81)
.github/workflows/autofix.yml(1 hunks).github/workflows/ci.yml(1 hunks).github/workflows/pr.yml(2 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-devtools-experimental/package.json(1 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (4)
- packages/svelte-query-devtools/package.json
- packages/react-query-next-experimental/package.json
- .github/workflows/autofix.yml
- examples/react/devtools-panel/package.json
🚧 Files skipped from review as they are similar to previous changes (72)
- packages/query-core/package.json
- examples/react/shadow-dom/package.json
- integrations/svelte-vite/package.json
- examples/vue/persister/package.json
- packages/eslint-plugin-query/package.json
- examples/svelte/optimistic-updates/package.json
- packages/query-persist-client-core/package.json
- packages/svelte-query/package.json
- integrations/solid-vite/package.json
- examples/react/algolia/package.json
- examples/svelte/playground/package.json
- packages/angular-query-devtools-experimental/package.json
- examples/solid/basic/package.json
- examples/react/playground/package.json
- examples/react/suspense/package.json
- packages/react-query-persist-client/package.json
- .github/workflows/pr.yml
- integrations/react-next-15/package.json
- examples/react/default-query-function/package.json
- examples/svelte/simple/package.json
- examples/react/eslint-legacy/package.json
- examples/react/react-router/package.json
- examples/angular/router/package.json
- examples/angular/simple/package.json
- examples/react/basic-graphql-request/package.json
- examples/angular/optimistic-updates/package.json
- packages/query-broadcast-client-experimental/package.json
- packages/vue-query/package.json
- packages/query-sync-storage-persister/package.json
- packages/react-query-devtools/package.json
- examples/react/basic/package.json
- packages/solid-query-devtools/package.json
- examples/angular/basic/package.json
- examples/svelte/auto-refetching/package.json
- examples/angular/basic-persister/package.json
- integrations/react-webpack-5/package.json
- packages/vue-query-devtools/package.json
- examples/solid/default-query-function/package.json
- packages/solid-query/package.json
- packages/svelte-query-persist-client/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/svelte/ssr/package.json
- examples/solid/basic-graphql-request/package.json
- packages/query-devtools/package.json
- examples/vue/simple/package.json
- integrations/angular-cli-20/package.json
- examples/react/star-wars/package.json
- examples/solid/astro/package.json
- examples/angular/devtools-panel/package.json
- examples/vue/nuxt3/package.json
- packages/react-query/package.json
- examples/react/offline/package.json
- packages/angular-query-persist-client/package.json
- examples/vue/basic/package.json
- examples/angular/rxjs/package.json
- packages/angular-query-experimental/package.json
- packages/solid-query-persist-client/package.json
- examples/react/rick-morty/package.json
- examples/react/chat/package.json
- packages/query-async-storage-persister/package.json
- examples/angular/pagination/package.json
- examples/svelte/basic/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/angular/auto-refetching/package.json
- integrations/react-vite/package.json
- package.json
- examples/vue/dependent-queries/package.json
- .github/workflows/ci.yml
- examples/svelte/star-wars/package.json
- examples/react/react-native/package.json
- integrations/react-webpack-4/package.json
- integrations/vue-vite/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
examples/solid/simple/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test
- GitHub Check: Preview
🔇 Additional comments (5)
examples/angular/infinite-query-with-max-pages/package.json (2)
12-15: Angular core bump to 20.3.0: looks good.Matches the repo-wide upgrade pattern. RxJS ^7.8.2 is within Angular 20’s allowed ^7.4.0 range. (angular.dev)
19-19: zone.js 0.15.1: OK.Aligned with Angular 20 defaults and zoned setups.
examples/react/simple/package.json (2)
17-17: Bump to @vitejs/plugin-react ^4.7.0 looks good.No API/code changes here; safe as a dev-only tooling update for this example.
16-20: Compatibility and consistency confirmed: All React examples uniformly use @vitejs/plugin-react ^4.7.0 and Vite ^6.2.4, which are mutually compatible and support React 19 on Node 18, 20, and 22+—no changes required.examples/solid/solid-start-streaming/package.json (1)
14-19: Peer and engine constraints satisfied. @solidjs/[email protected] peer-depends on vinxi ^0.5.7 (0.5.8 is compliant); @tanstack/[email protected] peer-depends on solid-js ^1.6.0 (1.9.9 is compliant); example’s engines.node >=18 aligns with requirements.
| "solid-js": "^1.9.9" | ||
| }, | ||
| "devDependencies": { | ||
| "@tanstack/eslint-plugin-query": "^5.86.0", | ||
| "typescript": "5.8.3", | ||
| "vite": "^6.2.4", | ||
| "vite-plugin-solid": "^2.11.6" | ||
| "vite-plugin-solid": "^2.11.8" |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Confirm [email protected] supports Vite 6; consider adding engines.node.
- Ensure [email protected] declares peer support for vite ^6 (to avoid peer warnings at install/runtime).
- This example doesn’t declare an engines field; since vite "^6.2.4" typically requires Node >=18, consider adding "engines": { "node": ">=18" } for parity with other examples.
Run:
If peers look good and the build succeeds, we’re green. To add the engines field, update package.json:
{
"engines": {
"node": ">=18"
}
}🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Peers:"
npm view [email protected] peerDependencies --json
npm view [email protected] engines --json
echo "Install + typecheck/build sanity:"
pnpm -w -F @tanstack/query-example-solid-simple install
pnpm -w -F @tanstack/query-example-solid-simple run build || trueLength of output: 5074
Add engines field & fix build error
- examples/solid/simple/package.json: add
"engines": { "node": ">=18" }
- Peer deps are fine ([email protected] supports vite ^6.0.0; [email protected] requires Node≥18).
- Build fails with “Failed to resolve entry for package "@tanstack/solid-query-devtools"” — upgrade or patch that package’s main/module/exports so Vite can resolve it.
🤖 Prompt for AI Agents
In examples/solid/simple/package.json lines 13-19, add an "engines": { "node":
">=18" } entry to require Node 18+, and resolve the Vite build failure for
"@tanstack/solid-query-devtools" by upgrading that package to a version that
exposes a proper entry (main/module/exports) compatible with Vite; if upgrading
is not possible, patch the package in node_modules (or add a Vite
alias/resolution) so its package.json points to an ESM entry (or exports the
correct dist .mjs file) that Vite can resolve.
| @@ -35,6 +35,6 @@ | |||
| }, | |||
| "type": "module", | |||
| "devDependencies": { | |||
| "npm-run-all2": "^5.0.0" | |||
| "npm-run-all2": "^5.0.2" | |||
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
LGTM: bump to npm-run-all2 ^5.0.2; please sanity-check CLI alias and Node CI version.
The scripts still invoke npm-run-all (Line 31). npm-run-all2 should provide that binary, but confirm across the workspace and ensure CI uses Node ≥ 18.
Run to verify consistency and CI Node version:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "1) List all npm-run-all2 versions across packages:"
fd -H -a package.json | while read -r f; do
jq -r --arg f "$f" '
if .devDependencies and (.devDependencies["npm-run-all2"] // null) then
"\($f): \(.devDependencies["npm-run-all2"])"
else empty end' "$f"
done | sort
echo -e "\n2) Ensure no scripts call the non-existent 'npm-run-all2' CLI:"
rg -n --glob '**/package.json' 'npm-run-all2\b' || echo "OK: none found"
echo -e "\n3) Check scripts still use 'npm-run-all' or shorthands 'run-s/run-p':"
rg -n --glob '**/package.json' -e '\bnpm-run-all\b|\brun-(s|p)\b' | head -n 50
echo -e "\n4) Verify CI Node version (expect >=18):"
rg -nC2 -g '.github/workflows/**' 'setup-node|node-version|\.nvmrc'
test -f .nvmrc && { echo -n ".nvmrc -> "; cat .nvmrc; } || trueLength of output: 4995
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "1) Inspect npm-run-all2 bin mapping (should expose 'npm-run-all'):"
curl -s https://registry.npmjs.org/npm-run-all2 | jq '.versions["5.0.2"].bin'
echo -e "\n2) Inspect CI workflows for Node version:"
rg -nC2 -g ".github/workflows/*.{yml,yaml}" "setup-node" || true
rg -nC2 -g ".github/workflows/*.{yml,yaml}" "node-version" || true
echo -e "\n3) Check .nvmrc for pinned Node version:"
if [ -f .nvmrc ]; then
echo ".nvmrc -> $(cat .nvmrc)"
else
echo "no .nvmrc file"
fiLength of output: 580
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "Listing CI workflow files:"
ls .github/workflows/*.{yml,yaml} 2>/dev/null || echo "No workflow files found"
echo -e "\nInspecting Node setup in each workflow:"
for wf in .github/workflows/*.{yml,yaml}; do
[ -f "$wf" ] || continue
echo "=== $wf ==="
grep -En "setup-node|node-version|runs-on" "$wf" || echo " (no Node setup found)"
doneLength of output: 493
Pin Node version in CI workflows
CI currently runs on ubuntu-latest without an explicit Node setup—add an actions/setup-node@v3 step with node-version: '>=18' (e.g. 24.4.1 per .nvmrc) in each workflow under .github/workflows/*.yml.
🤖 Prompt for AI Agents
In packages/query-test-utils/package.json around line 38, CI workflows lack an
explicit Node setup; update each GitHub Actions workflow file under
.github/workflows/*.yml to add an actions/setup-node@v3 step before running
install/test steps and set node-version to a supported range (e.g., use
node-version: '>=18' or pin to the project .nvmrc value like '24.4.1'); ensure
the setup-node step is configured for caching/npm auth if used and placed in all
workflow job matrices that run on ubuntu-latest.
91fa012 to
3cdcdf8
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (3)
examples/solid/basic/package.json (1)
13-13: Fix build: unresolved entry for@tanstack/solid-query
Build fails with “[commonjs--resolver] Failed to resolve entry for package ‘@tanstack/solid-query’”. Ensure its package.json exports include the correct main/module paths or update the Vite resolve/commonjs plugin configuration to surface the entry point.package.json (2)
8-8: Align Node version pinning with pnpm 10.15.1 in CI and local dev.Ensure .nvmrc/.node-version and GitHub Actions use a Node version officially supported by pnpm 10, and that all places are consistent.
#!/bin/bash # Inspect Node/pnpm setup across CI and local config echo "Node version pins:"; (test -f .nvmrc && cat .nvmrc) || echo "no .nvmrc" fd -a .github/workflows -t f | xargs -I {} sh -c 'echo "---- {}"; rg -n "setup-node|node-version|pnpm" "{}" || true'
49-51: Vitest upgrades: add config for Istanbul provider and enable Vitest in ESLint (if not already).To ensure @vitest/coverage-istanbul is used and test globals are linted, add a vitest.config.* with coverage.provider='istanbul' and extend plugin:vitest/recommended with env: { vitest: true } in ESLint.
Also applies to: 77-79
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (81)
.github/workflows/autofix.yml(1 hunks).github/workflows/ci.yml(1 hunks).github/workflows/pr.yml(2 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-devtools-experimental/package.json(1 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- packages/svelte-query/package.json
- integrations/react-next-15/package.json
- .github/workflows/autofix.yml
🚧 Files skipped from review as they are similar to previous changes (75)
- examples/vue/nuxt3/package.json
- examples/react/basic/package.json
- examples/react/shadow-dom/package.json
- examples/react/eslint-legacy/package.json
- examples/svelte/optimistic-updates/package.json
- examples/react/devtools-panel/package.json
- examples/react/default-query-function/package.json
- examples/angular/basic/package.json
- integrations/vue-vite/package.json
- examples/svelte/basic/package.json
- examples/angular/optimistic-updates/package.json
- examples/angular/simple/package.json
- packages/react-query-devtools/package.json
- examples/angular/router/package.json
- packages/angular-query-persist-client/package.json
- packages/query-async-storage-persister/package.json
- examples/angular/devtools-panel/package.json
- packages/solid-query-devtools/package.json
- packages/solid-query-persist-client/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/solid/simple/package.json
- integrations/svelte-vite/package.json
- examples/vue/dependent-queries/package.json
- examples/svelte/ssr/package.json
- examples/angular/auto-refetching/package.json
- examples/svelte/playground/package.json
- examples/solid/default-query-function/package.json
- integrations/angular-cli-20/package.json
- packages/svelte-query-devtools/package.json
- examples/react/rick-morty/package.json
- examples/vue/basic/package.json
- examples/angular/query-options-from-a-service/package.json
- packages/query-test-utils/package.json
- examples/react/basic-graphql-request/package.json
- packages/solid-query/package.json
- integrations/solid-vite/package.json
- examples/react/simple/package.json
- packages/query-persist-client-core/package.json
- examples/angular/basic-persister/package.json
- examples/react/offline/package.json
- examples/react/playground/package.json
- packages/eslint-plugin-query/package.json
- examples/react/star-wars/package.json
- packages/query-core/package.json
- examples/react/algolia/package.json
- integrations/react-webpack-5/package.json
- examples/vue/simple/package.json
- examples/react/react-router/package.json
- packages/vue-query/package.json
- examples/svelte/star-wars/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/solid/astro/package.json
- integrations/react-webpack-4/package.json
- examples/angular/rxjs/package.json
- examples/react/suspense/package.json
- packages/query-sync-storage-persister/package.json
- packages/react-query-next-experimental/package.json
- packages/svelte-query-persist-client/package.json
- examples/solid/solid-start-streaming/package.json
- examples/angular/pagination/package.json
- packages/react-query/package.json
- .github/workflows/pr.yml
- .github/workflows/ci.yml
- examples/svelte/simple/package.json
- packages/query-broadcast-client-experimental/package.json
- packages/angular-query-experimental/package.json
- packages/query-devtools/package.json
- packages/vue-query-devtools/package.json
- examples/vue/persister/package.json
- packages/react-query-persist-client/package.json
- examples/svelte/auto-refetching/package.json
- examples/react/chat/package.json
- packages/angular-query-devtools-experimental/package.json
- examples/react/react-native/package.json
- integrations/react-vite/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
examples/solid/basic-graphql-request/package.jsonexamples/solid/basic/package.jsonpackage.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test
- GitHub Check: Preview
| "graphql": "^16.11.0", | ||
| "graphql-request": "^7.2.0", | ||
| "solid-js": "^1.9.9" | ||
| }, |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
GraphQL + graphql-request minors: confirm ESM/TS types and Vite build.
v7 of graphql-request is ESM; this example is ESM too, so it should be fine. Please verify the example still builds.
Also applies to: 20-20
🏁 Script executed:
#!/bin/bash
pnpm -w -F @tanstack/query-example-solid-basic-graphql-request i
pnpm -w -F @tanstack/query-example-solid-basic-graphql-request run buildLength of output: 4900
🏁 Script executed:
#!/bin/bash
rg -nP --include="*.tsx" "@tanstack/solid-query" -n examples/solid/basic-graphql-requestLength of output: 441
🏁 Script executed:
#!/bin/bash
rg -n "@tanstack/solid-query" -g "*.tsx" examples/solid/basic-graphql-request
rg -n "graphql-request" -g "*.tsx" examples/solid/basic-graphql-requestLength of output: 305
🏁 Script executed:
#!/bin/bash
sed -n '1,200p' examples/solid/basic-graphql-request/package.jsonLength of output: 513
🏁 Script executed:
#!/bin/bash
rg -n "vite\\.config" -g "*.ts" examples/solid/basic-graphql-requestLength of output: 0
🏁 Script executed:
#!/bin/bash
sed -n '1,200p' node_modules/@tanstack/solid-query/package.jsonLength of output: 90
🏁 Script executed:
#!/bin/bash
sed -n '1,200p' examples/solid/basic-graphql-request/node_modules/@tanstack/solid-query/package.jsonLength of output: 2833
Resolve Vite build error: @tanstack/solid-query entry not resolved
Vite build in examples/solid/basic-graphql-request fails with:
[commonjs--resolver] Failed to resolve entry for package "@tanstack/solid-query"
GraphQL-request ESM upgrade is fine; adjust your Vite setup (e.g. add a vite.config.js to configure resolve.exportsFields or optimizeDeps.include) or update the @tanstack/solid-query exports so this example builds successfully.
🤖 Prompt for AI Agents
In examples/solid/basic-graphql-request/package.json around lines 13–16 the Vite
build fails resolving @tanstack/solid-query; fix by adding a vite.config.js in
that example that configures Vite to treat the package as ESM and pre-bundle it:
create vite.config.js and set resolve.exportsFields or resolve.conditions to
include ESM/browser entries (so Vite picks the correct export) and add
optimizeDeps.include with "@tanstack/solid-query" (or equivalent) so Vite will
prebundle it; alternatively update the @tanstack/solid-query package exports to
expose a resolvable ESM entry for this example.
3cdcdf8 to
b1b8913
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
examples/vue/simple/package.json (1)
1-20: Pin CI Node ≥18 and remove @tanstack/vue-query from optimizeDeps
- CI: No actions/setup-node or node-version found under .github/workflows — ensure CI pins Node ≥18 (e.g., actions/setup-node node-version: '18.x').
- Vite: examples/vue/simple/vite.config.ts currently has optimizeDeps.exclude: ['@tanstack/vue-query', 'vue-demi'] — remove '@tanstack/vue-query' from the exclude list so Vite can pre-bundle it (file: examples/vue/simple/vite.config.ts, lines 6–8).
♻️ Duplicate comments (6)
examples/angular/basic/package.json (3)
25-25: Bump TypeScript to 5.9.x — required by Angular 20.2.x.Angular 20.2.x requires TypeScript >=5.9.0 <6.0.0; 5.8.3 is incompatible. (angular.dev)
- "typescript": "5.8.3" + "typescript": "^5.9.0"
12-15: Do not use ^20.3.0 — not published; pin to latest 20.2.x instead.As of September 11, 2025, the latest stable Angular core/common/compiler/platform-browser on npm is 20.2.4; 20.3.0 is not available and will cause “No matching version found.” (npmjs.com)
Apply:
- "@angular/common": "^20.3.0", - "@angular/compiler": "^20.3.0", - "@angular/core": "^20.3.0", - "@angular/platform-browser": "^20.3.0", + "@angular/common": "^20.2.4", + "@angular/compiler": "^20.2.4", + "@angular/core": "^20.2.4", + "@angular/platform-browser": "^20.2.4",
22-24: Align Angular dev tooling to published 20.2.x.Latest published: @angular/cli 20.2.2, @angular/build 20.2.2, @angular/compiler-cli 20.2.4. (npmjs.com)
- "@angular/build": "^20.3.0", - "@angular/cli": "^20.3.0", - "@angular/compiler-cli": "^20.3.0", + "@angular/build": "^20.2.2", + "@angular/cli": "^20.2.2", + "@angular/compiler-cli": "^20.2.4",examples/vue/simple/package.json (2)
10-13: Thanks for adding vue-query-devtools — resolves the prior “Failed to resolve entry” build error.
16-16: Build failed — Vite can't resolve @tanstack/vue-query; block approval.Ran the script on Node v24.3.0 / pnpm v10.15.1: install succeeded but
vite buildfor examples/vue/simple failed with "Failed to resolve entry for package '@tanstack/vue-query' (package may have incorrect main/module/exports)".Location: examples/vue/simple (examples/vue/simple/package.json — plugin change at line 16).
Action: fix the package's package.json exports/main/module or update the example imports/Vite config (or revert the plugin bump) and re-run the build.
examples/react/default-query-function/package.json (1)
16-20: Same engines consideration as other React examples (Node ≥20.19 or ≥22.12).This package has the same
@vitejs/plugin-react@^4.7.0bump. Ensure Node runtime/CI meets the plugin’s requirement; consider adding anengines.nodefield here or enforcing it at the repo root. (vite.dev)(Optional) Patch:
{ "name": "@tanstack/query-example-react-default-query-function", "private": true, "type": "module", + "engines": { + "node": ">=20.19 <21 || >=22.12" + }, "scripts": { "dev": "vite", "build": "vite build", "preview": "vite preview" },
🧹 Nitpick comments (2)
examples/vue/simple/package.json (2)
10-14: Consider using workspace protocol for local TanStack deps.If this example is intended to link local workspace packages during dev, prefer workspace:^ to avoid pulling from the registry.
"dependencies": { - "@tanstack/vue-query": "^5.87.4", - "@tanstack/vue-query-devtools": "^5.87.4", + "@tanstack/vue-query": "workspace:^", + "@tanstack/vue-query-devtools": "workspace:^", "vue": "^3.4.27" },
1-20: Optional: declare Node engine for Vite 6.Helps CI and editors surface a clear requirement.
{ "name": "@tanstack/query-example-vue-simple", "private": true, "type": "module", + "engines": { + "node": ">=18.0.0" + }, "scripts": { "dev": "vite", "build": "vite build", "preview": "vite preview" },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (81)
.github/workflows/autofix.yml(1 hunks).github/workflows/ci.yml(1 hunks).github/workflows/pr.yml(2 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-devtools-experimental/package.json(1 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- examples/react/suspense/package.json
- packages/svelte-query-persist-client/package.json
🚧 Files skipped from review as they are similar to previous changes (74)
- integrations/react-next-15/package.json
- examples/vue/dependent-queries/package.json
- packages/solid-query-persist-client/package.json
- .github/workflows/autofix.yml
- examples/angular/pagination/package.json
- packages/angular-query-experimental/package.json
- examples/react/eslint-legacy/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/react/devtools-panel/package.json
- examples/solid/basic/package.json
- integrations/react-webpack-5/package.json
- packages/vue-query-devtools/package.json
- examples/angular/simple/package.json
- packages/svelte-query/package.json
- examples/react/offline/package.json
- examples/solid/default-query-function/package.json
- examples/solid/basic-graphql-request/package.json
- packages/query-persist-client-core/package.json
- examples/solid/simple/package.json
- packages/query-sync-storage-persister/package.json
- examples/react/basic/package.json
- examples/react/playground/package.json
- packages/react-query-persist-client/package.json
- examples/solid/solid-start-streaming/package.json
- packages/react-query/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- packages/query-test-utils/package.json
- examples/vue/nuxt3/package.json
- .github/workflows/ci.yml
- examples/angular/optimistic-updates/package.json
- packages/angular-query-persist-client/package.json
- examples/react/algolia/package.json
- examples/react/shadow-dom/package.json
- examples/svelte/simple/package.json
- examples/angular/basic-persister/package.json
- examples/vue/persister/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/svelte/basic/package.json
- examples/solid/astro/package.json
- packages/react-query-next-experimental/package.json
- packages/angular-query-devtools-experimental/package.json
- examples/angular/auto-refetching/package.json
- packages/eslint-plugin-query/package.json
- packages/query-devtools/package.json
- examples/svelte/playground/package.json
- examples/angular/devtools-panel/package.json
- integrations/svelte-vite/package.json
- integrations/solid-vite/package.json
- packages/solid-query-devtools/package.json
- examples/angular/router/package.json
- examples/svelte/auto-refetching/package.json
- examples/react/react-native/package.json
- packages/vue-query/package.json
- packages/solid-query/package.json
- packages/svelte-query-devtools/package.json
- examples/react/react-router/package.json
- examples/react/rick-morty/package.json
- packages/query-async-storage-persister/package.json
- integrations/angular-cli-20/package.json
- packages/react-query-devtools/package.json
- examples/react/basic-graphql-request/package.json
- examples/angular/rxjs/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/svelte/optimistic-updates/package.json
- .github/workflows/pr.yml
- examples/svelte/ssr/package.json
- examples/react/chat/package.json
- examples/react/star-wars/package.json
- integrations/vue-vite/package.json
- package.json
- integrations/react-vite/package.json
- examples/svelte/star-wars/package.json
- integrations/react-webpack-4/package.json
- examples/vue/basic/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/query-core/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (3)
packages/query-core/package.json (1)
63-63: Approve — npm-run-all2 replacement validated.All packages (including packages/query-core) declare npm-run-all2 (^5.0.2) and no package scripts reference npm-run-all; no action required.
examples/angular/basic/package.json (1)
19-19: LGTM on zone.js.No change requested here.
examples/react/simple/package.json (1)
16-20: Add engines.node or confirm CI uses Node ≥20.19 / ≥22.12@vitejs/plugin-react@^4.7.0 requires Node >=20.19 or >=22.12. (phillipring.com)
- examples/react/simple/package.json currently uses "@vitejs/plugin-react": "^4.7.0" and has no "engines" field — add an engines constraint (diff below).
- Repo .nvmrc pins Node 24.4.1 (root) — local devs using it are already compatible.
- .github workflows call tanstack/config/.github/setup@main (no explicit actions/setup-node or node-version) — verify that the shared setup supplies Node >=20.19/22.12 or pin the CI runner / add engines to prevent accidental installs on unsupported Node versions.
Apply this minimal engines constraint (optional but recommended):
{ "name": "@tanstack/query-example-react-simple", "private": true, "type": "module", + "engines": { + "node": ">=20.19 <21 || >=22.12" + }, "scripts": { "dev": "vite", "build": "vite build", "preview": "vite preview" },
renovate
bot
force-pushed
the
renovate/all-minor-patch
branch
from
b1b8913 to
066f6aa
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (6)
integrations/vue-vite/package.json (1)
13-13: Plugin bump looks fine; please re-run build + typecheck to guard against regressions.@vitejs/plugin-vue ^5.2.4 should be compatible with Vite ^6.2 and Vue 3.4. Reconfirm the integration builds and types still pass, and that the prior @tanstack/vue-query resolution issue doesn’t reappear.
#!/bin/bash pnpm -w -F vue-vite run build pnpm -w -F vue-vite exec vue-tsc --noEmitexamples/solid/basic-graphql-request/package.json (1)
13-16: Verify Vite can resolve @tanstack/solid-query after deps bumps.graphql-request 7.x is ESM; ensure Vite still resolves @tanstack/solid-query correctly for this example. If it fails, add a minimal vite.config to include the package in optimizeDeps and ensure ESM conditions.
#!/bin/bash pnpm -w -F @tanstack/query-example-solid-basic-graphql-request i pnpm -w -F @tanstack/query-example-solid-basic-graphql-request run buildIf resolution errors persist, add a vite.config.ts like:
import { defineConfig } from 'vite' import solid from 'vite-plugin-solid' export default defineConfig({ plugins: [solid()], optimizeDeps: { include: ['@tanstack/solid-query'] }, })Also applies to: 20-21
examples/angular/query-options-from-a-service/package.json (1)
12-16: Align TypeScript with Angular 20.3.x (upgrade to 5.9.x).Same TS constraint issue here; update to 5.9.x for compatibility.
"devDependencies": { "@angular/build": "^20.3.1", "@angular/cli": "^20.3.1", "@angular/compiler-cli": "^20.3.0", - "typescript": "5.8.3" + "typescript": "5.9.3" }Also applies to: 20-20, 23-26
package.json (2)
8-8: pnpm 10.15.1 vs Node 24: align runtime to avoid CI/local breaks.pnpm@10 officially targets Node 18–22. If the repo uses Node 24 (e.g., via .nvmrc), either use Node 22.x LTS or move to a pnpm version that supports Node 24, and pin the same Node in CI.
#!/bin/bash # Show pinned Node versions and CI setup test -f .nvmrc && echo "---- .nvmrc" && cat .nvmrc || echo "no .nvmrc" rg -n "setup-node|node-version|pnpm" .github/workflows -n
49-51: Add Vitest config (Istanbul) and enable Vitest env in ESLint.You bumped Vitest and @vitest/coverage-istanbul; add a root vitest.config.ts and enable Vitest linting so coverage and globals work as intended.
// vitest.config.ts import { defineConfig } from 'vitest/config' export default defineConfig({ test: { coverage: { provider: 'istanbul' } }, })Add to ESLint config:
// .eslintrc.{js,cjs,ts} module.exports = { extends: ['plugin:vitest/recommended'], env: { vitest: true }, }Also applies to: 78-79
integrations/angular-cli-20/package.json (1)
24-28: Fix: TypeScript 5.8.x is incompatible with Angular 20.3.xAngular 20.2.x+ requires TypeScript >=5.9 <6.0. Bumping Angular to ^20.3.0 while keeping TS at ~5.8.2 will fail builds/
ngcommands. Update TS to a 5.9.x range. (angular.dev)Apply:
- "typescript": "~5.8.2" + "typescript": "^5.9.0"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (81)
.github/workflows/autofix.yml(1 hunks).github/workflows/ci.yml(1 hunks).github/workflows/pr.yml(2 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-devtools-experimental/package.json(1 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- packages/query-core/package.json
- integrations/react-next-15/package.json
- examples/svelte/star-wars/package.json
🚧 Files skipped from review as they are similar to previous changes (69)
- examples/react/shadow-dom/package.json
- integrations/svelte-vite/package.json
- packages/svelte-query-persist-client/package.json
- packages/vue-query/package.json
- examples/react/devtools-panel/package.json
- examples/vue/basic/package.json
- packages/svelte-query/package.json
- examples/angular/router/package.json
- packages/query-persist-client-core/package.json
- examples/vue/persister/package.json
- examples/react/eslint-legacy/package.json
- .github/workflows/autofix.yml
- .github/workflows/ci.yml
- examples/react/suspense/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- packages/angular-query-devtools-experimental/package.json
- examples/svelte/basic/package.json
- examples/vue/simple/package.json
- examples/solid/basic/package.json
- examples/solid/solid-start-streaming/package.json
- examples/vue/dependent-queries/package.json
- examples/svelte/optimistic-updates/package.json
- packages/react-query-persist-client/package.json
- packages/react-query-devtools/package.json
- packages/query-sync-storage-persister/package.json
- examples/react/playground/package.json
- examples/angular/auto-refetching/package.json
- examples/react/default-query-function/package.json
- examples/svelte/auto-refetching/package.json
- examples/svelte/playground/package.json
- packages/query-devtools/package.json
- packages/solid-query/package.json
- examples/react/chat/package.json
- integrations/react-webpack-5/package.json
- packages/query-async-storage-persister/package.json
- examples/solid/default-query-function/package.json
- examples/angular/basic/package.json
- examples/react/react-router/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/react/react-native/package.json
- packages/angular-query-persist-client/package.json
- examples/solid/simple/package.json
- packages/solid-query-devtools/package.json
- examples/react/simple/package.json
- integrations/solid-vite/package.json
- examples/react/basic-graphql-request/package.json
- examples/svelte/ssr/package.json
- examples/angular/pagination/package.json
- examples/react/algolia/package.json
- examples/angular/simple/package.json
- examples/react/basic/package.json
- packages/vue-query-devtools/package.json
- examples/react/star-wars/package.json
- examples/solid/astro/package.json
- .github/workflows/pr.yml
- packages/query-test-utils/package.json
- examples/react/offline/package.json
- packages/react-query/package.json
- packages/angular-query-experimental/package.json
- integrations/react-webpack-4/package.json
- examples/react/rick-morty/package.json
- examples/svelte/simple/package.json
- packages/react-query-next-experimental/package.json
- examples/angular/devtools-panel/package.json
- examples/angular/optimistic-updates/package.json
- examples/vue/nuxt3/package.json
- packages/svelte-query-devtools/package.json
- examples/angular/basic-persister/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/solid-query-persist-client/package.jsonintegrations/react-vite/package.jsonexamples/solid/basic-graphql-request/package.jsonpackage.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (5)
packages/solid-query-persist-client/package.json (1)
73-77: Dev dep bumps LGTM — tests couldn't be executed in sandbox (missing tooling)
Sandbox run failed to execute test:types and test:build: nx, publint, attw and node_modules are missing. Run: pnpm install && pnpm -w -F @tanstack/solid-query-persist-client run test:types && pnpm -w -F @tanstack/solid-query-persist-client run test:buildpackages/eslint-plugin-query/package.json (1)
62-62: Run rule/type/build tests locally — sandbox missing node_modules/CLIs@typescript-eslint v8.43.0 with ESLint ^9.35.0 matches the peer range. Automated verification failed: node_modules and required CLIs (eslint, nx, vitest, npm-run-all, publint) were not found in the sandbox. Run locally after installing deps:
pnpm -w install && pnpm -w -F @tanstack/eslint-plugin-query run test:eslint && pnpm -w -F @tanstack/eslint-plugin-query run test:lib && pnpm -w -F @tanstack/eslint-plugin-query run test:types && pnpm -w -F @tanstack/eslint-plugin-query run test:build
integrations/react-vite/package.json (1)
11-11: Unable to verify — sandbox missing node_modules and Vite/NX; run local build to confirm @vitejs/plugin-react ^4.7.0 with Vite ^6.2 and React 19Attempted:
pnpm -w -F react-vite run build— failed with: "sh: 1: vite: not found", "sh: 1: nx: not found", and "Local package.json exists, but node_modules missing".
Run locally:pnpm install && pnpm -w -F react-vite run buildand verify JSX transform + HMR; include build logs if it fails.integrations/angular-cli-20/package.json (2)
12-21: LGTM: coherent Angular 20.3.x dep setThe @angular/*, rxjs ~7.8.2, zone.js ~0.15.1, and tslib ^2.8 align for Angular 20; compiler/cli/build patch skew is fine. After the TS bump, this block looks good. (angular.dev)
Also applies to: 24-26
1-9: Optional: enforce supported Node.js versionsAdd the engines block below. Node v24.3.0 (verified) satisfies >=24.0.0 <25 and devDependency typescript is "~5.8.2". Angular CLI check failed (npx error: "Unknown arguments: ng, version") — re-run with: npx -y -p @angular/cli@20 ng version.
{ "name": "angular-cli-20", "version": "0.0.0", + "engines": { + "node": ">=20.19.0 <21 || >=22.12.0 <23 || >=24.0.0 <25" + }, "scripts": {Also applies to: 24-28
| "@angular/common": "^20.3.0", | ||
| "@angular/compiler": "^20.3.0", | ||
| "@angular/core": "^20.3.0", | ||
| "@angular/forms": "^20.3.0", | ||
| "@angular/platform-browser": "^20.3.0", |
There was a problem hiding this comment.
TypeScript 5.8.3 is incompatible with Angular 20.3.x — bump to 5.9.x.
Angular 20.3.x requires TS >=5.9.0. Pin to a 5.9.x to avoid build errors.
"devDependencies": {
"@angular/build": "^20.3.1",
"@angular/cli": "^20.3.1",
"@angular/compiler-cli": "^20.3.0",
- "typescript": "5.8.3"
+ "typescript": "5.9.3"
}Also applies to: 20-20, 23-26
🤖 Prompt for AI Agents
In examples/angular/rxjs/package.json around lines 12 to 16, TypeScript is
pinned to an incompatible 5.8.3 for Angular 20.3.x; update the TypeScript
devDependency to a 5.9.x range (e.g., "^5.9.0") in package.json (and the other
affected Angular example packages noted: 20-20 and 23-26), then run your package
manager to update lockfiles so builds use TS >=5.9.0.
066f6aa to
a03905c
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (4)
examples/react/suspense/package.json (1)
19-19: Mirror Node engines update for plugin-react.Add engines and verify build:
"devDependencies": { "@vitejs/plugin-react": "^4.7.0", "typescript": "5.8.3", "vite": "^6.2.4" }, + "engines": { + "node": ">=20.19" + }#!/bin/bash pnpm -w -F @tanstack/query-example-react-suspense run buildexamples/react/default-query-function/package.json (1)
17-17: Ensure Node >=20.19 for @vitejs/plugin-react 4.7.0 across examples/CI.Proposed addition:
"devDependencies": { "@vitejs/plugin-react": "^4.7.0", "typescript": "5.8.3", "vite": "^6.2.4" }, + "engines": { + "node": ">=20.19" + }Repo-wide check:
#!/bin/bash fd package.json examples/react | xargs -I{} jq -r '.name + " engines: " + ( .engines.node // "none")' {}package.json (2)
8-8: Pinning [email protected]—ensure Node/tooling alignment in CI and local devPast feedback still applies: verify your Node version in .nvmrc/CI matches pnpm’s supported range and that workflows actually install this pnpm version.
Run:
#!/bin/bash echo "Node version pins:" test -f .nvmrc && echo ".nvmrc:" && cat .nvmrc || echo "no .nvmrc" test -f .node-version && echo ".node-version:" && cat .node-version || echo "no .node-version" echo echo "Workflows Node/pnpm setup:" fd -a .github/workflows -t f | xargs -I {} sh -c 'echo "---- {}"; rg -n "setup-node|node-version|pnpm|corepack" "{}" -n || true'
49-51: Vitest upgrades—set coverage provider and enable ESLint envAdd explicit Istanbul provider and Vitest ESLint env so deps you just bumped are actually used.
+// vitest.config.ts +import { defineConfig } from 'vitest/config' +export default defineConfig({ + test: { coverage: { provider: 'istanbul' } } +})Update ESLint (root flat config) to include:
+ extends: ['plugin:vitest/recommended'], + env: { vitest: true }Also applies to: 78-79
🧹 Nitpick comments (1)
examples/vue/simple/package.json (1)
16-16: plugin-vue bump looks safe; prior devtools/resolve issues appear addressed.No action required. Optional: add engines.node ">=18" to examples for Vite 6 consistency — Vite 6 targets Node 18+. (vite.dev) (examples/solid/solid-start-streaming already sets engines.node '>=18').
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (81)
.github/workflows/autofix.yml(1 hunks).github/workflows/ci.yml(1 hunks).github/workflows/pr.yml(2 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-devtools-experimental/package.json(1 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- integrations/react-vite/package.json
🚧 Files skipped from review as they are similar to previous changes (70)
- examples/vue/nuxt3/package.json
- integrations/react-next-15/package.json
- examples/vue/persister/package.json
- examples/react/devtools-panel/package.json
- .github/workflows/ci.yml
- examples/react/simple/package.json
- examples/react/shadow-dom/package.json
- examples/solid/solid-start-streaming/package.json
- examples/vue/basic/package.json
- packages/query-sync-storage-persister/package.json
- examples/svelte/ssr/package.json
- packages/solid-query-persist-client/package.json
- packages/query-persist-client-core/package.json
- examples/solid/basic-graphql-request/package.json
- packages/vue-query-devtools/package.json
- packages/query-broadcast-client-experimental/package.json
- packages/vue-query/package.json
- packages/svelte-query/package.json
- integrations/react-webpack-4/package.json
- examples/angular/basic/package.json
- examples/react/playground/package.json
- examples/react/star-wars/package.json
- examples/svelte/star-wars/package.json
- examples/react/basic-graphql-request/package.json
- examples/solid/default-query-function/package.json
- examples/react/react-router/package.json
- examples/svelte/auto-refetching/package.json
- examples/angular/router/package.json
- packages/query-core/package.json
- examples/svelte/optimistic-updates/package.json
- packages/react-query-next-experimental/package.json
- examples/angular/optimistic-updates/package.json
- examples/react/offline/package.json
- examples/react/rick-morty/package.json
- examples/angular/devtools-panel/package.json
- integrations/vue-vite/package.json
- integrations/angular-cli-20/package.json
- integrations/svelte-vite/package.json
- examples/solid/basic/package.json
- examples/svelte/basic/package.json
- packages/solid-query-devtools/package.json
- packages/react-query-devtools/package.json
- packages/angular-query-persist-client/package.json
- examples/angular/query-options-from-a-service/package.json
- integrations/solid-vite/package.json
- integrations/react-webpack-5/package.json
- .github/workflows/autofix.yml
- packages/angular-query-devtools-experimental/package.json
- packages/eslint-plugin-query/package.json
- examples/solid/simple/package.json
- examples/react/react-native/package.json
- packages/react-query/package.json
- examples/solid/astro/package.json
- examples/react/chat/package.json
- examples/react/algolia/package.json
- examples/vue/dependent-queries/package.json
- packages/query-async-storage-persister/package.json
- examples/svelte/playground/package.json
- packages/query-devtools/package.json
- examples/angular/basic-persister/package.json
- packages/angular-query-experimental/package.json
- examples/angular/rxjs/package.json
- examples/angular/simple/package.json
- packages/svelte-query-persist-client/package.json
- examples/react/eslint-legacy/package.json
- examples/angular/auto-refetching/package.json
- packages/query-test-utils/package.json
- .github/workflows/pr.yml
- examples/angular/infinite-query-with-max-pages/package.json
- packages/react-query-persist-client/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/svelte-query-devtools/package.jsonpackages/solid-query/package.jsonpackage.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (9)
packages/solid-query/package.json (1)
72-78: Dev tool bumps look good; peer range remains compatible — sandbox build failed, run verification locally/CI.
- solid-js devDependency bumped to ^1.9.9 while peer is ^1.6.0 — acceptable; ensure no ≥1.9-only APIs are used in source.
- @tanstack/query-core workspace dependency is present.
- Sandbox build failed: "publint: not found", "nx: not found", "tsc: not found"; node_modules missing. Run locally/CI:
pnpm -w -F @tanstack/solid-query run test:build && pnpm -w -F @tanstack/solid-query run compile — report any peer warnings.examples/svelte/simple/package.json (1)
16-18: Svelte toolchain bumps LGTM — pin Node engine for the Svelte exampleAdd "engines": { "node": ">=18" } to examples/svelte/simple/package.json to avoid Vite 6 runtime mismatches in CI. Repo .nvmrc = 24.4.1 and examples/solid/... already pins engines; workflows use tanstack/config/.github/setup@main (no explicit actions/setup-node) — either add the engines entry or confirm the shared CI setup enforces Node >=18.
examples/react/basic/package.json (1)
23-23: @vitejs/plugin-react ^4.7.0 may require newer Node — align engines/CI.Sandbox verification failed (missing node_modules; vite & nx not found). Confirm @vitejs/plugin-react’s minimum Node version and add an engines field to examples/react/basic/package.json and a matching setup-node step in CI.
"devDependencies": { "@tanstack/eslint-plugin-query": "^5.86.0", "@types/react": "^18.2.79", "@types/react-dom": "^18.2.25", "@vitejs/plugin-react": "^4.7.0", "typescript": "5.8.3", "vite": "^6.2.4" }, + "engines": { + "node": ">=20.19" + }packages/svelte-query-devtools/package.json (1)
45-53: Run local build — sandbox couldn't verifySandbox run failed: missing dev tooling (publint, nx, tsc) and node_modules. Svelte toolchain bumps aligned; peer range already spans v5 — LGTM. Run local build and confirm compiled outputs and package exports.
Local commands to run:
pnpm install
pnpm -w -F @tanstack/svelte-query-devtools run test:build
pnpm -w -F @tanstack/svelte-query-devtools run compileexamples/svelte/load-more-infinite-scroll/package.json (1)
15-19: Add a prepare script and install deps so svelte-check/build can run.
- Verification failed: node_modules missing;
svelte-checkandvitenot found when running the checks/build.- Action: in examples/svelte/load-more-infinite-scroll/package.json add under "scripts": "prepare": "svelte-kit sync" (do not use "scriptsExtra"); run pnpm install (or npm/yarn) and re-run svelte-check/build. Optional: add a "pnpm.onlyBuiltDependencies": ["@esbuild/*"] for pnpm workspaces.
package.json (2)
69-77: TS matrix aliases look goodAdding typescript50–57 keeps the multi-TS test matrix intact. No action.
105-106: React 19 types overrides—LGTMPinning @types/react/dom to ^19.x via overrides prevents mismatches across workspaces.
examples/angular/pagination/package.json (2)
12-20: Angular deps/zone.js versions—LGTMFramework and zone.js versions are consistent for 20.3.x.
21-25: Sweep Angular examples for TypeScript pinned to 5.8.3Search examples/angular/**/package.json for any "typescript" entries set to 5.8.3 and update them to the intended TypeScript version (or loosen to a range). Automated scan failed with "Permission denied" on examples/angular/auto-refetching/package.json — fix permissions or run the scan locally and commit the fixes.
| "@angular/common": "^20.3.0", | ||
| "@angular/compiler": "^20.3.0", | ||
| "@angular/core": "^20.3.0", | ||
| "@angular/platform-browser": "^20.3.0", |
There was a problem hiding this comment.
TypeScript 5.8.3 is incompatible with Angular 20.3.x—bump to ≥5.9 <6.0
Angular 20.3 requires TS >=5.9,<6.0. Update the example’s TS to avoid install/build failures.
- "typescript": "5.8.3"
+ "typescript": "^5.9.0"Also applies to: 22-25, 25-25
🤖 Prompt for AI Agents
In examples/angular/pagination/package.json around lines 12-15 (and also update
occurrences at lines 22-25 and 25), the project currently allows TypeScript
5.8.3 which is incompatible with Angular 20.3.x; change the TypeScript version
in package.json devDependencies to a version that satisfies Angular's
requirement (>=5.9 <6.0), e.g., update the typescript entry to "^5.9.0" (or
">=5.9 <6.0") and run install to verify builds succeed.
a03905c to
a6c3f73
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
♻️ Duplicate comments (1)
examples/vue/nuxt3/package.json (1)
13-14: Add engines.node to match Nuxt 3.19.x requirementsNuxt 3.19.x raises the Node floor; add an engines field so CI/users don’t run incompatible Node versions.
Apply this patch:
"devDependencies": { "nuxt": "^3.19.1" - } + }, + "engines": { + "node": "^20.19.0 || >=22.12.0" + }Verify locally:
#!/bin/bash set -euo pipefail echo "== Latest 3.19.x Nuxt engines ==" curl -s https://registry.npmjs.org/nuxt | jq -r '.versions | to_entries[] | select(.key|startswith("3.19.")) | "\(.key): engines.node=\(.value.engines.node // "N/A")"' | sort -V | tail -n 1 echo -e "\n== engines in examples/vue/nuxt3/package.json ==" jq -r '.engines.node // "MISSING"' examples/vue/nuxt3/package.json echo -e "\n== @tanstack/vue-query peer deps (latest) ==" curl -s https://registry.npmjs.org/@tanstack/vue-query | jq -r '.["dist-tags"].latest as $v | "@tanstack/vue-query@" + $v + " peers=" + (.versions[$v].peerDependencies|tostring)' echo -e "\n== Vue version Nuxt depends on (3.19.1) ==" curl -s https://registry.npmjs.org/nuxt | jq -r '.versions["3.19.1"].dependencies.vue // "unknown"'
🧹 Nitpick comments (3)
.github/workflows/pr.yml (3)
54-57: Pin actions/checkout to v4.3.0 commit SHA and disable persisted credentialsFile: .github/workflows/pr.yml Lines: 54-57
- uses: actions/[email protected] + uses: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955 with: fetch-depth: 0 + persist-credentials: false
33-36: Pin nrwl/nx-set-shas to its v4.3.3 commit SHAv4.3.3 commit SHA: 826660b82addbef3abff5fa871492ebad618c9e1 (no newer v4.x).
File: .github/workflows/pr.yml Lines: 33-36
- uses: nrwl/[email protected] + uses: nrwl/nx-set-shas@826660b82addbef3abff5fa871492ebad618c9e1 with: main-branch-name: main
25-27: Harden checkout: pin actions/checkout to the v4.3.0 commit and disable token persistencePin to commit 08eba0b (v4.3.0) and add persist-credentials: false. Note: v5.0.0 was released 2025-08-11 (no newer v4.*).
- uses: actions/[email protected] + uses: actions/checkout@08eba0b with: fetch-depth: 0 + persist-credentials: false
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (81)
.github/workflows/autofix.yml(1 hunks).github/workflows/ci.yml(1 hunks).github/workflows/pr.yml(2 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-devtools-experimental/package.json(1 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- examples/react/suspense/package.json
- packages/query-test-utils/package.json
- examples/svelte/auto-refetching/package.json
🚧 Files skipped from review as they are similar to previous changes (72)
- examples/solid/simple/package.json
- integrations/svelte-vite/package.json
- examples/svelte/simple/package.json
- .github/workflows/autofix.yml
- examples/svelte/playground/package.json
- examples/angular/basic/package.json
- examples/react/chat/package.json
- examples/angular/pagination/package.json
- .github/workflows/ci.yml
- examples/svelte/star-wars/package.json
- packages/query-sync-storage-persister/package.json
- packages/svelte-query/package.json
- examples/react/devtools-panel/package.json
- packages/solid-query-devtools/package.json
- packages/solid-query-persist-client/package.json
- examples/react/star-wars/package.json
- integrations/react-webpack-5/package.json
- packages/eslint-plugin-query/package.json
- examples/angular/router/package.json
- examples/react/rick-morty/package.json
- examples/svelte/ssr/package.json
- examples/angular/simple/package.json
- packages/react-query-persist-client/package.json
- examples/angular/auto-refetching/package.json
- examples/solid/default-query-function/package.json
- examples/vue/simple/package.json
- examples/solid/solid-start-streaming/package.json
- examples/react/default-query-function/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/angular/basic-persister/package.json
- packages/vue-query/package.json
- packages/angular-query-devtools-experimental/package.json
- examples/angular/rxjs/package.json
- packages/query-core/package.json
- examples/react/offline/package.json
- examples/svelte/optimistic-updates/package.json
- packages/react-query-next-experimental/package.json
- integrations/solid-vite/package.json
- examples/react/eslint-legacy/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- packages/svelte-query-devtools/package.json
- examples/svelte/basic/package.json
- examples/solid/basic/package.json
- examples/angular/devtools-panel/package.json
- examples/react/react-router/package.json
- packages/angular-query-experimental/package.json
- integrations/react-webpack-4/package.json
- examples/solid/astro/package.json
- integrations/react-next-15/package.json
- examples/vue/dependent-queries/package.json
- examples/angular/optimistic-updates/package.json
- examples/react/shadow-dom/package.json
- examples/react/simple/package.json
- examples/vue/basic/package.json
- examples/react/playground/package.json
- examples/vue/persister/package.json
- packages/react-query-devtools/package.json
- packages/query-async-storage-persister/package.json
- package.json
- packages/svelte-query-persist-client/package.json
- packages/query-devtools/package.json
- examples/solid/basic-graphql-request/package.json
- examples/react/algolia/package.json
- packages/vue-query-devtools/package.json
- packages/react-query/package.json
- examples/react/basic/package.json
- integrations/angular-cli-20/package.json
- integrations/react-vite/package.json
- examples/react/react-native/package.json
- packages/solid-query/package.json
- examples/angular/infinite-query-with-max-pages/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
packages/query-persist-client-core/package.jsonpackages/angular-query-persist-client/package.jsonexamples/react/basic-graphql-request/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (3)
packages/query-persist-client-core/package.json (1)
65-67: Confirm npm-run-all2 provides the npm-run-all binary
- Verified: npm-run-all2's registry "bin" includes "npm-run-all" -> "bin/npm-run-all/index.js" and "npm-run-all2" -> "bin/npm-run-all/index.js" (drop-in).
- Repo search failed here ("**/package.json: No such file or directory"). Action: confirm scripts invoke "npm-run-all" (not a global install) and that CI installs devDependencies. Location: packages/query-persist-client-core/package.json (devDependency "npm-run-all2": "^5.0.2").
integrations/vue-vite/package.json (1)
13-13: Sanity-check required: run build + typecheck for @vitejs/plugin-vue ^5.2.4Sandbox verification failed — vite, nx, and vue-tsc not found (node_modules missing). Run locally or in CI:
pnpm install pnpm -w -F vue-vite run build pnpm -w -F vue-vite exec vue-tsc --noEmit pnpm -w -F vue-vite why vite @vitejs/plugin-vue vueAdd CI convenience scripts in integrations/vue-vite/package.json:
"scripts": { "build": "vite build", "typecheck": "vue-tsc --noEmit" }packages/angular-query-persist-client/package.json (1)
67-70: Testing libraries bumped — run test suite; verify peer compatibility with Angular 20.
- Verified: no direct imports from @tanstack/query-core; packages/angular-query-persist-client/package.json lists "@tanstack/query-persist-client-core": "workspace:*".
- Action: run the full test suite and confirm no peer warnings or runtime incompatibilities for @testing-library/[email protected], @testing-library/[email protected], jsdom, Vitest, and Angular 20.
| "@angular/animations": "^20.3.0", | ||
| "@angular/common": "^20.3.0", | ||
| "@angular/compiler": "^20.3.0", | ||
| "@angular/core": "^20.3.0", | ||
| "@angular/platform-browser": "^20.3.0", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Angular 20.3 devDeps bump — looks good; verify CI/node/TS compatibility.
- LGTM for local testing baseline. Peer ranges (>=16.0.0) already cover 20.x.
- Please confirm CI runs on a Node version supported by Angular 20.x and that your TS matrix covers Angular’s supported TS versions.
To double-check quickly:
🏁 Script executed:
#!/bin/bash
# Show Node/TS used in CI and local config
fd -a .github/workflows -e yml -e yaml | xargs -I{} sh -c 'echo "---- {}"; rg -n "node-version|setup-node|typescript" -N {} || true'
echo "---- root package.json engines:"
cat package.json | jq -r '.engines // {}'
echo "---- repo TypeScript packages present:"
fd -a node_modules -d 2 -g "typescript*/package.json" | xargs -I{} sh -c 'echo {}; cat {} | jq -r ".name, .version"'Length of output: 559
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "---- Searching workflows for Node/TS settings"
if [ -d .github/workflows ]; then
for f in .github/workflows/*.{yml,yaml}; do
[ -e "$f" ] || continue
echo "---- $f"
rg -n --hidden --no-ignore -n "actions/setup-node|setup-node@|node-version|matrix:|runs-on:|strategy:|typescript|tsc" --pretty "$f" || true
echo
done
else
echo "No .github/workflows directory"
fi
echo "---- Root package.json (engines + TypeScript fields)"
if [ -f package.json ]; then
jq '{name: .name, engines: .engines, dependencies: .dependencies, devDependencies: .devDependencies | {typescript: .typescript}}' package.json || cat package.json
else
echo "No root package.json found"
fi
echo "---- packages/angular-query-persist-client/package.json (relevant fields)"
if [ -f packages/angular-query-persist-client/package.json ]; then
jq '{name: .name, version: .version, dependencies: .dependencies, peerDependencies: .peerDependencies, devDependencies: .devDependencies}' packages/angular-query-persist-client/package.json
else
echo "packages/angular-query-persist-client/package.json not found"
fi
echo "---- TypeScript across all package.json files (name, version, dep/dev ts)"
find . -name package.json -not -path "*/node_modules/*" -print0 | while IFS= read -r -d '' file; do
echo "== $file"
jq -r '"name: \(.name // "-")\nversion: \(.version // "-")\ndependencies.typescript: \(.dependencies.typescript // "-")\ndevDependencies.typescript: \(.devDependencies.typescript // "-")\n"' "$file" || true
done
echo "---- Node version helper files (nvmrc/.node-version/.tool-versions)"
for f in .nvmrc .node-version .tool-versions; do
if [ -f "$f" ]; then
echo "---- $f"
sed -n '1,200p' "$f"
fi
doneLength of output: 16516
Action required — bump TypeScript to >=5.9 and pin Node in CI for Angular ^20.3.0
- Root devDependency typescript = 5.8.3 (package.json) — Angular 20.2/20.3 require TypeScript >=5.9.0; bump root/devDependencies to >=5.9.0 (or constrain Angular devDeps to 20.0/20.1). (angular.dev)
- .nvmrc = 24.4.1 (compatible), but CI workflows run on ubuntu-latest and do not pin Node — update .github/workflows to use actions/setup-node and pin Node to ^20.19.0, ^22.12.0, or ^24.0.0 to guarantee CI compatibility. (Files: packages/angular-query-persist-client/package.json, package.json, .nvmrc, .github/workflows/*)
🤖 Prompt for AI Agents
In packages/angular-query-persist-client/package.json around lines 60 to 64,
Angular deps are at ^20.3.0 which requires TypeScript >=5.9 and CI Node pinning;
update the root package.json devDependency "typescript" to a compatible version
(bump to ^5.9.0 or later), ensure any package-level devDependencies referencing
typescript are consistent, update .nvmrc only if you want to change the local
pinned node (current 24.4.1 is fine), and modify all GitHub workflow files
(.github/workflows/*) to use actions/setup-node and pin Node versions to a
supported range (e.g. ^20.19.0, ^22.12.0, or ^24.0.0) so CI runs with a
compatible Node for Angular 20.3.0.
a6c3f73 to
ee7e0e7
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (6)
examples/angular/pagination/package.json (1)
25-25: TypeScript 5.8.3 is incompatible with Angular 20.3.x—bump to ≥5.9 <6.0.Angular v20.2+ requires TypeScript >=5.9.0 and <6.0.0; leaving 5.8.3 will cause install/build issues. (angular.dev)
- "typescript": "5.8.3" + "typescript": "^5.9.0"packages/angular-query-persist-client/package.json (1)
60-64: Angular 20.3 devDeps bump — verify Node/TypeScript support; pin CI and extend TS matrix if neededUpgrading to ^20.3.0 can raise minimum Node/TS requirements. Ensure CI pins a supported Node and that your "current" TS and type-test matrix cover the supported TS range (add ts58/ts59 targets if required).
Run:
#!/bin/bash set -euo pipefail echo "---- Root TypeScript version" jq -r '.devDependencies.typescript // "-"' package.json echo "---- TypeScript matrix tasks present in this package" jq -r '.scripts | to_entries[] | select(.key|test("^test:types:")) | .key' packages/angular-query-persist-client/package.json echo "---- Workflows Node versions / setup-node usage" fd -a .github/workflows -e yml -e yaml | xargs -I{} sh -c 'echo "----- {}"; rg -n "actions/setup-node|node-version" {} || true'integrations/vue-vite/package.json (1)
8-11: Ensure the workspace package is built before building this integration.
@tanstack/vue-query": "workspace:*"can fail to resolve if the workspace hasn’t been built. Either build the workspace first or wire a prebuild here.#!/bin/bash set -euo pipefail # Build workspace libs (at minimum vue-query) before the integration pnpm -w -r --filter @tanstack/vue-query... build || true # Now build the integration pnpm -w -F vue-vite run buildOptional inline wiring:
"scripts": { + "prebuild": "pnpm -w -r --filter @tanstack/vue-query... build", "typecheck": "vue-tsc --noEmit", "build": "vite build" },examples/solid/simple/package.json (2)
13-13: Verify devtools resolution with Vite 6 + Solid 1.9.9.Previous build failed resolving "@tanstack/solid-query-devtools". Recheck with current bumps; if it still fails, upgrade devtools or add a Vite alias/export patch.
Run:
#!/bin/bash set -euo pipefail pnpm -w -F @tanstack/query-example-solid-simple install pnpm -w -F @tanstack/query-example-solid-simple build
19-19: Add engines.node >=18 for parity and to match Vite 6 requirements.Other Solid examples already declare it; add here to avoid surprises on older Node.
"devDependencies": { "@tanstack/eslint-plugin-query": "^5.86.0", "typescript": "5.8.3", "vite": "^6.2.4", "vite-plugin-solid": "^2.11.8" - } + }, + "engines": { + "node": ">=18" + }examples/react/algolia/package.json (1)
19-20: Align React type packages with React 19Type defs are still on v18; upgrade to v19 to avoid JSX/FC typing drift.
- "@types/react": "^18.2.79", - "@types/react-dom": "^18.2.25", + "@types/react": "^19.0.0", + "@types/react-dom": "^19.0.0",
🧹 Nitpick comments (6)
examples/angular/pagination/package.json (2)
19-19: Prefer a caret range for zone.js unless pinning is intentional.Allow patch updates to flow automatically.
Apply this diff if acceptable:
- "zone.js": "0.15.1" + "zone.js": "^0.15.1"
22-24: Align compiler-cli to the same patch as CLI/build for parity.Not required, but it reduces chance of subtle tooling mismatch.
- "@angular/compiler-cli": "^20.3.0", + "@angular/compiler-cli": "^20.3.1",.github/workflows/pr.yml (2)
33-36: Pin nrwl/nx-set-shas by SHA (same rationale as above)Version bump looks fine; fetch-depth: 0 is already set before this step. Pinning to a commit SHA will align with your other pinned actions.
- - name: Get base and head commits for `nx affected` - uses: nrwl/[email protected] + - name: Get base and head commits for `nx affected` + uses: nrwl/nx-set-shas@<SHA_FOR_V4_3_3> with: main-branch-name: main
25-28: Pin actions/checkout to commit SHA and disable persisted Git credsApply to .github/workflows/pr.yml (lines 25–28 and 54–57). Use the resolved SHAs and set persist-credentials: false.
- - name: Checkout - uses: actions/[email protected] + - name: Checkout + uses: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955 with: fetch-depth: 0 + persist-credentials: false- - name: Checkout - uses: actions/[email protected] + - name: Checkout + uses: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955 with: fetch-depth: 0 + persist-credentials: falseResolved SHAs: actions/checkout v4.3.0 -> 08eba0b27e820071cde6df949e0beb9ba4906955; nrwl/nx-set-shas v4.3.3 -> 1859e66a83ac9be0dceecbd9a023702e27ac47f4.
integrations/vue-vite/package.json (1)
5-7: Add a “typecheck” script for CI ergonomics.Keeps parity with other examples and makes the verification step explicit.
"scripts": { - "build": "vite build" + "typecheck": "vue-tsc --noEmit", + "build": "vite build" },packages/eslint-plugin-query/package.json (1)
68-68: ESLint 9.35.0 devDep is compatible with declared peer range; consider asserting dual-compat in CI.Peer range is "^8.57.0 || ^9.0.0", but the repo develops against v9. To avoid regressions for ESLint 8 users, ensure at least one CI job runs tests against ESLint 8.x—or, if v8 support is no longer intended, narrow the peer range accordingly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (81)
.github/workflows/autofix.yml(1 hunks).github/workflows/ci.yml(1 hunks).github/workflows/pr.yml(2 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-devtools-experimental/package.json(1 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (4)
- packages/query-sync-storage-persister/package.json
- examples/angular/basic/package.json
- packages/query-persist-client-core/package.json
- integrations/react-vite/package.json
🚧 Files skipped from review as they are similar to previous changes (66)
- examples/react/basic/package.json
- packages/react-query-persist-client/package.json
- examples/react/default-query-function/package.json
- integrations/svelte-vite/package.json
- integrations/solid-vite/package.json
- examples/react/devtools-panel/package.json
- examples/svelte/playground/package.json
- packages/vue-query-devtools/package.json
- examples/react/simple/package.json
- packages/solid-query-devtools/package.json
- examples/svelte/basic/package.json
- packages/solid-query/package.json
- examples/vue/nuxt3/package.json
- examples/angular/router/package.json
- examples/angular/devtools-panel/package.json
- packages/react-query-next-experimental/package.json
- examples/solid/default-query-function/package.json
- packages/svelte-query-devtools/package.json
- examples/react/eslint-legacy/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- integrations/react-webpack-5/package.json
- examples/angular/optimistic-updates/package.json
- packages/query-async-storage-persister/package.json
- examples/react/shadow-dom/package.json
- examples/svelte/ssr/package.json
- examples/react/star-wars/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/svelte/simple/package.json
- .github/workflows/autofix.yml
- packages/react-query-devtools/package.json
- examples/vue/persister/package.json
- .github/workflows/ci.yml
- packages/angular-query-devtools-experimental/package.json
- packages/react-query/package.json
- examples/solid/basic/package.json
- examples/solid/astro/package.json
- examples/angular/basic-persister/package.json
- examples/vue/dependent-queries/package.json
- examples/angular/auto-refetching/package.json
- packages/svelte-query/package.json
- examples/angular/rxjs/package.json
- examples/react/react-router/package.json
- packages/solid-query-persist-client/package.json
- examples/angular/simple/package.json
- examples/vue/basic/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/react/offline/package.json
- packages/query-core/package.json
- packages/svelte-query-persist-client/package.json
- packages/angular-query-experimental/package.json
- examples/svelte/star-wars/package.json
- examples/react/rick-morty/package.json
- integrations/react-next-15/package.json
- integrations/angular-cli-20/package.json
- examples/react/playground/package.json
- examples/svelte/auto-refetching/package.json
- packages/query-test-utils/package.json
- packages/query-devtools/package.json
- examples/solid/basic-graphql-request/package.json
- integrations/react-webpack-4/package.json
- examples/svelte/optimistic-updates/package.json
- examples/react/react-native/package.json
- examples/vue/simple/package.json
- package.json
- packages/vue-query/package.json
- examples/angular/infinite-query-with-max-pages/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
examples/react/basic-graphql-request/package.jsonexamples/solid/simple/package.jsonpackages/angular-query-persist-client/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Test
- GitHub Check: Preview
🔇 Additional comments (13)
examples/angular/pagination/package.json (1)
12-15: Angular core bumps look good.Upgrading to ^20.3.0 across core packages is consistent.
packages/angular-query-persist-client/package.json (1)
67-71: Verify test runner compatibility: @testing-library/angular ^17.4 + Angular 20.3 + zone.jsAutomated search returned no package.json/test-setup matches; confirm the following in every package that runs Angular tests (e.g., packages/angular-query-persist-client/package.json):
- Ensure a compatible zone.js is installed (commonly ^0.15.x) in dependencies/devDependencies and that the test setup imports "zone.js/testing" (test.ts / setup-jest.ts or equivalent).
- Validate @testing-library/angular ^17.4.0 is compatible with your Angular 20.3 and TypeScript versions.
integrations/vue-vite/package.json (1)
13-16: LGTM on the plugin bump — peers compatible; local build/typecheck required.npm shows @vitejs/[email protected] peerDependencies: vue '^3.2.25', vite '^5.0.0 || ^6.0.0' — this satisfies the repo's vite ^6.2.4 and vue ^3.4.27. Sandbox couldn't run build/typecheck (node_modules missing; 'vite' and 'nx' not found). Run locally: pnpm -w -F vue-vite install && pnpm -w -F vue-vite run build && pnpm -w -F vue-vite exec vue-tsc --noEmit and paste any failures.
packages/eslint-plugin-query/package.json (3)
62-62: @typescript-eslint/utils bump looks good; versions stay in lockstep with the rest.Matches the v8.43.0 line with parser/rule-tester below. No issues spotted.
69-69: Patch bump for npm-run-all2 is safe.No breaking changes expected here.
65-66: Keep @typescript-eslint packages in strict sync and validate TS 5.0–5.7 matrixFile: packages/eslint-plugin-query/package.json (lines 65–66)
v8.43.0 for both parser and rule-tester is consistent. Sandbox verification failed (node_modules missing; npm-run-all, nx, vitest not found). Re-run the TS 5.0–5.7 matrix locally or in CI and confirm tests pass:
pnpm install
pnpm -w --filter @tanstack/eslint-plugin-query run test:types
pnpm -w --filter @tanstack/eslint-plugin-query run test:libAttach CI logs or test output.
examples/solid/solid-start-streaming/package.json (1)
14-14: LGTM on @solidjs/start 1.2 bump.Looks compatible with vinxi 0.5.8; proceed.
examples/react/suspense/package.json (1)
19-21: Approve — @vitejs/[email protected] is compatible with Vite 6; ensure CI uses Node ^18 || ^20 || >=22.
Confirmed: plugin peerDependencies include Vite ^6; [email protected] engines.node = ^18.0.0 || ^20.0.0 || >=22.0.0. Observed Node: v24.3.0.examples/react/basic-graphql-request/package.json (2)
13-14: [email protected] ↛ [email protected] — peer range mismatchexamples/react/basic-graphql-request/package.json sets "graphql": "^16.11.0", but [email protected] declares peerDependency "graphql": "14 - 16" (interpreted as >=14.0.0 <=16.0.0); 16.11.0 is >16.0.0 and therefore outside that range.
Likely an incorrect or invalid review comment.
19-21: Ensure CI/dev use Node >=18 (Vite 6 requires Node >=18)[email protected] is compatible with Vite 6; [email protected] declares engines.node "^18.0.0 || ^20.0.0 || >=22.0.0" — set CI and local dev Node to >=18. File: examples/react/basic-graphql-request/package.json (lines 19–21)
examples/react/chat/package.json (1)
17-19: Ensure Vite >=5.2 or pin a compatible @tailwindcss/viteexamples/react/chat/package.json (lines 17–19): @tailwindcss/[email protected] peer: vite ^5.2.0 || ^6 || ^7; @vitejs/[email protected] peer: vite ^4.2.0 || ^5 || ^6 || ^7; [email protected] has no "engines" (no enforced Node >=18). Upgrade Vite to >=5.2 or use versions of the Tailwind/Vite plugin compatible with your Vite; verify Node requirement for the chosen Vite release.
examples/react/algolia/package.json (2)
11-11: @algolia/client-search 5.37.0 — fine for v5 lineNo action needed; just re-run the example build to be safe.
21-24: Confirm CI Node >=18 — Vite 6 compatibility OK@vitejs/[email protected] declares peerDependency "vite": "^4.2.0 || ^5.0.0 || ^6.0.0 || ^7.0.0" (so Vite 6 is supported). Vite 6.2.4 requires Node engines "node": "^18.0.0 || ^20.0.0 || >=22.0.0" — ensure your CI matrix includes Node >=18 (or 20/22).
| "solid-js": "^1.9.9", | ||
| "vinxi": "^0.5.8" | ||
| }, |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Sanity-check vinxi/SolidStart compatibility via build.
Quick build ensures no peer/exports drift after bumps.
🏁 Script executed:
#!/bin/bash
set -euo pipefail
pnpm -w -F @tanstack/query-example-solid-start-streaming install
pnpm -w -F @tanstack/query-example-solid-start-streaming run build
pnpm -w -F @tanstack/query-example-solid-start-streaming run versionLength of output: 57199
Build failed — vinxi SSR: Rollup can't resolve "@tanstack/query-core"
Quick verification (pnpm ... vinxi build) for examples/solid/solid-start-streaming failed: Rollup error "failed to resolve import '@tanstack/query-core' from packages/solid-query/build/index.js", aborting the SSR router build.
- Root cause: packages/solid-query's built output references @tanstack/query-core but it's not resolvable during the example's Vite SSR bundle.
- Fix options (pick one):
- Add "@tanstack/query-core" to examples/solid/solid-start-streaming/package.json dependencies so Vite can resolve it at build time.
- Or change packages/solid-query build (tsup/rollup) to bundle or correctly re-export query-core so the built index.js has no unresolved import.
- Or explicitly externalize "@tanstack/query-core" in the example's Vite build.rollupOptions.external if it's intended to be provided at runtime.
- Check: packages/solid-query/package.json and build/tsup/rollup config, and examples/solid/solid-start-streaming/package.json and Vite build config.
🤖 Prompt for AI Agents
In examples/solid/solid-start-streaming/package.json around lines 17-19, the SSR
build fails because packages/solid-query's bundle imports @tanstack/query-core
which Vite can't resolve; fix by adding "@tanstack/query-core" to this example's
dependencies in package.json (and run pnpm install) so Vite can resolve it at
build time, or alternatively update packages/solid-query's build config to
bundle or re-export query-core (or add "@tanstack/query-core" to the example's
Vite build.rollupOptions.external if it should be provided at runtime); verify
by running pnpm --filter examples/solid/solid-start-streaming install and then
pnpm --filter examples/solid/solid-start-streaming build.
ee7e0e7 to
1b0bc5a
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (3)
examples/angular/basic-persister/package.json (2)
1-11: Add engines.node to avoid unsupported Node on CI.Angular 20.x supports Node ^20.19.0, ^22.12.0, or ^24.0.0; encode this in engines for clarity. (angular.dev)
Apply:
"private": true, + "engines": { + "node": ">=20.19.0 <21 || >=22.12.0 <23 || >=24.0.0 <25" + },
24-27: TypeScript 5.8.3 is incompatible with Angular ≥20.2 — bump to ≥5.9.0.Angular 20.2.x+ requires TypeScript >=5.9.0 <6.0.0; keeping 5.8.3 will break installs/builds. Suggest 5.9.3 (or any >=5.9 <6). (angular.dev)
Apply:
"devDependencies": { "@angular/build": "^20.3.1", "@angular/cli": "^20.3.1", "@angular/compiler-cli": "^20.3.0", - "typescript": "5.8.3" + "typescript": "5.9.3" }examples/react/basic-graphql-request/package.json (1)
13-14: Build failed — unresolved import @tanstack/react-queryRunning the example build failed: Rollup couldn't resolve "@tanstack/react-query" imported from examples/react/basic-graphql-request/src/index.tsx. Add @tanstack/react-query to examples/react/basic-graphql-request/package.json dependencies (or adjust imports/build config) and re-run
pnpm -C examples/react/basic-graphql-request buildto confirm the example builds.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (81)
.github/workflows/autofix.yml(1 hunks).github/workflows/ci.yml(1 hunks).github/workflows/pr.yml(2 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(3 hunks)packages/angular-query-devtools-experimental/package.json(1 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (5)
- examples/react/suspense/package.json
- packages/react-query-persist-client/package.json
- examples/vue/dependent-queries/package.json
- examples/react/basic/package.json
- examples/svelte/auto-refetching/package.json
🚧 Files skipped from review as they are similar to previous changes (73)
- packages/query-devtools/package.json
- examples/react/shadow-dom/package.json
- examples/solid/simple/package.json
- examples/react/devtools-panel/package.json
- integrations/solid-vite/package.json
- examples/vue/nuxt3/package.json
- packages/query-persist-client-core/package.json
- examples/solid/default-query-function/package.json
- examples/react/default-query-function/package.json
- packages/solid-query-devtools/package.json
- examples/vue/basic/package.json
- examples/react/playground/package.json
- examples/react/eslint-legacy/package.json
- examples/svelte/playground/package.json
- packages/query-async-storage-persister/package.json
- examples/solid/astro/package.json
- examples/svelte/ssr/package.json
- examples/solid/basic/package.json
- examples/react/simple/package.json
- examples/react/offline/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- packages/query-broadcast-client-experimental/package.json
- packages/query-core/package.json
- examples/solid/solid-start-streaming/package.json
- examples/vue/persister/package.json
- packages/svelte-query-persist-client/package.json
- examples/vue/simple/package.json
- packages/vue-query-devtools/package.json
- examples/svelte/basic/package.json
- packages/react-query-next-experimental/package.json
- packages/angular-query-experimental/package.json
- integrations/vue-vite/package.json
- examples/angular/auto-refetching/package.json
- packages/svelte-query-devtools/package.json
- packages/solid-query-persist-client/package.json
- examples/angular/optimistic-updates/package.json
- packages/svelte-query/package.json
- examples/react/algolia/package.json
- examples/react/react-router/package.json
- packages/react-query/package.json
- integrations/react-vite/package.json
- examples/react/rick-morty/package.json
- packages/query-test-utils/package.json
- packages/angular-query-persist-client/package.json
- .github/workflows/autofix.yml
- integrations/svelte-vite/package.json
- examples/svelte/star-wars/package.json
- packages/vue-query/package.json
- examples/angular/rxjs/package.json
- integrations/react-webpack-4/package.json
- packages/solid-query/package.json
- examples/solid/basic-graphql-request/package.json
- .github/workflows/ci.yml
- examples/svelte/simple/package.json
- examples/react/chat/package.json
- examples/react/star-wars/package.json
- examples/angular/query-options-from-a-service/package.json
- packages/react-query-devtools/package.json
- integrations/react-next-15/package.json
- examples/svelte/optimistic-updates/package.json
- examples/react/react-native/package.json
- .github/workflows/pr.yml
- integrations/angular-cli-20/package.json
- packages/query-sync-storage-persister/package.json
- packages/angular-query-devtools-experimental/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/angular/devtools-panel/package.json
- examples/angular/basic/package.json
- packages/eslint-plugin-query/package.json
- examples/angular/simple/package.json
- package.json
- examples/angular/router/package.json
- examples/angular/pagination/package.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo
PR: TanStack/query#9612
File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0
Timestamp: 2025-09-02T17:57:33.184Z
Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.
Applied to files:
examples/angular/basic-persister/package.jsonexamples/react/basic-graphql-request/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (4)
examples/angular/basic-persister/package.json (2)
12-15: Angular 20.3.x set looks consistent.The core/common/compiler/platform-browser bumps are aligned. LGTM.
21-21: zone.js 0.15.1 matches @angular/core’s peer "~0.15.0".This satisfies the v20 peer requirement; no action needed. (app.unpkg.com)
integrations/react-webpack-5/package.json (1)
18-18: html-webpack-plugin patch bump is compatible with webpack 5.No action needed; this is a safe patch upgrade alongside webpack ^5.96.1.
examples/react/basic-graphql-request/package.json (1)
19-19: Verify CI Node ≥20 — ensure workflows aren’t pinned to Node 18 (for @vitejs/plugin-react ^4.7.0 + Vite 6)
Sandbox couldn’t inspect workflows; confirm all CI/GitHub Actions and matrices use Node >=20 (check .github/workflows/* for actions/setup-node / node-version / matrix.node), and verify package engines and repo version files (.nvmrc, .node-version, .tool-versions, examples/react/basic-graphql-request/package.json).
| "@babel/core": "^7.28.4", | ||
| "@babel/preset-env": "^7.28.3", | ||
| "@babel/preset-react": "^7.27.1", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Babel bumps look fine; verify Node engine and JSX runtime config.
- Ensure the repo’s Node version satisfies the engines required by @babel/core/@babel/preset-* 7.28.x.
- With React 19, confirm preset-react uses runtime: "automatic" to avoid implicit React imports and future default drift.
Run this quick scan to confirm config and engines:
Also confirm peer compatibility:
🏁 Script executed:
#!/bin/bash
# 1) Locate Babel config(s)
fd -a -g '.babelrc' -g '.babelrc.json' -g 'babel.config.*'
# 2) Inspect webpack config for babel-loader options and preset-react runtime
fd -a -g 'webpack.config.*' | xargs -I{} sh -c 'echo "=== {} ==="; rg -nP --glob "!**/node_modules/**" -C2 "@babel/preset-react|babel-loader|runtime\\s*:\\s*\\\"automatic\\\"" "{}" || true'
# 3) Check engines field(s)
fd -a -g "package.json" | xargs -I{} sh -c 'jq -r "[.name, (.engines.node // \"(no engines.node)\") ]|@tsv" "{}"' 2>/dev/null | rg -n "react-webpack-5|root|workspace"Length of output: 802
🌐 Web query:
What Node.js versions do @babel/[email protected] and [email protected] officially support? Did @babel/[email protected] change the default for the `runtime` option?
💡 Result:
Short answers:
- @babel/[email protected]: package.json lists engines.node ">=6.9.0". [1]
- [email protected]: README states supported Node.js versions >=14.15.0. [2]
- @babel/[email protected]: the preset's runtime option default is still "classic" (you can opt into "automatic"); Babel notes the default will change to "automatic" in Babel 8. [3][4]
Sources:
[1] @babel/core package.json (7.28.0).
[2] babel-loader README / npm (v9.x supported Node.js >=14.15.0).
[3] @babel/preset-react docs (runtime defaults to "classic").
[4] Babel 7.9 blog / changelog (notes default will switch to "automatic" in Babel 8).
Enforce Node >=14.15.0 and enable @babel/preset-react automatic runtime for react-webpack-5
- integrations/react-webpack-5/package.json: add "engines": { "node": ">=14.15.0" } — package currently has no engines; note @babel/[email protected] lists node>=6.9.0 but [email protected] requires Node >=14.15.0.
- integrations/react-webpack-5/webpack.config.js: pass runtime: "automatic" to @babel/preset-react (e.g. ['@babel/preset-react', { runtime: 'automatic' }]) — current presets array has no runtime option and defaults to "classic".
- Scan other integration webpack configs (e.g., integrations/react-webpack-4/webpack.config.js) for the same missing runtime.
🤖 Prompt for AI Agents
In integrations/react-webpack-5/package.json around lines 14-16, add an
"engines": { "node": ">=14.15.0" } entry to enforce the Node minimum required by
[email protected]; then update integrations/react-webpack-5/webpack.config.js to
pass runtime: "automatic" to the @babel/preset-react entry (e.g.
['@babel/preset-react', { runtime: 'automatic' }]) so JSX uses the new automatic
runtime; finally scan other integration webpack configs (for example
integrations/react-webpack-4/webpack.config.js) and add the same runtime:
"automatic" option where @babel/preset-react is used.
1b0bc5a to
68be592
Compare
This PR contains the following updates:
5.2.1->5.37.0^20.0.0->^20.3.0^20.0.0->^20.3.1^20.0.0->^20.3.1^20.0.0->^20.3.0^20.0.0->^20.3.0^20.0.0->^20.3.0^20.0.0->^20.3.0^20.0.0->^20.3.0^20.0.0->^20.3.0^20.0.0->^20.3.0^20.0.0->^20.3.0^20.0.0->^20.3.0^20.0.0->^20.3.0^20.0.0->^20.3.0^0.15.3->^0.18.2^5.0.7->^5.1.1^8.1.3->^8.2.7^7.26.0->^7.28.4^7.24.9->^7.28.4^7.26.0->^7.28.3^7.25.9->^7.27.1^8.17.1->^8.19.4^11.13.5->^11.14.0^11.13.5->^11.14.1^1.52.3->^1.53.1^10.0.5->^10.0.11^0.4.4->^0.5.1^0.13.4->^0.13.11^6.1.8->^6.5.0^6.1.8->^6.4.8^1.2.2->^1.5.2^2.0.26->^2.1.3^1.1.3->^1.2.0^6.0.1->^6.1.0^2.25.1->^2.39.1^2.4.0->^2.5.1^4.0.14->^4.1.13^5.76.0->^5.87.4^0.19.0->^0.20.1^17.3.7->^17.4.0^10.4.0->^10.4.1^6.6.3->^6.8.0^16.1.0->^16.3.0^2.0.0->^2.0.1^5.0.4->^5.0.5^8.37.0->^8.43.0^8.37.0->^8.43.0^8.37.0->^8.43.0^4.3.4->^4.7.0^4.3.4->^4.7.0^5.2.1->^5.2.43.1.3->3.2.4^1.1.36->^1.3.9^6.6.3->^6.6.4v4.2.2->v4.3.0^8.3.0->^8.4.1^7.0.0->^7.1.0^9.15.0->^9.35.0^50.5.0->^50.8.0^6.0.0-rc.1->^6.0.0-rc1^3.11.0->^3.12.3^9.27.0->^9.33.0^1.2.1->^1.2.2^52.0.11->^52.0.47^17.0.3->^17.1.7^2.0.0->^2.2.3^16.9.0->^16.11.0^7.1.2->^7.2.0^5.6.3->^5.6.4^6.2.1->^6.2.2^5.50.2->^5.63.1^2.6.6->^2.11.2^5.0.0->^5.0.2v4.1.2->v4.3.3^3.12.4->^3.19.221.3.0->21.5.210.13.1->10.16.1^2.5.2->^2.6.0^0.76.3->^0.81.4^2.20.2->^2.28.0^5.12.5->^5.14.5^3.16.2->^3.19.1^4.12.0->^4.14.1^4.1.0->^4.16.0^0.19.13->^0.21.1^6.25.1->^6.30.1^6.25.1->^6.30.1^8.0.0->^8.4.0~7.8.0->~7.8.2^1.9.7->^1.9.9^1.9.7->^1.9.9^0.2.3->^0.3.0^5.36.8->^5.38.10^4.3.0->^4.3.1^3.4.7->^3.4.17^3.4.7->^3.4.17^4.0.14->^4.1.13^0.2.14->^0.2.15^2.3.0->^2.8.1^0.5.3->^0.5.84.2.3->4.5.4^2.11.6->^2.11.8^2.11.6->^2.11.8Summary by CodeRabbit
Chores
CI