-
Notifications
You must be signed in to change notification settings - Fork 14
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Current implementation
The ThemeContextProvider accepts to configure the dimensions of the NavigationBar
:
dimensions: {
headerMobileHeight: number;
headerDesktopHeight: number;
};
But these dimensions are not being used by the NavigationBar
component
There is a context named FixedToTop
that allows to set the height of the elements that are being placed to the top (like a NavigationBar
) but the NavigationBar
component isn't using it, instead, as we see in the "default-page-layout" in webapp, this is manually used:
Possible improvements
- The
NavigationBar
component should set its height according to thedimensions
value from the theme - The
NavigationBar
component should set theFixedToTop
context value
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request