Skip to content

FixedToTop #1080

@pladaria

Description

@pladaria

Current implementation

The ThemeContextProvider accepts to configure the dimensions of the NavigationBar:

    dimensions: {
        headerMobileHeight: number;
        headerDesktopHeight: number;
    };

But these dimensions are not being used by the NavigationBar component

There is a context named FixedToTop that allows to set the height of the elements that are being placed to the top (like a NavigationBar) but the NavigationBar component isn't using it, instead, as we see in the "default-page-layout" in webapp, this is manually used:

https://github.com/Telefonica/webapp/blob/master/web/src/common/components/default-page-layout.tsx#L51

Possible improvements

  • The NavigationBar component should set its height according to the dimensions value from the theme
  • The NavigationBar component should set the FixedToTop context value

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions