Use is_dir instead of dir_size for non-existent folders after index deletion
#571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kounelisagis
force-pushed
the
agis/fix-ci-errors
branch
2 times, most recently
from
950720d to
bcc6bc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
dir_sizeon non-existent paths causesVFSExceptions to be thrown according to: https://github.com/TileDB-Inc/TileDB/blob/c36bce6517a46ce75f9a7c9090bd833ad40521b8/tiledb/sm/filesystem/vfs.cc#L209-L212.is_diris more suitable to call after index deletions in tests.This PR resolves the errors we're currently encountering in CI.
[sc-65377]