-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: Player Progress #1364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Player Progress #1364
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1364 +/- ##
==========================================
- Coverage 98.97% 98.96% -0.01%
==========================================
Files 203 203
Lines 22831 22916 +85
Branches 1007 1014 +7
==========================================
+ Hits 22596 22678 +82
- Misses 235 238 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a progress
property to the Player class that displays elapsed seconds since the player was started, accounting for playback rate changes, seeking, and looping behavior.
- Implements progress tracking using TickParam and Timeline components
- Adds comprehensive test coverage for various player scenarios
- Updates package version from 15.2.0 to 15.3.0
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
package.json | Version bump to 15.3.0 for the new feature |
Tone/source/buffer/Player.ts | Core implementation of progress tracking with private methods and properties |
Tone/source/buffer/Player.test.ts | Comprehensive test suite covering progress behavior in different scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Player.progress
displays the elapsed seconds since the player was started