Skip to content

Conversation

tambien
Copy link
Contributor

@tambien tambien commented Aug 27, 2025

Player.progress displays the elapsed seconds since the player was started

Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.96%. Comparing base (36f67b6) to head (164fc54).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1364      +/-   ##
==========================================
- Coverage   98.97%   98.96%   -0.01%     
==========================================
  Files         203      203              
  Lines       22831    22916      +85     
  Branches     1007     1014       +7     
==========================================
+ Hits        22596    22678      +82     
- Misses        235      238       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tambien tambien requested a review from Copilot September 1, 2025 00:59
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a progress property to the Player class that displays elapsed seconds since the player was started, accounting for playback rate changes, seeking, and looping behavior.

  • Implements progress tracking using TickParam and Timeline components
  • Adds comprehensive test coverage for various player scenarios
  • Updates package version from 15.2.0 to 15.3.0

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

File Description
package.json Version bump to 15.3.0 for the new feature
Tone/source/buffer/Player.ts Core implementation of progress tracking with private methods and properties
Tone/source/buffer/Player.test.ts Comprehensive test suite covering progress behavior in different scenarios

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@tambien tambien changed the title Player Progress feat: Player Progress Sep 1, 2025
@tambien tambien merged commit e8ca4c2 into dev Sep 1, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant